clk: Remove never used devm_clk_*unregister()
PATCH v2 1/1 clk: Remove never used devm_clk_*unregister()
For the entire history of the devm_clk_*unregister() existence they were used only once (*) in 2015. Remove them.
*) The commit 264e3b75de4e ("clk: s2mps11: Simplify s2mps11_clk_probe unwind
paths") exactly supports the point of the change proposed here.
---
v2: removed now unused match() functions as well
drivers/clk/clk.c | 48 ------------------------------------ include/linux/clk-provider.h | 2 -- 2 files changed, 50 deletions(-)
drivers/clk/clk.c +0 -48
@@ -4279,54 +4279,6 @@ int devm_clk_hw_register(struct device *dev, struct clk_hw *hw) }EXPORT_SYMBOL_GPL (devm_clk_hw_register); -static int devm_clk_match (struct device *dev,void *res,void *data) -{ -struct clk *c = res; -if (WARN_ON (!c)) -return 0 ; -return c == data; -} - -static int devm_clk_hw_match (struct device *dev,void *res,void *data) -{ -struct clk_hw *hw = res; - -if (WARN_ON (!hw)) -return 0 ; -return hw == data; -} - -/** -* devm_clk_unregister - resource managed clk_unregister() -* @dev: device that is unregistering the clock data -* @clk: clock to unregister -* -* Deallocate a clock allocated with devm_clk_register(). Normally -* this function will not need to be called and the resource management -* code will ensure that the resource is freed. -*/ -void devm_clk_unregister (struct device *dev,struct clk *clk) -{ -WARN_ON (devres_release (dev, devm_clk_unregister_cb, devm_clk_match, clk)); -} -EXPORT_SYMBOL_GPL (devm_clk_unregister); - -/** -* devm_clk_hw_unregister - resource managed clk_hw_unregister() -* @dev: device that is unregistering the hardware-specific clock data -* @hw: link to hardware-specific clock data -* -* Unregister a clk_hw registered with devm_clk_hw_register(). Normally -* this function will not need to be called and the resource management -* code will ensure that the resource is freed. -*/ -void devm_clk_hw_unregister (struct device *dev,struct clk_hw *hw) -{ -WARN_ON (devres_release (dev, devm_clk_hw_unregister_cb, devm_clk_hw_match, - hw)); -} -EXPORT_SYMBOL_GPL (devm_clk_hw_unregister); -static void devm_clk_release (struct device *dev,void *res) {clk_put (*(struct clk **)res);
include/linux/clk-provider.h +0 -2
@@ -1176,10 +1176,8 @@ int __must_check devm_clk_hw_register(struct device *dev, struct clk_hw *hw);int __must_check of_clk_hw_register (struct device_node *node,struct clk_hw *hw);void clk_unregister (struct clk *clk); -void devm_clk_unregister (struct device *dev,struct clk *clk);void clk_hw_unregister (struct clk_hw *hw); -void devm_clk_hw_unregister (struct device *dev,struct clk_hw *hw);/* helper functions */ const char *__clk_get_name (const struct clk *clk);
Signature · 1 line
2.35.1
Hello,
Quoted 7 lines · Andy Shevchenko
For the entire history of the devm_clk_*unregister() existence they were used only once (*) in 2015. Remove them.
*) The commit
264e3b75de4e("clk: s2mps11: Simplifys2mps11_clk_probeunwind
paths") exactly supports the point of the change proposed here.Signed-off-by Andy Shevchenko <[email protected]>
Nice
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoting Andy Shevchenko (2022-06-22 10:11:47)
Quoted 8 lines
For the entire history of the devm_clk_*unregister() existence they were used only once (*) in 2015. Remove them.
*) The commit
264e3b75de4e("clk: s2mps11: Simplifys2mps11_clk_probeunwind
paths") exactly supports the point of the change proposed here.Signed-off-by Andy Shevchenko <[email protected]>---
Applied to clk-next