staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function

PATCH Superseded Chang Yu 2 participants 2 messages Jun 23, 2022 Staging

lore

Share & tools

lore

Chang Yu

author

2022-06-23 02:24 UTC #0 lore raw

PATCH 1/1 staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function

Make rtw_signal_stat_timer_hdl a static function instead of a global function.

Signed-off-by Chang Yu <[email protected]>

---
 drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/r8188eu/core/rtw_recv.c +1 -1

index cc91638a085d..599d3e55be76 100644
@@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
 	0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };
 
-void rtw_signal_stat_timer_hdl(struct timer_list *t);
+static void rtw_signal_stat_timer_hdl(struct timer_list *t);
 
 void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
 {

Signature · 1 line

2.36.1

Philipp Hortmann

2022-06-23 04:21 UTC #1 lore raw

Quoted 13 lines · Chang Yu

Make rtw_signal_stat_timer_hdl a static function instead of a global function.
Signed-off-by Chang Yu <[email protected]>
---
  drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_recv.c +0 -0
index cc91638a085d..599d3e55be76 100644

drivers/staging/r8188eu/core/rtw_recv.c static u8 rtw_rfc1042_header[] = { · line 30

Quoted 8 lines

drivers/staging/r8188eu/core/rtw_recv.c +1 -1

@@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
  	0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
  };
 
-void rtw_signal_stat_timer_hdl(struct timer_list *t);
+static void rtw_signal_stat_timer_hdl(struct timer_list *t);
 
  void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
  {

Hi,

thanks for your patch. I think you need the "static" for the declaration and the definition of the function. So it is missing in line 1789.

Thanks for your support.

Bye Philipp