driver core: Ignore driver_async_probe cmdline param for module drivers
PATCH 1/1 driver core: Ignore driver_async_probe cmdline param for module drivers
If the module's async_probe option isn't set, the module loading code will do a async_synchronize_full() before returning to userspace. This effectively negates any benefits of driver_async_probe listing the module's driver.
If the module's async_probe is set, then we already do async probe for that module's driver even if driver_async_probe does not list that driver. So, again, the driver_async_probe's value doesn't matter for a module's driver.
So this change ignores the driver_async_probe for module drivers to avoid useless async probes.
In addition, if driver_async_probe lists a module's driver and the driver's async probe ends up calling request_module() in the async thread context, that's going to trigger a spurious WARNING stack dump without any real benefits of async probing. So this will avoid that unnecessary warning in that situation.
--- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/dd.c +1 -1
@@ -823,7 +823,7 @@ bool driver_allows_async_probing(struct device_driver *drv)return false;default : -if (cmdline_requested_async_probing (drv->name)) +if (cmdline_requested_async_probing (drv->name) && drv->owner ==NULL )return true;if (module_requested_async_probing (drv->owner))
Signature · 1 line
2.37.0.rc0.161.g10f37bed90-goog
Greg Kroah-Hartman
maintainerQuoted 13 lines · Saravana Kannan
If the module's
async_probeoption isn't set, the module loading code will do aasync_synchronize_full()before returning to userspace. This effectively negates any benefits ofdriver_async_probelisting the module's driver.If the module's
async_probeis set, then we already do async probe for that module's driver even ifdriver_async_probedoes not list that driver. So, again, the driver_async_probe's value doesn't matter for a module's driver.So this change ignores the
driver_async_probefor module drivers to avoid useless async probes.
Quoted 7 lines
In addition, if
driver_async_probelists a module's driver and the driver's async probe ends up callingrequest_module()in the async thread context, that's going to trigger a spurious WARNING stack dump without any real benefits of async probing. So this will avoid that unnecessary warning in that situation.Signed-off-by Saravana Kannan <[email protected]>
Does this "fix" an older commit? Does this need to be backported anywhere? Or is this just a new feature to help make things work properly going forward?
Quoted 9 lines
--- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/base/dd.c +0
-0
drivers/base/dd.c bool driver_allows_async_probing(struct device_driver *drv) · line 826
Quoted 5 lines
drivers/base/dd.c +1
-1@@ -823,7 +823,7 @@ bool driver_allows_async_probing(struct device_driver *drv)return false;default : -if (cmdline_requested_async_probing (drv->name)) +if (cmdline_requested_async_probing (drv->name) && drv->owner ==NULL )
This feels odd, the module owner shouldn't be used for anything other then the reference for the module being properly handled. Not doing different logic for built-in vs. not-built-in feels wrong, especially asa some module drivers might not set the owner field for various reasons (hint, networking drivers do not deal with the owner field as they have different ways of handling the module reference logic.)
So I don't think this is ok, sorry. Did you test this with networking drivers?
thanks,
greg k-h