soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume()
PATCH v2 1/1 soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume()
Fix the missing clk_disable_unprepare() before return from svs_resume() in the error handling case.
Signed-off-by Peng Wu <[email protected]>
Reported-by Hulk Robot <[email protected]>
---
v2:
- Same holds for the error path of svs_init02().
--- drivers/soc/mediatek/mtk-svs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/soc/mediatek/mtk-svs.c +6 -2
@@ -1526,16 +1526,20 @@ static int svs_resume(struct device *dev) ret =reset_control_deassert (svsp->rst);if (ret) {dev_err (svsp->dev,"cannot deassert reset %d\n" , ret); -return ret; + goto out_of_resume; } ret =svs_init02 (svsp);if (ret) -return ret; + goto out_of_resume;svs_mon_mode (svsp);return 0 ; + +out_of_resume: +clk_disable_unprepare (svsp->main_clk); +return ret; }static int svs_bank_resource_setup (struct svs_platform *svsp)
Signature · 1 line
2.17.1
Quoted 5 lines · Peng Wu
Fix the missing
clk_disable_unprepare()before return fromsvs_resume()in the error handling case.Signed-off-by Peng Wu <[email protected]>Reported-by Hulk Robot <[email protected]>
Applied, thanks!
Quoted 34 lines
---
v2:
- Same holds for the error path ofsvs_init02().--- drivers/soc/mediatek/mtk-svs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/soc/mediatek/mtk-svs.c +6
-2@@ -1526,16 +1526,20 @@ static int svs_resume(struct device *dev) ret =reset_control_deassert (svsp->rst);if (ret) {dev_err (svsp->dev,"cannot deassert reset %d\n" , ret); -return ret; + goto out_of_resume; } ret =svs_init02 (svsp);if (ret) -return ret; + goto out_of_resume;svs_mon_mode (svsp);return 0 ; + +out_of_resume: +clk_disable_unprepare (svsp->main_clk); +return ret; }static int svs_bank_resource_setup (struct svs_platform *svsp)