Skip to contentSkip to conversation

meson.build: Require a recent version of libpng

PATCH Applied Thomas Huth 3 participants 3 messages Jun 23, 2022 – Jun 24, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meson.build: Require a recent version of libpng

According to https://gitlab.com/qemu-project/qemu/-/issues/1080#note_998088246
QEMU does not compile with older versions of libpng, so we should check for a good version in meson.build. According to repology.org, our supported host target operating systems ship these versions:

             Fedora 35: 1.6.37
     CentOS 8 (RHEL-8): 1.6.34
             Debian 11: 1.6.37
    OpenSUSE Leap 15.3: 1.6.34
      Ubuntu LTS 20.04: 1.6.37
         FreeBSD Ports: 1.6.37
         NetBSD pkgsrc: 1.6.37
         OpenBSD Ports: 1.6.37
              Homebrew: 1.6.37
           MSYS2 mingw: 1.6.37

So it seem reasonable to require at least libpng version 1.6.34 for our builds.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1080

---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meson.build +1 -1
index 094c4ce832..164ecb2fab 100644
@@ -1209,7 +1209,7 @@ if gtkx11.found()
 endif
 png = not_found
 if get_option('png').allowed() and have_system
-   png = dependency('libpng', required: get_option('png'),
+   png = dependency('libpng', version: '>=1.6.34', required: get_option('png'),
                     method: 'pkg-config', kwargs: static_kwargs)
 endif
 vnc = not_found
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Thomas Huth

According to https://gitlab.com/qemu-project/qemu/-/issues/1080#note_998088246
QEMU does not compile with older versions of libpng, so we should check for a good version in meson.build. According to repology.org, our supported host target operating systems ship these versions:

              Fedora 35: 1.6.37
      CentOS 8 (RHEL-8): 1.6.34
              Debian 11: 1.6.37
     OpenSUSE Leap 15.3: 1.6.34
       Ubuntu LTS 20.04: 1.6.37
          FreeBSD Ports: 1.6.37
          NetBSD pkgsrc: 1.6.37
          OpenBSD Ports: 1.6.37
               Homebrew: 1.6.37
            MSYS2 mingw: 1.6.37
Quoted 5 lines

So it seem reasonable to require at least libpng version 1.6.34 for our builds.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1080

r~