dt-bindings: firmware: qcom-scm: convert to dtschema
PATCH 1/1 dt-bindings: firmware: qcom-scm: convert to dtschema
Convert bindings for Qualcomm SCM to dtschema.
SoC compatibles that were used, but not documented were added.
--- .../devicetree/bindings/firmware/qcom,scm.txt | 57 -------- .../bindings/firmware/qcom,scm.yaml | 124 ++++++++++++++++++ 2 files changed, 124 insertions(+), 57 deletions(-) delete mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.txt create mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.yaml
Documentation/devicetree/bindings/firmware/qcom,scm.txt deleted +0 -57
@@ -1,57 +0,0 @@ -QCOM Secure Channel Manager (SCM) - -Qualcomm processors include an interface to communicate to the secure firmware. -This interface allows for clients to request different types of actions. These -can include CPU power up/down, HDCP requests, loading of firmware, and other -assorted actions. - -Required properties: -- compatible: must contain one of the following: - * "qcom,scm-apq8064" - * "qcom,scm-apq8084" - * "qcom,scm-ipq4019" - * "qcom,scm-ipq806x" - * "qcom,scm-ipq8074" - * "qcom,scm-mdm9607" - * "qcom,scm-msm8226" - * "qcom,scm-msm8660" - * "qcom,scm-msm8916" - * "qcom,scm-msm8953" - * "qcom,scm-msm8960" - * "qcom,scm-msm8974" - * "qcom,scm-msm8976" - * "qcom,scm-msm8994" - * "qcom,scm-msm8996" - * "qcom,scm-msm8998" - * "qcom,scm-sc7180" - * "qcom,scm-sc7280" - * "qcom,scm-sdm845" - * "qcom,scm-sdx55" - * "qcom,scm-sm6350" - * "qcom,scm-sm8150" - * "qcom,scm-sm8250" - * "qcom,scm-sm8350" - * "qcom,scm-sm8450" - and: - * "qcom,scm" -- clocks: Specifies clocks needed by the SCM interface, if any: - * core clock required for "qcom,scm-apq8064", "qcom,scm-msm8660" and - "qcom,scm-msm8960" - * core, iface and bus clocks required for "qcom,scm-apq8084", - "qcom,scm-msm8916", "qcom,scm-msm8953", "qcom,scm-msm8974" and "qcom,scm-msm8976" -- clock-names: Must contain "core" for the core clock, "iface" for the interface - clock and "bus" for the bus clock per the requirements of the compatible. -- qcom,dload-mode: phandle to the TCSR hardware block and offset of the - download mode control register (optional) - -Example for MSM8916: - - firmware { - scm { - compatible = "qcom,msm8916", "qcom,scm"; - clocks = <&gcc GCC_CRYPTO_CLK> , - <&gcc GCC_CRYPTO_AXI_CLK>, - <&gcc GCC_CRYPTO_AHB_CLK>; - clock-names = "core", "bus", "iface"; - }; - };
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +124 -0
124 lines not on this page · raw message
Signature · 1 line
2.36.1
Quoted 81 lines · Robert Marko
Convert bindings for Qualcomm SCM to dtschema.
SoC compatibles that were used, but not documented were added.
Signed-off-by Robert Marko <[email protected]>--- .../devicetree/bindings/firmware/qcom,scm.txt | 57 -------- .../bindings/firmware/qcom,scm.yaml | 124 ++++++++++++++++++ 2 files changed, 124 insertions(+), 57 deletions(-) delete mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.txt create mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.yamlDocumentation/devicetree/bindings/firmware/qcom,scm.txt deleted +0
-57@@ -1,57 +0,0 @@ -QCOM Secure Channel Manager (SCM) - -Qualcomm processors include an interface to communicate to the secure firmware. -This interface allows for clients to request different types of actions. These -can include CPU power up/down, HDCP requests, loading of firmware, and other -assorted actions. - -Required properties: -- compatible: must contain one of the following: - * "qcom,scm-apq8064" - * "qcom,scm-apq8084" - * "qcom,scm-ipq4019" - * "qcom,scm-ipq806x" - * "qcom,scm-ipq8074" - * "qcom,scm-mdm9607" - * "qcom,scm-msm8226" - * "qcom,scm-msm8660" - * "qcom,scm-msm8916" - * "qcom,scm-msm8953" - * "qcom,scm-msm8960" - * "qcom,scm-msm8974" - * "qcom,scm-msm8976" - * "qcom,scm-msm8994" - * "qcom,scm-msm8996" - * "qcom,scm-msm8998" - * "qcom,scm-sc7180" - * "qcom,scm-sc7280" - * "qcom,scm-sdm845" - * "qcom,scm-sdx55" - * "qcom,scm-sm6350" - * "qcom,scm-sm8150" - * "qcom,scm-sm8250" - * "qcom,scm-sm8350" - * "qcom,scm-sm8450" - and: - * "qcom,scm" -- clocks: Specifies clocks needed by the SCM interface, if any: - * core clock required for "qcom,scm-apq8064", "qcom,scm-msm8660" and - "qcom,scm-msm8960" - * core, iface and bus clocks required for "qcom,scm-apq8084", - "qcom,scm-msm8916", "qcom,scm-msm8953", "qcom,scm-msm8974" and "qcom,scm-msm8976" -- clock-names: Must contain "core" for the core clock, "iface" for the interface - clock and "bus" for the bus clock per the requirements of the compatible. -- qcom,dload-mode: phandle to the TCSR hardware block and offset of the - download mode control register (optional) - -Example for MSM8916: - - firmware { - scm { - compatible = "qcom,msm8916", "qcom,scm"; - clocks = <&gcc GCC_CRYPTO_CLK> , - <&gcc GCC_CRYPTO_AXI_CLK>, - <&gcc GCC_CRYPTO_AHB_CLK>; - clock-names = "core", "bus", "iface"; - }; - };Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +0
-0
Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 10
Quoted 10 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +10
-0@@ -0,0 +1,124 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/firmware/qcom,scm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: QCOM Secure Channel Manager (SCM) bindings + +maintainers: + - Robert Marko <[email protected]>
I'd like to volunteer my name as well, if that's okay:
Guru Das Srinagesh <[email protected]>
Quoted 2 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +2
-0+ +description: |
...
Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 57
Quoted 3 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +3
-0+ + '#reset-cells': + const: 1
This isn't part of the original file - could you please explain why this is being added?
Quoted 40 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +40
-0+ + qcom,dload-mode: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: + Phandle to the TCSR hardware block and offset of the download mode control register + +required: + - compatible + +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,scm-apq8064 + - qcom,scm-msm8660 + - qcom,scm-msm8960 + then: + properties: + clocks: + items: + - description: SCM core clock + clock-names: + items: + - const: core + + - if: + properties: + compatible: + contains: + enum: + - qcom,scm-apq8084 + - qcom,scm-mdm9607 + - qcom,scm-msm8916 + - qcom,scm-msm8953 + - qcom,scm-msm8974 + - qcom,scm-msm8976 + then: + properties:
Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 107
Quoted 10 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +10
-0+ clocks: + items: + - description: SCM core clock + - description: SCM bus clock + - description: SCM interface clock + clock-names: + items: + - const: core + - const: bus + - const: iface
Thanks, I had this YAML conversion patch done locally, but couldn't figure out how to represent the above logic in YAML. Thank you for this patch.
Quoted 20 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +17
-0+ +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,gcc-msm8916.h> + firmware { + scm { + compatible = "qcom,scm-msm8916", "qcom,scm"; + + clocks = <&gcc GCC_CRYPTO_CLK>, + <&gcc GCC_CRYPTO_AXI_CLK>, + <&gcc GCC_CRYPTO_AHB_CLK>; + clock-names = "core", "bus", "iface"; + qcom,dload-mode = <&tcsr 0x6100>; + }; + };Signature · 1 line
2.36.1
Quoted 96 lines · Guru Das Srinagesh
Quoted 81 lines · Robert Marko
Convert bindings for Qualcomm SCM to dtschema.
SoC compatibles that were used, but not documented were added.
Signed-off-by Robert Marko <[email protected]>--- .../devicetree/bindings/firmware/qcom,scm.txt | 57 -------- .../bindings/firmware/qcom,scm.yaml | 124 ++++++++++++++++++ 2 files changed, 124 insertions(+), 57 deletions(-) delete mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.txt create mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.yamlDocumentation/devicetree/bindings/firmware/qcom,scm.txt deleted +0
-57@@ -1,57 +0,0 @@ -QCOM Secure Channel Manager (SCM) - -Qualcomm processors include an interface to communicate to the secure firmware. -This interface allows for clients to request different types of actions. These -can include CPU power up/down, HDCP requests, loading of firmware, and other -assorted actions. - -Required properties: -- compatible: must contain one of the following: - * "qcom,scm-apq8064" - * "qcom,scm-apq8084" - * "qcom,scm-ipq4019" - * "qcom,scm-ipq806x" - * "qcom,scm-ipq8074" - * "qcom,scm-mdm9607" - * "qcom,scm-msm8226" - * "qcom,scm-msm8660" - * "qcom,scm-msm8916" - * "qcom,scm-msm8953" - * "qcom,scm-msm8960" - * "qcom,scm-msm8974" - * "qcom,scm-msm8976" - * "qcom,scm-msm8994" - * "qcom,scm-msm8996" - * "qcom,scm-msm8998" - * "qcom,scm-sc7180" - * "qcom,scm-sc7280" - * "qcom,scm-sdm845" - * "qcom,scm-sdx55" - * "qcom,scm-sm6350" - * "qcom,scm-sm8150" - * "qcom,scm-sm8250" - * "qcom,scm-sm8350" - * "qcom,scm-sm8450" - and: - * "qcom,scm" -- clocks: Specifies clocks needed by the SCM interface, if any: - * core clock required for "qcom,scm-apq8064", "qcom,scm-msm8660" and - "qcom,scm-msm8960" - * core, iface and bus clocks required for "qcom,scm-apq8084", - "qcom,scm-msm8916", "qcom,scm-msm8953", "qcom,scm-msm8974" and "qcom,scm-msm8976" -- clock-names: Must contain "core" for the core clock, "iface" for the interface - clock and "bus" for the bus clock per the requirements of the compatible. -- qcom,dload-mode: phandle to the TCSR hardware block and offset of the - download mode control register (optional) - -Example for MSM8916: - - firmware { - scm { - compatible = "qcom,msm8916", "qcom,scm"; - clocks = <&gcc GCC_CRYPTO_CLK> , - <&gcc GCC_CRYPTO_AXI_CLK>, - <&gcc GCC_CRYPTO_AHB_CLK>; - clock-names = "core", "bus", "iface"; - }; - };Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +0
-0Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 10
Quoted 10 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +10
-0@@ -0,0 +1,124 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/firmware/qcom,scm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: QCOM Secure Channel Manager (SCM) bindings + +maintainers: + - Robert Marko <[email protected]>I'd like to volunteer my name as well, if that's okay:
Quoted 1 line
Guru Das Srinagesh <[email protected]>
Hi,
Sure, will add you to v2.
Quoted 10 lines
Quoted 3 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +2
-0+ +description: |...
Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 57
Quoted 3 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +3
-0+ + '#reset-cells': + const: 1This isn't part of the original file - could you please explain why this is being added?
Yes, its not part of the original file, however I noticed that a lot of SCM nodes were adding #reset-cells, and upon looking at the SCM code its clear that it is being registered as a reset controller so #reset-cells are appropriate.
However, since its not really being used via phandles #reset-cells did not really matter, hence why I did not add them to be required, this is something that DT guys can probably clarify.
Regards,
Robert
Quoted 75 lines
Quoted 41 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +40
-0+ + qcom,dload-mode: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: + Phandle to the TCSR hardware block and offset of the download mode control register + +required: + - compatible + +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,scm-apq8064 + - qcom,scm-msm8660 + - qcom,scm-msm8960 + then: + properties: + clocks: + items: + - description: SCM core clock + clock-names: + items: + - const: core + + - if: + properties: + compatible: + contains: + enum: + - qcom,scm-apq8084 + - qcom,scm-mdm9607 + - qcom,scm-msm8916 + - qcom,scm-msm8953 + - qcom,scm-msm8974 + - qcom,scm-msm8976 + then: + properties:Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 107
Quoted 10 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +10
-0+ clocks: + items: + - description: SCM core clock + - description: SCM bus clock + - description: SCM interface clock + clock-names: + items: + - const: core + - const: bus + - const: ifaceThanks, I had this YAML conversion patch done locally, but couldn't figure out how to represent the above logic in YAML. Thank you for this patch.
Quoted 20 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +17
-1+ +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,gcc-msm8916.h> + firmware { + scm { + compatible = "qcom,scm-msm8916", "qcom,scm"; + + clocks = <&gcc GCC_CRYPTO_CLK>, + <&gcc GCC_CRYPTO_AXI_CLK>, + <&gcc GCC_CRYPTO_AHB_CLK>; + clock-names = "core", "bus", "iface"; + qcom,dload-mode = <&tcsr 0x6100>; + }; + }; --2.36.1
Quoted 14 lines · Robert Marko
Quoted 6 lines · Guru Das Srinagesh
Quoted 2 lines · Robert Marko
(quoted diff) +2
-0+ +description: |...
Quoted 6 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 57
Quoted 3 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +3
-0+ + '#reset-cells': + const: 1This isn't part of the original file - could you please explain why this is being added?
Quoted 8 lines
Yes, its not part of the original file, however I noticed that a lot of SCM nodes were adding #reset-cells, and upon looking at the SCM code its clear that it is being registered as a reset controller so #reset-cells are appropriate.
However, since its not really being used via phandles #reset-cells did not really matter, hence why I did not add them to be required, this is something that DT guys can probably clarify.
Makes sense, ACK.
Thank you.
Guru Das.
Quoted 20 lines · Guru Das Srinagesh
Quoted 19 lines · Robert Marko
Quoted 6 lines · Guru Das Srinagesh
Quoted 2 lines · Robert Marko
(quoted diff) +2
-0+ +description: |...
Quoted 6 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml line 57
Quoted 3 lines
Documentation/devicetree/bindings/firmware/qcom,scm.yaml new file +3
-0+ + '#reset-cells': + const: 1This isn't part of the original file - could you please explain why this is being added?
Yes, its not part of the original file, however I noticed that a lot of SCM nodes were adding #reset-cells, and upon looking at the SCM code its clear that it is being registered as a reset controller so #reset-cells are appropriate.
Quoted 5 lines
Quoted 3 lines
However, since its not really being used via phandles #reset-cells did not really matter, hence why I did not add them to be required, this is something that DT guys can probably clarify.
Makes sense, ACK.
Please mention deviations from conversion in the commit msg.
Best regards,
Krzysztof
Quoted 5 lines · Robert Marko
Convert bindings for Qualcomm SCM to dtschema.
SoC compatibles that were used, but not documented were added.
Signed-off-by Robert Marko <[email protected]>
This was already submitted:
https://lore.kernel.org/all/[email protected]/
David,
Do you intend to work on the bindings you submitted before? There are several pending on your side (things to be fixed), so I am not sure if work is abandoned or just waiting.
Best regards,
Krzysztof
Quoted 10 lines · Krzysztof Kozlowski
Quoted 5 lines · Robert Marko
Convert bindings for Qualcomm SCM to dtschema.
SoC compatibles that were used, but not documented were added.
Signed-off-by Robert Marko <[email protected]>This was already submitted:
https://lore.kernel.org/all/[email protected]/
Hi Krzysztof,
I was not aware there was already a version sent, just used linux-next as the base
and it wasn't there so I assumed, will search through the archives next time.
Anyway, that attempt looks abandoned.
Regards,
Robert
Quoted 8 lines
David,
Do you intend to work on the bindings you submitted before? There are several pending on your side (things to be fixed), so I am not sure if work is abandoned or just waiting.Best regards,
Krzysztof
Quoted 8 lines · Robert Marko
Quoted 6 lines · Krzysztof Kozlowski
Quoted 4 lines · Robert Marko
Convert bindings for Qualcomm SCM to dtschema.
SoC compatibles that were used, but not documented were added.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Robert Marko <[email protected]>This was already submitted:
https://lore.kernel.org/all/[email protected]/Hi Krzysztof,
I was not aware there was already a version sent, just used linux-next as the base
lore and "dfn" keyword. Several people are working on Qualcomm bindings, so that's the only way to check it.
Quoted 3 lines
and it wasn't there so I assumed, will search through the archives next time.
Anyway, that attempt looks abandoned.
Let's give few days to David to respond and to re-submit. If he does, I am for FIFO approach. If David does not resubmits, then check the review he got to be sure there is no need for same feedback.
Best regards,
Krzysztof
Quoted 23 lines · Krzysztof Kozlowski
Quoted 8 lines · Robert Marko
Quoted 6 lines · Krzysztof Kozlowski
Quoted 4 lines · Robert Marko
Convert bindings for Qualcomm SCM to dtschema.
SoC compatibles that were used, but not documented were added.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Robert Marko <[email protected]>This was already submitted:
https://lore.kernel.org/all/[email protected]/Hi Krzysztof,
I was not aware there was already a version sent, just used linux-next as the baselore and "dfn" keyword. Several people are working on Qualcomm bindings, so that's the only way to check it.
Quoted 7 lines
Quoted 3 lines
and it wasn't there so I assumed, will search through the archives next time.
Anyway, that attempt looks abandoned.
Let's give few days to David to respond and to re-submit. If he does, I am for FIFO approach. If David does not resubmits, then check the review he got to be sure there is no need for same feedback.
I see that David sent a v2 today, I'm just glad to get this converted.
Regards,
Robert
Quoted 4 lines
Best regards,
Krzysztof