drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT
Subsystems (3)
PATCH 1/1 drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT
sparse reportsdrivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?
Neither of thse variables is used in dc_link_dp.c. Reviewing the commit listed in the fixes tag shows neither was used in the original patch. So remove them.
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 --- 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0 -3
@@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_return true; } -bool FORCE_RATE = false; -uint32_t FORCE_LANE_COUNT =0 ; -void decide_link_settings (struct dc_stream_state *stream,struct dc_link_settings *link_setting) {
Signature · 1 line
2.27.0
Quoted 18 lines · Tom Rix
sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?Neither of thse variables is used in
dc_link_dp.c. Reviewing the commit listed in the fixes tag shows neither was used in the original patch. So remove them.Fixes 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 --- 1 file changed, 3 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0
-0
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_ · line 3887
Quoted 9 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0
-3@@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_return true; } -bool FORCE_RATE = false; -uint32_t FORCE_LANE_COUNT =0 ; -void decide_link_settings (struct dc_stream_state *stream,struct dc_link_settings *link_setting) {
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 34 lines · Aurabindo Pillai
Quoted 18 lines · Tom Rix
sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?Neither of thse variables is used in
dc_link_dp.c. Reviewing the commit listed in the fixes tag shows neither was used in the original patch. So remove them.Fixes 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 --- 1 file changed, 3 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0
-0drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_ · line 3887
Quoted 9 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0
-3@@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_return true; } -bool FORCE_RATE = false; -uint32_t FORCE_LANE_COUNT =0 ; -void decide_link_settings (struct dc_stream_state *stream,struct dc_link_settings *link_setting) {Reviewed-by Aurabindo Pillai <[email protected]>