thermal: k3_j72xx_bandgap: Fix memory leak in k3_j72xx_bandgap_probe
PATCH 1/1 thermal: k3_j72xx_bandgap: Fix memory leak in k3_j72xx_bandgap_probe
ref_table is allocated in kzalloc, but it doesn't get freed in later error paths. This function only release it in normal path. Fix this by add err_free_ref_table label and goto this in some error paths.
Fixes ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver
support")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/thermal/k3_j72xx_bandgap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/thermal/k3_j72xx_bandgap.c +4 -2
@@ -433,7 +433,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev) GFP_KERNEL);if (!derived_table) { ret = -ENOMEM ; - goto err_alloc; + goto err_free_ref_table; }/* Workaround not needed if bit30/bit31 is set even for J721e */
@@ -483,7 +483,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)if (IS_ERR (ti_thermal)) {dev_err (bgp->dev,"thermal zone device is NULL\n" ); ret =PTR_ERR (ti_thermal); - goto err_alloc; + goto err_free_ref_table; } }
@@ -514,6 +514,8 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)return 0 ; +err_free_ref_table: +kfree (ref_table); err_alloc:pm_runtime_put_sync (&pdev->dev);pm_runtime_disable (&pdev->dev);
Signature · 1 line
2.25.1