Skip to contentSkip to conversation

devtmpfs: fix the dangling pointer of global devtmpfsd thread

PATCH New Yangxi Xiang 1 participant 1 message Jun 27, 2022 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtmpfs: fix the dangling pointer of global devtmpfsd thread

When the devtmpfs fails to mount, a dangling pointer still remains in global. Specifically, the err variable is passed by a pointer to the devtmpfsd. When the devtmpfsd exits, it sets the error and completes the setup_done. In this situation, the thread pointer is not set to null. After the devtmpfsd exited, the devtmpfs can wakes up the destroyed devtmpfsd thread by wake_up_process if a device change event comes.

---
 drivers/base/devtmpfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/base/devtmpfs.c +1 -0
index 8a3ddbae3b70..e4bffeabf344 100644
@@ -482,6 +482,7 @@ int __init devtmpfs_init(void)
 	if (err) {
 		printk(KERN_ERR "devtmpfs: unable to create devtmpfs %i\n", err);
 		unregister_filesystem(&dev_fs_type);
+		thread = NULL;
 		return err;
 	}
 
Signature · 1 line
2.17.1