Skip to contentSkip to conversation

drivers/soc/mediatek: mark svs_resume and svs_suspend as maybe unused

PATCH In review Max Filippov 2 participants 2 messages Jun 28, 2022 – Jun 29, 2022 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/soc/mediatek: mark svs_resume and svs_suspend as maybe unused

This fixes the following build errors on platforms without hibernation support in linux-next:

drivers/soc/mediatek/mtk-svs.c:1515:12: error: ‘svs_resume’ defined but not used [-Werror=unused-function] drivers/soc/mediatek/mtk-svs.c:1481:12: error: ‘svs_suspend’ defined but not used [-Werror=unused-function]

Fixes 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")
---
 drivers/soc/mediatek/mtk-svs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/mediatek/mtk-svs.c +2 -2
index 87e05ab51552..363ab8bffa9f 100644
@@ -1478,7 +1478,7 @@ static int svs_start(struct svs_platform *svsp)
 	return 0;
 }
 
-static int svs_suspend(struct device *dev)
+static int __maybe_unused svs_suspend(struct device *dev)
 {
 	struct svs_platform *svsp = dev_get_drvdata(dev);
 	struct svs_bank *svsb;
@@ -1512,7 +1512,7 @@ static int svs_suspend(struct device *dev)
 	return 0;
 }
 
-static int svs_resume(struct device *dev)
+static int __maybe_unused svs_resume(struct device *dev)
 {
 	struct svs_platform *svsp = dev_get_drvdata(dev);
 	int ret;
Signature · 1 line
2.30.2
#1 lore raw

Il 28/06/22 14:13, Max Filippov ha scritto:

Quoted 8 lines

This fixes the following build errors on platforms without hibernation support in linux-next:

drivers/soc/mediatek/mtk-svs.c:1515:12: error: ‘svs_resume’ defined but not used [-Werror=unused-function] drivers/soc/mediatek/mtk-svs.c:1481:12: error: ‘svs_suspend’ defined but not used [-Werror=unused-function]

Fixes 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")

Hello Max,

This is not the right solution... and besides, there's something else in the works; check here:

https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

Regards,
Angelo