Skip to contentSkip to conversation

iavf: Fix pending DMA allocations while released from device

PATCH Superseded Palczewski, Mateusz 2 participants 2 messages Jun 28, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover iavf: Fix pending DMA allocations while released from device

Fix multiple issues that can arise, when VF cannot configure ASQ/ARQ properly. Failing to do so can lead to driver hang, null ptr dereference and possible DMA allocations leak.

---
v2: Add comment to make code more understandable
---

Przemyslaw Patynowski (3):
iavf: Fix reset error handling
iavf: Fix NULL pointer dereference in iavf_get_link_ksettings
iavf: Fix adminq error handling

 drivers/net/ethernet/intel/iavf/iavf_adminq.c  | 15 +++++++++++++--
 drivers/net/ethernet/intel/iavf/iavf_ethtool.c |  6 ++++++
 drivers/net/ethernet/intel/iavf/iavf_main.c    | 14 ++++++++++----
 3 files changed, 29 insertions(+), 6 deletions(-)
Signature · 6 lines
2.27.0

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
#1 lore raw

From: "Palczewski, Mateusz" <[email protected]>
Date: Tue, 28 Jun 2022 15:43:08 +0200

First, please check your Git mail settings. You appear as '"Palczewski, Mateusz"' in the 'From:' mail header, but at the same time as 'Mateusz Palczewski' in Signed-off-bys. That's not how it should look like, please pick one (preferably the one from SoBs) and make sure it's configured properly everywhere.

Quoted 4 lines

Fix multiple issues that can arise, when VF cannot configure ASQ/ARQ properly. Failing to do so can lead to driver hang, null ptr dereference and possible DMA allocations leak.

Quoted 8 lines

---
v2: Add comment to make code more understandable
---

Przemyslaw Patynowski (3):
iavf: Fix reset error handling
iavf: Fix NULL pointer dereference in iavf_get_link_ksettings
iavf: Fix adminq error handling

Second, please check your Git mail settings again in regards to that Git doesn't make a thread from your patch series, e.g. it doesn't put correct 'In-Reply-To:' and 'References:' headers starting from the second message. That breaks Patchwork, i.e. it won't be able to test it as a series etc.

Please do a resend once you fix all of these.

Quoted 8 lines
 drivers/net/ethernet/intel/iavf/iavf_adminq.c  | 15 +++++++++++++--
 drivers/net/ethernet/intel/iavf/iavf_ethtool.c |  6 ++++++
 drivers/net/ethernet/intel/iavf/iavf_main.c    | 14 ++++++++++----
 3 files changed, 29 insertions(+), 6 deletions(-)
Signature · 1 line
2.27.0

Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan