drm/vc4: change vc4_dma_range_matches from a global to static
Subsystems (3)
PATCH 1/1 drm/vc4: change vc4_dma_range_matches from a global to static
sparse reportsdrivers/gpu/drm/vc4/vc4_drv.c:270:27: warning: symbol 'vc4_dma_range_matches' was not declared. Should it be static?
vc4_dma_range_matches is only used in vc4_drv.c, so it's storage class specifier should be static.
Fixes da8e393e23ef ("drm/vc4: drv: Adopt the dma configuration from the HVS or V3D component")
Signed-off-by Tom Rix <[email protected]>
--- drivers/gpu/drm/vc4/vc4_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_drv.c +1 -1
@@ -267,7 +267,7 @@ static void vc4_match_add_drivers(struct device *dev, } } -const struct of_device_id vc4_dma_range_matches[] = { +static const struct of_device_id vc4_dma_range_matches[] = { { .compatible ="brcm,bcm2711-hvs" }, { .compatible ="brcm,bcm2835-hvs" }, { .compatible ="brcm,bcm2835-v3d" },
Signature · 1 line
2.27.0
Maxime Ripard
AppliedRe: (subset) [PATCH] drm/vc4: change vc4_dma_range_matches from a global to static
Quoted 8 lines · Tom Rix
sparse reports
drivers/gpu/drm/vc4/vc4_drv.c:270:27: warning: symbol 'vc4_dma_range_matches' was not declared. Should it be static?
vc4_dma_range_matchesis only used invc4_drv.c, so it's storage class specifier should be static.[...]
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime