Revert "drivers/video/backlight/platform_lcd.c: add support for device tree based probe"
Subsystems (2)
PATCH 1/1 Revert "drivers/video/backlight/platform_lcd.c: add support for device tree based probe"
This reverts commit 52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2.
The DT support never would have worked because there's no platform_data providing ops. There's not any documented binding for it either.
Cc Jingoo Han <[email protected]>
Signed-off-by Rob Herring <[email protected]>
--- drivers/video/backlight/platform_lcd.c | 10 ---------- 1 file changed, 10 deletions(-)
drivers/video/backlight/platform_lcd.c +0 -10
@@ -12,7 +12,6 @@#include <linux/fb.h> #include <linux/backlight.h> #include <linux/lcd.h> -#include <linux/of.h> #include <linux/slab.h> #include <video/platform_lcd.h>
@@ -133,19 +132,10 @@ static int platform_lcd_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend, platform_lcd_resume); -#ifdef CONFIG_OF -static const struct of_device_id platform_lcd_of_match[] = { - { .compatible ="platform-lcd" }, - {}, -}; -MODULE_DEVICE_TABLE (of, platform_lcd_of_match); -#endif -static struct platform_driver platform_lcd_driver = { .driver = { .name ="platform-lcd" , .pm = &platform_lcd_pm_ops, - .of_match_table =of_match_ptr (platform_lcd_of_match), }, .probe = platform_lcd_probe, };
Signature · 1 line
2.34.1
Quoted 7 lines · Rob Herring
This reverts commit
52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2.The DT support never would have worked because there's no
platform_dataproviding ops. There's not any documented binding for it either.Cc Jingoo Han <[email protected]>Signed-off-by Rob Herring <[email protected]>
Reviewed-by Daniel Thompson <[email protected]>
Daniel.
Quoted 39 lines
--- drivers/video/backlight/platform_lcd.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/video/backlight/platform_lcd.c +0
-10@@ -12,7 +12,6 @@#include <linux/fb.h> #include <linux/backlight.h> #include <linux/lcd.h> -#include <linux/of.h> #include <linux/slab.h> #include <video/platform_lcd.h> @@ -133,19 +132,10 @@ static int platform_lcd_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend, platform_lcd_resume); -#ifdef CONFIG_OF -static const struct of_device_id platform_lcd_of_match[] = { - { .compatible ="platform-lcd" }, - {}, -}; -MODULE_DEVICE_TABLE (of, platform_lcd_of_match); -#endif -static struct platform_driver platform_lcd_driver = { .driver = { .name ="platform-lcd" , .pm = &platform_lcd_pm_ops, - .of_match_table =of_match_ptr (platform_lcd_of_match), }, .probe = platform_lcd_probe, };Signature · 1 line
2.34.1
Lee Jones
AppliedQuoted 10 lines · Rob Herring
This reverts commit
52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2.The DT support never would have worked because there's no
platform_dataproviding ops. There's not any documented binding for it either.Cc Jingoo Han <[email protected]>Signed-off-by Rob Herring <[email protected]>--- drivers/video/backlight/platform_lcd.c | 10 ---------- 1 file changed, 10 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog