PM / devfreq: tegra30: Add error message for devm_devfreq_add_device()
Subsystems (3)
PATCH 1/1 PM / devfreq: tegra30: Add error message for devm_devfreq_add_device()
It's difficult to notice that driver failed to probe by looking at KMSG when devm_devfreq_add_device() fails. Add explicit error message for this case.
Signed-off-by Dmitry Osipenko <[email protected]>
--- drivers/devfreq/tegra30-devfreq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/devfreq/tegra30-devfreq.c +3 -1
@@ -926,8 +926,10 @@ static int tegra_devfreq_probe(struct platform_device *pdev) devfreq =devm_devfreq_add_device (&pdev->dev, &tegra_devfreq_profile,"tegra_actmon" ,NULL ); -if (IS_ERR (devfreq)) +if (IS_ERR (devfreq)) { +dev_err (&pdev->dev,"Failed to add device: %pe\n" , devfreq);return PTR_ERR (devfreq); + }return 0 ; }
Signature · 1 line
2.36.1
Chanwoo Choi
AppliedQuoted 15 lines · Dmitry Osipenko
It's difficult to notice that driver failed to probe by looking at KMSG when
devm_devfreq_add_device()fails. Add explicit error message for this case.Signed-off-by Dmitry Osipenko <[email protected]>--- drivers/devfreq/tegra30-devfreq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/devfreq/tegra30-devfreq.c +0
-0@@ -926,8 +926,10 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
drivers/devfreq/tegra30-devfreq.c static int tegra_devfreq_probe(struct platform_device *pdev) · line 935
Quoted 10 lines
drivers/devfreq/tegra30-devfreq.c +3
-1devfreq =devm_devfreq_add_device (&pdev->dev, &tegra_devfreq_profile,"tegra_actmon" ,NULL ); -if (IS_ERR (devfreq)) +if (IS_ERR (devfreq)) { +dev_err (&pdev->dev,"Failed to add device: %pe\n" , devfreq);return PTR_ERR (devfreq); + }return 0 ; }
Applied it. Thanks.
Signature · 3 lines
Best Regards, Samsung Electronics Chanwoo Choi