Skip to contentSkip to conversation

kbuild: remove unused cmd_none in scripts/Makefile.modinst

PATCH In review Masahiro Yamada 2 participants 2 messages Jun 30, 2022 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: remove unused cmd_none in scripts/Makefile.modinst

Commit 65ce9c38326e ("kbuild: move module strip/compression code into scripts/Makefile.modinst") added this unused code.

Perhaps, I thought cmd_none was useful for CONFIG_MODULE_COMPRESS_NONE, but I did not use it after all.

---

 scripts/Makefile.modinst | 3 ---
 1 file changed, 3 deletions(-)
scripts/Makefile.modinst +0 -3
index c2c43a0ecfe0..16a02e9237d3 100644
@@ -28,9 +28,6 @@ modules := $(patsubst $(extmod_prefix)%, $(dst)/%$(suffix-y), $(modules))
 __modinst: $(modules)
 	@:
 
-quiet_cmd_none =
-      cmd_none = :
-
 #
 # Installation
 #
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Masahiro Yamada

Commit 65ce9c38326e ("kbuild: move module strip/compression code into scripts/Makefile.modinst") added this unused code.

Perhaps, I thought cmd_none was useful for CONFIG_MODULE_COMPRESS_NONE, but I did not use it after all.

LGTM

Quoted 24 lines

---

 scripts/Makefile.modinst | 3 ---
 1 file changed, 3 deletions(-)
scripts/Makefile.modinst +0 -4
index c2c43a0ecfe0..16a02e9237d3 100644
@@ -28,9 +28,6 @@ modules := $(patsubst $(extmod_prefix)%, $(dst)/%$(suffix-y), $(modules))
 __modinst: $(modules)
        @:
 
-quiet_cmd_none =
-      cmd_none = :
-
 #
 # Installation
 #
--

2.32.0

Signature · 2 lines
Thanks,
~Nick Desaulniers