Skip to contentSkip to conversation

staging: r8188eu: remove unneeded semicolon

PATCH In review Yang Li 4 participants 4 messages Jun 30, 2022 – Jul 4, 2022 Staging

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 staging: r8188eu: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

Signed-off-by Yang Li <[email protected]>
---
 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c +1 -1
index b5f6d41464db..5b0f66573d94 100644
@@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
 		break;
 	default:
 		return false;
-	};
+	}
 
 	do {
 		pwrcfgcmd = pwrseqcmd[aryidx];
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v1 1/1
#1 lore raw

Thus wrote Yang Li ([email protected]):

Quoted 23 lines

Eliminate the following coccicheck warning:
./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

Signed-off-by Yang Li <[email protected]>
---
 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c +1 -1
index b5f6d41464db..5b0f66573d94 100644
@@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
 		break;
 	default:
 		return false;
-	};
+	}
 
 	do {
 		pwrcfgcmd = pwrseqcmd[aryidx];
Signature · 1 line
2.20.1.7.g153144c

Thanks for spotting this.

Fixes df8d0a55047b ("staging: r8188eu: make power sequences static")
Reviewed-by Martin Kaiser <[email protected]>
#2 lore raw

Hi Martin,

Martin Kaiser <[email protected]> says:

Quoted 21 lines

Thus wrote Yang Li ([email protected]):

Quoted 18 lines

Eliminate the following coccicheck warning:
./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

Signed-off-by Yang Li <[email protected]>
---
 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c +1 -1
index b5f6d41464db..5b0f66573d94 100644
@@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
 		break;
 	default:
 		return false;
-	};
+	}
Quoted 8 lines
Quoted 4 lines
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c +0 -0
 	do {
 		pwrcfgcmd = pwrseqcmd[aryidx];
Signature · 1 line
2.20.1.7.g153144c

Thanks for spotting this.

Fixes df8d0a55047b ("staging: r8188eu: make power sequences static")

^^^^^^^^^^^^^^^^^^^^^^^^^^

No need to backport code-style warning, so Fixes: is not needed here.

Thanks,
--Pavel Skripkin

#3 lore raw
Quoted 29 lines · Pavel Skripkin

Hi Martin,

Martin Kaiser <[email protected]> says:

Quoted 26 lines

Thus wrote Yang Li ([email protected]):

Quoted 23 lines

Eliminate the following coccicheck warning:
./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

Signed-off-by Yang Li <[email protected]>
---
 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c +1 -1
index b5f6d41464db..5b0f66573d94 100644
@@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
 		break;
 	default:
 		return false;
-	};
+	}
 
 	do {
 		pwrcfgcmd = pwrseqcmd[aryidx];
Signature · 1 line
2.20.1.7.g153144c
Quoted 8 lines
Quoted 3 lines

Thanks for spotting this.

Fixes df8d0a55047b ("staging: r8188eu: make power sequences static")

^^^^^^^^^^^^^^^^^^^^^^^^^^

No need to backport code-style warning, so Fixes: is not needed here.

The Fixes tag doesn't have to do with backporting...

I do think it should only be used for bugs. So I would not have used it here. But other people do encourage it for style issues so I have given up fighting about that.

regards,
dan carpenter