Skip to contentSkip to conversation

dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

PATCH Superseded Clément Léger 3 participants 4 messages Jun 30, 2022 – Jul 1, 2022

Subsystems (5)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Clément Léger

author maintainer
#0 lore raw

PATCH v2 1/1 dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

Describe the switch interrupts (dlr, switch, prp, hub, pattern) which are connected to the GIC.

---
Changes in V2:
- Fix typo in interrupt-names property.

 .../bindings/net/dsa/renesas,rzn1-a5psw.yaml  | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +23 -0
index 103b1ef5af1b..e68c7e353100 100644
@@ -26,6 +26,22 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    items:
+      - description: DLR interrupt
+      - description: Switch interrupt
+      - description: PRP interrupt
+      - description: Integrated HUB module interrupt
+      - description: RX Pattern interrupt
+
+  interrupt-names:
+    items:
+      - const: dlr
+      - const: switch
+      - const: prp
+      - const: hub
+      - const: ptrn
+
   power-domains:
     maxItems: 1
 
@@ -76,6 +92,7 @@ examples:
   - |
     #include <dt-bindings/gpio/gpio.h>
     #include <dt-bindings/clock/r9a06g032-sysctrl.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
 
     switch@44050000 {
         compatible = "renesas,r9a06g032-a5psw", "renesas,rzn1-a5psw";
@@ -83,6 +100,12 @@ examples:
         clocks = <&sysctrl R9A06G032_HCLK_SWITCH>, <&sysctrl R9A06G032_CLK_SWITCH>;
         clock-names = "hclk", "clk";
         power-domains = <&sysctrl>;
+        interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
+        interrupt-names = "dlr", "switch", "prp", "hub", "ptrn";
 
         dsa,member = <0 0>;
 
Signature · 1 line
2.36.1
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 11 lines · Clément Léger

Describe the switch interrupts (dlr, switch, prp, hub, pattern) which are connected to the GIC.

---
Changes in V2:
- Fix typo in interrupt-names property.

 .../bindings/net/dsa/renesas,rzn1-a5psw.yaml  | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
Reviewed-by on v2 1/1
#2 lore raw
In reply to Clément Léger

Hi Clément,

Quoted 7 lines · Clément Léger

Describe the switch interrupts (dlr, switch, prp, hub, pattern) which are connected to the GIC.

---
Changes in V2:
- Fix typo in interrupt-names property.

Thanks for the update!

but some suggestions below.

Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml properties: · line 31

Quoted 9 lines
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +3 -0
@@ -26,6 +26,22 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    items:
+      - description: DLR interrupt

Device Level Ring (DLR) interrupt?

Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml properties: · line 33

Quoted 2 lines
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +2 -0
+      - description: Switch interrupt
+      - description: PRP interrupt

Parallel Redundancy Protocol (PRP) interrupt?

Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml properties: · line 35

Quoted 2 lines
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +2 -0
+      - description: Integrated HUB module interrupt
+      - description: RX Pattern interrupt

Receive Pattern Match interrupt?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author maintainer
#3 lore raw
Quoted 31 lines · Geert Uytterhoeven

Hi Clément,

Quoted 7 lines · Clément Léger

Describe the switch interrupts (dlr, switch, prp, hub, pattern) which are connected to the GIC.

---
Changes in V2:
- Fix typo in interrupt-names property.

Thanks for the update!

but some suggestions below.

Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml properties: · line 31

Quoted 9 lines
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +3 -0
@@ -26,6 +26,22 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    items:
+      - description: DLR interrupt  

Device Level Ring (DLR) interrupt?

Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml properties: · line 33

Quoted 2 lines
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +2 -0
+      - description: Switch interrupt
+      - description: PRP interrupt  
Quoted 6 lines

Parallel Redundancy Protocol (PRP) interrupt?

Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml properties: · line 35

Quoted 2 lines
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +2 -0
+      - description: Integrated HUB module interrupt
+      - description: RX Pattern interrupt  

Receive Pattern Match interrupt?

Hi Geert,

I'll modify that and send a V3, thanks for your comments !

Quoted 11 lines

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Signature · 3 lines
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com