Skip to contentSkip to conversation

virtio: VIRTIO_HARDEN_NOTIFICATION is broken

PATCH In review Michael S. Tsirkin 4 participants 4 messages Jun 30, 2022 – Jul 20, 2022 virtio core

lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

PATCH 1/1 virtio: VIRTIO_HARDEN_NOTIFICATION is broken

This option doesn't really work and breaks too many drivers. Not yet sure what's the right thing to do, for now let's make sure randconfig isn't broken by this.

Fixes c346dae4f3fb ("virtio: disable notification hardening by default")
Cc "Jason Wang" <[email protected]>
---
 drivers/virtio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/virtio/Kconfig +2 -1
index e1556d2a355a..afb9051e0125 100644
@@ -31,11 +31,12 @@ if VIRTIO_MENU
 
 config VIRTIO_HARDEN_NOTIFICATION
         bool "Harden virtio notification"
+        depends on BROKEN
         help
           Enable this to harden the device notifications and suppress
           those that happen at a time where notifications are illegal.
 
-          Experimental: Note that several drivers still have bugs that
+          Experimental: Note that several drivers still have issues that
           may cause crashes or hangs when correct handling of
           notifications is enforced; depending on the subset of
           drivers and devices you use, this may or may not work.
Signature · 6 lines
MST

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Michael S. Tsirkin

This option doesn't really work and breaks too many drivers. Not yet sure what's the right thing to do, for now let's make sure randconfig isn't broken by this.

Fixes c346dae4f3fb ("virtio: disable notification hardening by default")
Cc "Jason Wang" <[email protected]>
Quoted 25 lines
---
 drivers/virtio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/virtio/Kconfig +2 -2
index e1556d2a355a..afb9051e0125 100644
@@ -31,11 +31,12 @@ if VIRTIO_MENU
 
 config VIRTIO_HARDEN_NOTIFICATION
         bool "Harden virtio notification"
+        depends on BROKEN
         help
           Enable this to harden the device notifications and suppress
           those that happen at a time where notifications are illegal.
 
-          Experimental: Note that several drivers still have bugs that
+          Experimental: Note that several drivers still have issues that
           may cause crashes or hangs when correct handling of
           notifications is enforced; depending on the subset of
           drivers and devices you use, this may or may not work.
--

MST

Reviewed-by on v1 1/1
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 10 lines · Michael S. Tsirkin

This option doesn't really work and breaks too many drivers. Not yet sure what's the right thing to do, for now let's make sure randconfig isn't broken by this.

Fixes c346dae4f3fb ("virtio: disable notification hardening by default")
Cc "Jason Wang" <[email protected]>
---
 drivers/virtio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#3 lore raw
In reply to Michael S. Tsirkin

Hi, this is your Linux kernel regression tracker.

Quoted 16 lines · Michael S. Tsirkin

This option doesn't really work and breaks too many drivers. Not yet sure what's the right thing to do, for now let's make sure randconfig isn't broken by this.

Fixes c346dae4f3fb ("virtio: disable notification hardening by default")
Cc "Jason Wang" <[email protected]>
---
 drivers/virtio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/virtio/Kconfig +0 -0
index e1556d2a355a..afb9051e0125 100644

drivers/virtio/Kconfig if VIRTIO_MENU · line 34

Quoted 5 lines
drivers/virtio/Kconfig +1 -0
@@ -31,11 +31,12 @@ if VIRTIO_MENU
 
 config VIRTIO_HARDEN_NOTIFICATION
         bool "Harden virtio notification"
+        depends on BROKEN
[...]

Michael, just wondering: together with c346dae4f3fb this patch afaics fixes a 5.19 regression I've been tracking. It's now for 10 days in next, but not yet mainlined. Is that intentional or do you still plan to submit it in this cycle?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.