Skip to contentSkip to conversation

MAINTAINERS: adjust XDP SOCKETS after file movement

PATCH In review Lukas Bulwahn 4 participants 6 messages Jul 1, 2022 – Jul 5, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: adjust XDP SOCKETS after file movement

Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust the XDP SOCKETS (AF_XDP) section in MAINTAINERS.

Adjust the file entry after this file movement.

---
Andrii, please ack.

Alexei, please pick this minor non-urgent clean-up on top of the commit above.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index fa4bfa3d10bf..27d9e65b9a85 100644
@@ -22042,7 +22042,7 @@ F:	include/uapi/linux/xdp_diag.h
 F:	include/net/netns/xdp.h
 F:	net/xdp/
 F:	samples/bpf/xdpsock*
-F:	tools/lib/bpf/xsk*
+F:	tools/testing/selftests/bpf/xsk*
 
 XEN BLOCK SUBSYSTEM
 M:	Roger Pau Monné <[email protected]>
Signature · 1 line
2.17.1
#1 lore raw
Quoted 20 lines · Lukas Bulwahn

Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust the XDP SOCKETS (AF_XDP) section in MAINTAINERS.

Adjust the file entry after this file movement.

---
Andrii, please ack.

Alexei, please pick this minor non-urgent clean-up on top of the commit above.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index fa4bfa3d10bf..27d9e65b9a85 100644

MAINTAINERS F: include/uapi/linux/xdp_diag.h · line 22045

Quoted 5 lines
MAINTAINERS +1 -1
@@ -22042,7 +22042,7 @@ F:	include/uapi/linux/xdp_diag.h
 F:	include/net/netns/xdp.h
 F:	net/xdp/
 F:	samples/bpf/xdpsock*
-F:	tools/lib/bpf/xsk*
+F:	tools/testing/selftests/bpf/xsk*

Magnus, this doesn't cover xdpxceiver.
How about we move the lib part and xdpxceiver part to a dedicated directory? Or would it be too nested from main dir POV?

Quoted 6 lines
MAINTAINERS +0 -0
 XEN BLOCK SUBSYSTEM
 M:	Roger Pau Monné <[email protected]>
Signature · 1 line
2.17.1
#2 lore raw
Quoted 17 lines · Maciej Fijalkowski
Quoted 15 lines · Lukas Bulwahn

Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust the XDP SOCKETS (AF_XDP) section in MAINTAINERS.

Adjust the file entry after this file movement.

---
Andrii, please ack.

Alexei, please pick this minor non-urgent clean-up on top of the commit above.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines

MAINTAINERS F: include/uapi/linux/xdp_diag.h · line 22045

Quoted 10 lines
MAINTAINERS +1 -1
index fa4bfa3d10bf..27d9e65b9a85 100644
@@ -22042,7 +22042,7 @@ F:    include/uapi/linux/xdp_diag.h
 F:   include/net/netns/xdp.h
 F:   net/xdp/
 F:   samples/bpf/xdpsock*
-F:   tools/lib/bpf/xsk*
+F:   tools/testing/selftests/bpf/xsk*

Magnus, this doesn't cover xdpxceiver.
How about we move the lib part and xdpxceiver part to a dedicated directory? Or would it be too nested from main dir POV?

Or we can just call everything we add xsk* something?

Quoted 6 lines
Quoted 6 lines
MAINTAINERS +0 -1
 XEN BLOCK SUBSYSTEM
 M:   Roger Pau Monné <[email protected]>
--

2.17.1

#3 lore raw
Quoted 34 lines · Magnus Karlsson
Quoted 17 lines · Maciej Fijalkowski
Quoted 15 lines · Lukas Bulwahn

Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust the XDP SOCKETS (AF_XDP) section in MAINTAINERS.

Adjust the file entry after this file movement.

---
Andrii, please ack.

Alexei, please pick this minor non-urgent clean-up on top of the commit above.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines

MAINTAINERS F: include/uapi/linux/xdp_diag.h · line 22045

Quoted 10 lines
MAINTAINERS +1 -1
index fa4bfa3d10bf..27d9e65b9a85 100644
@@ -22042,7 +22042,7 @@ F:    include/uapi/linux/xdp_diag.h
 F:   include/net/netns/xdp.h
 F:   net/xdp/
 F:   samples/bpf/xdpsock*
-F:   tools/lib/bpf/xsk*
+F:   tools/testing/selftests/bpf/xsk*

Magnus, this doesn't cover xdpxceiver.
How about we move the lib part and xdpxceiver part to a dedicated directory? Or would it be too nested from main dir POV?

Quoted 1 line

Or we can just call everything we add xsk* something?

No strong feelings. test_xsk.sh probably also needs to be addressed. That's why I proposed dedicated dir.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
MAINTAINERS +0 -1
 XEN BLOCK SUBSYSTEM
 M:   Roger Pau Monné <[email protected]>
--

2.17.1

maintainer
#4 lore raw
Quoted 35 lines · Maciej Fijalkowski
Quoted 34 lines · Magnus Karlsson
Quoted 31 lines · Maciej Fijalkowski
Quoted 20 lines · Lukas Bulwahn

Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust the XDP SOCKETS (AF_XDP) section in MAINTAINERS.

Adjust the file entry after this file movement.

---
Andrii, please ack.

Alexei, please pick this minor non-urgent clean-up on top of the commit above.

  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index fa4bfa3d10bf..27d9e65b9a85 100644

MAINTAINERS F: include/uapi/linux/xdp_diag.h · line 22045

Quoted 5 lines
MAINTAINERS +1 -1
@@ -22042,7 +22042,7 @@ F:    include/uapi/linux/xdp_diag.h
  F:   include/net/netns/xdp.h
  F:   net/xdp/
  F:   samples/bpf/xdpsock*
-F:   tools/lib/bpf/xsk*
+F:   tools/testing/selftests/bpf/xsk*

Magnus, this doesn't cover xdpxceiver.
How about we move the lib part and xdpxceiver part to a dedicated directory? Or would it be too nested from main dir POV?

Quoted 4 lines
Quoted 1 line

Or we can just call everything we add xsk* something?

No strong feelings. test_xsk.sh probably also needs to be addressed. That's why I proposed dedicated dir.

Could one of you follow-up on this for bpf-next tree? Maybe for selftests something similar as in case of the XDP entry could work.

Thanks,
Daniel

#5 lore raw
Quoted 36 lines · Daniel Borkmann
Quoted 35 lines · Maciej Fijalkowski
Quoted 34 lines · Magnus Karlsson
Quoted 31 lines · Maciej Fijalkowski
Quoted 20 lines · Lukas Bulwahn

Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust the XDP SOCKETS (AF_XDP) section in MAINTAINERS.

Adjust the file entry after this file movement.

---
Andrii, please ack.

Alexei, please pick this minor non-urgent clean-up on top of the commit above.

  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index fa4bfa3d10bf..27d9e65b9a85 100644

MAINTAINERS F: include/uapi/linux/xdp_diag.h · line 22045

Quoted 5 lines
MAINTAINERS +1 -1
@@ -22042,7 +22042,7 @@ F:    include/uapi/linux/xdp_diag.h
  F:   include/net/netns/xdp.h
  F:   net/xdp/
  F:   samples/bpf/xdpsock*
-F:   tools/lib/bpf/xsk*
+F:   tools/testing/selftests/bpf/xsk*

Magnus, this doesn't cover xdpxceiver.
How about we move the lib part and xdpxceiver part to a dedicated directory? Or would it be too nested from main dir POV?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Or we can just call everything we add xsk* something?

No strong feelings. test_xsk.sh probably also needs to be addressed. That's why I proposed dedicated dir.

Could one of you follow-up on this for bpf-next tree? Maybe for selftests something similar as in case of the XDP entry could work.

Yes, sorry. Let's do:

F: tools/testing/selftests/bpf/*xsk*

then s/xdpxceiver/xskxceiver. I can send a follow-up and add Lukas as a reporter.

Sounds good?

Quoted 3 lines

Thanks,
Daniel