Skip to contentSkip to conversation

iio: adc: ti-adc128s052: Add support for adc102s021 and family

PATCH In review Nishanth Menon 3 participants 7 messages Jul 1, 2022 – Jul 6, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover iio: adc: ti-adc128s052: Add support for adc102s021 and family

Hi,

This is probably a continuation of [1] and has a dependency on [2].

Inspiration for this series is drivers/hwmon/adcxx.c though constrained to the family that I had access to test with.

As stated in drivers/hwmon/adcxx.c, the family of devices are easier to support since they all (no matter the resolution) seem to respond in 12 bits with the LSBs set to 0 for the reduced resolution devices.

Note: This series does'nt attempt to cleanup the sparse and extended build warnings existing in the driver.

Series based on [2] and next-20220630

Nishanth Menon (2):
dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family
iio: adc: ti-adc128s052: Add lower resolution devices support

 .../bindings/iio/adc/ti,adc128s052.yaml       |  6 +++++
 drivers/iio/adc/ti-adc128s052.c               | 26 +++++++++++++++++++
 2 files changed, 32 insertions(+)

[1] https://patchwork.kernel.org/project/linux-hwmon/patch/[email protected]/
[2] https://lore.kernel.org/linux-iio/[email protected]/

Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/2 dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family

The adcxx4s communicates with a host processor via an SPI/Microwire Bus interface. The device family responds with 12bit data, of which the LSB bits are 0 for the lower resolution devices. I have been able to test adc102s051, hence adding just the missing ones in that family.

Lets reuse the binding to support the family of devices with name ADC<bb><c>S<sss>, where
* bb is the resolution in number of bits (8, 10, 12)
* c is the number of channels (1, 2, 4, 8)
* sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS and 101 for 1 MSPS)

Complete datasheets are available at TI's website here:
https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf

Handling of 8, 10 and 12 bits converters are the same, the unavailable bits are 0 in LSB :)

Inspired-by: drivers/hwmon/adcxx.c

---

Checkpatch does complain with Inspired-by: insisting it to be an email address.. but I was really inspired by the hwmon driver.. Don't know what else to say here.. we could probably drop it?

 .../devicetree/bindings/iio/adc/ti,adc128s052.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml +6 -0
index d54a0183f024..85adf53c83c1 100644
@@ -16,6 +16,12 @@ description: |
 properties:
   compatible:
     enum:
+      - ti,adc082s021
+      - ti,adc082s051
+      - ti,adc082s101
+      - ti,adc102s021
+      - ti,adc102s051
+      - ti,adc102s101
       - ti,adc122s021
       - ti,adc122s051
       - ti,adc122s101
Signature · 1 line
2.31.1
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family

Quoted 18 lines · Nishanth Menon

The adcxx4s communicates with a host processor via an SPI/Microwire Bus interface. The device family responds with 12bit data, of which the LSB bits are 0 for the lower resolution devices. I have been able to test adc102s051, hence adding just the missing ones in that family.

Lets reuse the binding to support the family of devices with name ADC<bb><c>S<sss>, where
* bb is the resolution in number of bits (8, 10, 12)
* c is the number of channels (1, 2, 4, 8)
* sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS and 101 for 1 MSPS)

Complete datasheets are available at TI's website here:
https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf

Handling of 8, 10 and 12 bits converters are the same, the unavailable bits are 0 in LSB :)

Quoted 8 lines

Inspired-by: drivers/hwmon/adcxx.c

---

Checkpatch does complain with Inspired-by: insisting it to be an email address.. but I was really inspired by the hwmon driver.. Don't know what else to say here.. we could probably drop it?

Drop it or convert to just test.

When passing checkpatch:

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH 1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family

Quoted 21 lines · Krzysztof Kozlowski
Quoted 20 lines · Nishanth Menon

The adcxx4s communicates with a host processor via an SPI/Microwire Bus interface. The device family responds with 12bit data, of which the LSB bits are 0 for the lower resolution devices. I have been able to test adc102s051, hence adding just the missing ones in that family.

Lets reuse the binding to support the family of devices with name ADC<bb><c>S<sss>, where
* bb is the resolution in number of bits (8, 10, 12)
* c is the number of channels (1, 2, 4, 8)
* sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS and 101 for 1 MSPS)

Complete datasheets are available at TI's website here:
https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf

Handling of 8, 10 and 12 bits converters are the same, the unavailable bits are 0 in LSB :)

Inspired-by: drivers/hwmon/adcxx.c

Quoted 8 lines
Quoted 6 lines

---

Checkpatch does complain with Inspired-by: insisting it to be an email address.. but I was really inspired by the hwmon driver.. Don't know what else to say here.. we could probably drop it?

Drop it or convert to just test.

This should be:

Drop it or convert to just text sentence.

Best regards,
Krzysztof

#4 lore raw

PATCH 2/2 iio: adc: ti-adc128s052: Add lower resolution devices support

In reply to Nishanth Menon

The adcxx4s communicates with a host processor via an SPI/Microwire Bus interface. The device family responds with 12bit data, of which the LSB bits are transmitted by the lower resolution devices as 0. We don't need to mess with ADC108S102_BITS as a result for the lower resolution devices.

I have been able to test adc102s051, hence adding just the missing ones in that family.

Lets reuse the driver to support the family of devices with name ADC<bb><c>S<sss>, where
* bb is the resolution in number of bits (8, 10, 12)
* c is the number of channels (1, 2, 4, 8)
* sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS and 101 for 1 MSPS)

Complete datasheets are available at TI's website here:
https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf

Also see: drivers/hwmon/adcxx.c

---

This does add on additional sparse warnings around casting .data value to const from int for the of_match_table, and a bunch around the .cls field for acpi_device_id - maybe someone could suggest a smarter way to fix those.

Applies after https://lore.kernel.org/linux-iio/[email protected]/

 drivers/iio/adc/ti-adc128s052.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
drivers/iio/adc/ti-adc128s052.c +26 -0
index 21a7764cbb93..0a3aab4df60e 100644
@@ -7,6 +7,20 @@
  * https://www.ti.com/lit/ds/symlink/adc128s052.pdf
  * https://www.ti.com/lit/ds/symlink/adc122s021.pdf
  * https://www.ti.com/lit/ds/symlink/adc124s021.pdf
+ *
+ * The adcxx4s communicates with a host processor via an SPI/Microwire Bus
+ * interface. This driver supports the whole family of devices with name
+ * ADC<bb><c>S<sss>, where
+ * bb is the resolution in number of bits (8, 10, 12)
+ * c is the number of channels (1, 2, 4, 8)
+ * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
+ * and 101 for 1 MSPS)
+ *
+ * Complete datasheets are available at TI's website here:
+ *   https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf
+ *
+ * Handling of 8, 10 and 12 bits converters are the same, the
+ * unavailable bits are 0 in LSB :)
  */
 
 #include <linux/acpi.h>
@@ -185,6 +199,12 @@ static const struct of_device_id adc128_of_match[] = {
 	{ .compatible = "ti,adc122s021", .data = 1},
 	{ .compatible = "ti,adc122s051", .data = 1},
 	{ .compatible = "ti,adc122s101", .data = 1},
+	{ .compatible = "ti,adc102s021", .data = 1},
+	{ .compatible = "ti,adc102s051", .data = 1},
+	{ .compatible = "ti,adc102s101", .data = 1},
+	{ .compatible = "ti,adc082s021", .data = 1},
+	{ .compatible = "ti,adc082s051", .data = 1},
+	{ .compatible = "ti,adc082s101", .data = 1},
 	{ .compatible = "ti,adc124s021", .data = 2},
 	{ .compatible = "ti,adc124s051", .data = 2},
 	{ .compatible = "ti,adc124s101", .data = 2},
@@ -197,6 +217,12 @@ static const struct spi_device_id adc128_id[] = {
 	{ "adc122s021",	1 },
 	{ "adc122s051",	1 },
 	{ "adc122s101",	1 },
+	{ "adc102s021",	1 },
+	{ "adc102s051",	1 },
+	{ "adc102s101",	1 },
+	{ "adc082s021",	1 },
+	{ "adc082s051",	1 },
+	{ "adc082s101",	1 },
 	{ "adc124s021", 2 },
 	{ "adc124s051", 2 },
 	{ "adc124s101", 2 },
Signature · 1 line
2.31.1
maintainer
#5 lore raw

Re: [PATCH 2/2] iio: adc: ti-adc128s052: Add lower resolution devices support

Quoted 5 lines · On Thu, 30 Jun 2022 23:29:19 -0500 Nishanth Menon <[email protected]> wrote:

The adcxx4s communicates with a host processor via an SPI/Microwire Bus interface. The device family responds with 12bit data, of which the LSB bits are transmitted by the lower resolution devices as 0. We don't need to mess with ADC108S102_BITS as a result for the lower resolution devices.

whilst not strictly necessary I would prefer we did as it may reduce storage requirements, computation complexity etc for userspace (particularly if they are 8 bits).

Would affect scale and shift so slightly more complex, but not a lot so still a fairly simple change. Just add resolution to your config structure and duplicate it where necessary to allow whatever resolutions we support.

Quoted 55 lines

I have been able to test adc102s051, hence adding just the missing ones in that family.

Lets reuse the driver to support the family of devices with name ADC<bb><c>S<sss>, where
* bb is the resolution in number of bits (8, 10, 12)
* c is the number of channels (1, 2, 4, 8)
* sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS and 101 for 1 MSPS)

Complete datasheets are available at TI's website here:
https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf

Also see: drivers/hwmon/adcxx.c

---

This does add on additional sparse warnings around casting .data value to const from int for the of_match_table, and a bunch around the .cls field for acpi_device_id - maybe someone could suggest a smarter way to fix those.

Applies after https://lore.kernel.org/linux-iio/[email protected]/

 drivers/iio/adc/ti-adc128s052.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
drivers/iio/adc/ti-adc128s052.c +14 -0
index 21a7764cbb93..0a3aab4df60e 100644
@@ -7,6 +7,20 @@
  * https://www.ti.com/lit/ds/symlink/adc128s052.pdf
  * https://www.ti.com/lit/ds/symlink/adc122s021.pdf
  * https://www.ti.com/lit/ds/symlink/adc124s021.pdf
+ *
+ * The adcxx4s communicates with a host processor via an SPI/Microwire Bus
+ * interface. This driver supports the whole family of devices with name
+ * ADC<bb><c>S<sss>, where
+ * bb is the resolution in number of bits (8, 10, 12)
+ * c is the number of channels (1, 2, 4, 8)
+ * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
+ * and 101 for 1 MSPS)
+ *
+ * Complete datasheets are available at TI's website here:
+ *   https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf
+ *
+ * Handling of 8, 10 and 12 bits converters are the same, the
+ * unavailable bits are 0 in LSB :)
  */
 
 #include <linux/acpi.h>

drivers/iio/adc/ti-adc128s052.c static const struct of_device_id adc128_of_match[] = { · line 204

Quoted 6 lines
drivers/iio/adc/ti-adc128s052.c +3 -0
@@ -185,6 +199,12 @@ static const struct of_device_id adc128_of_match[] = {
 	{ .compatible = "ti,adc122s021", .data = 1},
 	{ .compatible = "ti,adc122s051", .data = 1},
 	{ .compatible = "ti,adc122s101", .data = 1},
+	{ .compatible = "ti,adc102s021", .data = 1},
+	{ .compatible = "ti,adc102s051", .data = 1},
+	{ .compatible = "ti,adc102s101", .data = 1},

Numeric order preferred. Not sure why these are in the middle.

drivers/iio/adc/ti-adc128s052.c static const struct of_device_id adc128_of_match[] = { · line 207

Quoted 3 lines
drivers/iio/adc/ti-adc128s052.c +3 -0
+	{ .compatible = "ti,adc082s021", .data = 1},
+	{ .compatible = "ti,adc082s051", .data = 1},
+	{ .compatible = "ti,adc082s101", .data = 1},

Andy's comment on using pointers instead follows through to here. To describe the channels more fully you'll need additional _config[] structures.

Quoted 16 lines
drivers/iio/adc/ti-adc128s052.c +6 -0
 	{ .compatible = "ti,adc124s021", .data = 2},
 	{ .compatible = "ti,adc124s051", .data = 2},
 	{ .compatible = "ti,adc124s101", .data = 2},
@@ -197,6 +217,12 @@ static const struct spi_device_id adc128_id[] = {
 	{ "adc122s021",	1 },
 	{ "adc122s051",	1 },
 	{ "adc122s101",	1 },
+	{ "adc102s021",	1 },
+	{ "adc102s051",	1 },
+	{ "adc102s101",	1 },
+	{ "adc082s021",	1 },
+	{ "adc082s051",	1 },
+	{ "adc082s101",	1 },
 	{ "adc124s021", 2 },
 	{ "adc124s051", 2 },
 	{ "adc124s101", 2 },
#6 lore raw

Re: [PATCH 2/2] iio: adc: ti-adc128s052: Add lower resolution devices support

Quoted 19 lines · Jonathan Cameron
Quoted 5 lines · On Thu, 30 Jun 2022 23:29:19 -0500 Nishanth Menon <[email protected]> wrote:

The adcxx4s communicates with a host processor via an SPI/Microwire Bus interface. The device family responds with 12bit data, of which the LSB bits are transmitted by the lower resolution devices as 0. We don't need to mess with ADC108S102_BITS as a result for the lower resolution devices.

whilst not strictly necessary I would prefer we did as it may reduce storage requirements, computation complexity etc for userspace (particularly if they are 8 bits).

Would affect scale and shift so slightly more complex, but not a lot so still a fairly simple change. Just add resolution to your config structure and duplicate it where necessary to allow whatever resolutions we support.

Quoted 1 line

[...]

Quoted 11 lines

drivers/iio/adc/ti-adc128s052.c static const struct of_device_id adc128_of_match[] = { · line 204

Quoted 8 lines

#include <linux/acpi.h>

drivers/iio/adc/ti-adc128s052.c +3 -0
@@ -185,6 +199,12 @@ static const struct of_device_id adc128_of_match[] = {
 	{ .compatible = "ti,adc122s021", .data = 1},
 	{ .compatible = "ti,adc122s051", .data = 1},
 	{ .compatible = "ti,adc122s101", .data = 1},
+	{ .compatible = "ti,adc102s021", .data = 1},
+	{ .compatible = "ti,adc102s051", .data = 1},
+	{ .compatible = "ti,adc102s101", .data = 1},

Numeric order preferred. Not sure why these are in the middle.

Quoted 7 lines

drivers/iio/adc/ti-adc128s052.c static const struct of_device_id adc128_of_match[] = { · line 207

Quoted 3 lines
drivers/iio/adc/ti-adc128s052.c +3 -0
+	{ .compatible = "ti,adc082s021", .data = 1},
+	{ .compatible = "ti,adc082s051", .data = 1},
+	{ .compatible = "ti,adc082s101", .data = 1},

Andy's comment on using pointers instead follows through to here. To describe the channels more fully you'll need additional _config[] structures.

Thanks folks for the feedback. Will try to do a better job on the next rev.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D