HID: core: remove unneeded assignment in hid_process_report()
Subsystems (2)
PATCH 1/1 HID: core: remove unneeded assignment in hid_process_report()
Commit bebcc522fbee ("HID: core: for input reports, process the usages by priority list") split the iteration into two distinct loops in hid_process_report().
After this change, the variable field is only used while iterating in the second loop and the assignment of values to this variable in the first loop is simply not needed.
Remove the unneeded assignment during retrieval. No functional change and no change in the resulting object code.
This was discovered as a dead store with clang-analyzer.
---
Benjamin, Jiri, please pick this minor non-urgent clean-up patch.
drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-core.c +1 -1
@@ -1662,7 +1662,7 @@ static void hid_process_report(struct hid_device *hid,/* first retrieve all incoming values in data */ for (a =0 ; a < report->maxfield; a++) -hid_input_fetch_field (hid, field = report->field[a], data); +hid_input_fetch_field (hid, report->field[a], data);if (!list_empty (&report->field_entry_list)) {/* INPUT_REPORT, we have a priority list of fields */
Signature · 1 line
2.17.1
Quoted 25 lines · Lukas Bulwahn
Commit
bebcc522fbee("HID: core: for input reports, process the usages by priority list") split the iteration into two distinct loops inhid_process_report().After this change, the variable field is only used while iterating in the second loop and the assignment of values to this variable in the first loop is simply not needed.
Remove the unneeded assignment during retrieval. No functional change and no change in the resulting object code.
This was discovered as a dead store with clang-analyzer.
Signed-off-by Lukas Bulwahn <[email protected]>---
Benjamin, Jiri, please pick this minor non-urgent clean-up patch.drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hid/hid-core.c +0
-0
drivers/hid/hid-core.c static void hid_process_report(struct hid_device *hid, · line 1668
Quoted 8 lines
drivers/hid/hid-core.c +1
-1@@ -1662,7 +1662,7 @@ static void hid_process_report(struct hid_device *hid,/* first retrieve all incoming values in data */ for (a =0 ; a < report->maxfield; a++) -hid_input_fetch_field (hid, field = report->field[a], data); +hid_input_fetch_field (hid, report->field[a], data);if (!list_empty (&report->field_entry_list)) {/* INPUT_REPORT, we have a priority list of fields */
Quoted 25 lines · Lukas Bulwahn
Commit
bebcc522fbee("HID: core: for input reports, process the usages by priority list") split the iteration into two distinct loops inhid_process_report().After this change, the variable field is only used while iterating in the second loop and the assignment of values to this variable in the first loop is simply not needed.
Remove the unneeded assignment during retrieval. No functional change and no change in the resulting object code.
This was discovered as a dead store with clang-analyzer.
Signed-off-by Lukas Bulwahn <[email protected]>---
Benjamin, Jiri, please pick this minor non-urgent clean-up patch.drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hid/hid-core.c +0
-0
drivers/hid/hid-core.c static void hid_process_report(struct hid_device *hid, · line 1667
Quoted 7 lines
drivers/hid/hid-core.c +1
-1@@ -1662,7 +1662,7 @@ static void hid_process_report(struct hid_device *hid,/* first retrieve all incoming values in data */ for (a =0 ; a < report->maxfield; a++) -hid_input_fetch_field (hid, field = report->field[a], data); +hid_input_fetch_field (hid, report->field[a], data);if (!list_empty (&report->field_entry_list)) {
Applied, thanks Lukas.
Signature · 2 lines
Jiri Kosina SUSE Labs