Skip to contentSkip to conversation

powerpc: 85xx: Fix refcount bugs in ge_imp3a_pci_assign_primary()

PATCH Applied Liang He 2 participants 2 messages Jul 1, 2022 – Sep 9, 2022

Subsystems (2)
lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH 1/1 powerpc: 85xx: Fix refcount bugs in ge_imp3a_pci_assign_primary()

for_each_node_by_type() will automatically increase and decrease the refcount during the iteration. However, there is a reference escaped into global 'fsl_pci_primary' and we need to handle it.

---
 arch/powerpc/platforms/85xx/ge_imp3a.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
arch/powerpc/platforms/85xx/ge_imp3a.c +4 -2
index 8e827376d97b..e3e8f18825a1 100644
@@ -89,8 +89,10 @@ static void __init ge_imp3a_pci_assign_primary(void)
 		    of_device_is_compatible(np, "fsl,mpc8548-pcie") ||
 		    of_device_is_compatible(np, "fsl,p2020-pcie")) {
 			of_address_to_resource(np, 0, &rsrc);
-			if ((rsrc.start & 0xfffff) == 0x9000)
-				fsl_pci_primary = np;
+			if ((rsrc.start & 0xfffff) == 0x9000) {
+				of_node_put(fsl_pci_primary);
+				fsl_pci_primary = of_node_get(np);
+			}
 		}
 	}
 #endif
Signature · 1 line
2.25.1