Skip to contentSkip to conversation

perf test: Add ARM SPE system wide test

PATCH Applied Namhyung Kim 4 participants 4 messages Jul 1, 2022 – Aug 1, 2022 perf events

lore
Share & tools
lore

Namhyung Kim

author maintainer
#0 lore raw

PATCH v3 1/1 perf test: Add ARM SPE system wide test

In the past it had a problem not setting the pid/tid on the sample correctly when system-wide mode is used. Although it's fixed now it'd be nice if we have a test case for it.

---
* skip if system-wide record was failed
* use dummy event for testing

 tools/perf/tests/shell/test_arm_spe.sh | 30 +++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)
tools/perf/tests/shell/test_arm_spe.sh +27 -3
index e59044edc406..0d47479adba8 100755
@@ -23,17 +23,20 @@ glb_err=0
 cleanup_files()
 {
 	rm -f ${perfdata}
+	rm -f ${perfdata}.old
 	exit $glb_err
 }
 
 trap cleanup_files exit term int
 
 arm_spe_report() {
-	if [ $2 != 0 ]; then
+	if [ $2 = 0 ]; then
+		echo "$1: PASS"
+	elif [ $2 = 2 ]; then
+		echo "$1: SKIPPED"
+	else
 		echo "$1: FAIL"
 		glb_err=$2
-	else
-		echo "$1: PASS"
 	fi
 }
 
@@ -85,5 +88,26 @@ arm_spe_snapshot_test() {
 	arm_spe_report "SPE snapshot testing" $err
 }
 
+arm_spe_system_wide_test() {
+	echo "Recording trace with system-wide mode $perfdata"
+
+	perf record -o - -e dummy -a -B true > /dev/null 2>&1
+	if [ $? != 0 ]; then
+		arm_spe_report "SPE system-wide testing" 2
+		return
+	fi
+
+	perf record -o ${perfdata} -e arm_spe// -a --no-bpf-event \
+		-- dd if=/dev/zero of=/dev/null count=100000 > /dev/null 2>&1
+
+	perf_script_samples dd &&
+	perf_report_samples dd
+
+	err=$?
+	arm_spe_report "SPE system-wide testing" $err
+}
+
 arm_spe_snapshot_test
+arm_spe_system_wide_test
+
 exit $glb_err
Signature · 1 line
2.37.0.rc0.161.g10f37bed90-goog
Reviewed-by on v3 1/1
#1 lore raw
Quoted 7 lines · Namhyung Kim

In the past it had a problem not setting the pid/tid on the sample correctly when system-wide mode is used. Although it's fixed now it'd be nice if we have a test case for it.

Quoted 3 lines

---
* skip if system-wide record was failed
* use dummy event for testing

Thanks,
German

Tested-by on v3 1/1
#2 lore raw
In reply to Namhyung Kim
Quoted 7 lines · Namhyung Kim

In the past it had a problem not setting the pid/tid on the sample correctly when system-wide mode is used. Although it's fixed now it'd be nice if we have a test case for it.

Tested for both root user and non-privileged user, both works as expected:

maintainer Applied
#3 lore raw

Em Thu, Jul 07, 2022 at 11:13:52AM +0800, Leo Yan escreveu:

Quoted 5 lines · Namhyung Kim
Quoted 4 lines

In the past it had a problem not setting the pid/tid on the sample correctly when system-wide mode is used. Although it's fixed now it'd be nice if we have a test case for it.

Quoted 8 lines
Quoted 3 lines

Tested for both root user and non-privileged user, both works as expected:

Thanks, applied.

- Arnaldo