Skip to contentSkip to conversation

iio: magnetometer: rm3100: do not explicity set INDIO_BUFFER_TRIGGERED mode

PATCH In review Marcus Folkesson 2 participants 2 messages Jul 2, 2022 – Jul 16, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: magnetometer: rm3100: do not explicity set INDIO_BUFFER_TRIGGERED mode

The core sets INDIO_BUFFER_TRIGGERED as part of
devm_iio_triggered_buffer_setup().

---
 drivers/iio/magnetometer/rm3100-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/magnetometer/rm3100-core.c +1 -1
index 26195733ea3e..060914c63969 100644
@@ -552,7 +552,7 @@ int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq)
 	indio_dev->info = &rm3100_info;
 	indio_dev->channels = rm3100_channels;
 	indio_dev->num_channels = ARRAY_SIZE(rm3100_channels);
-	indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
+	indio_dev->modes = INDIO_DIRECT_MODE;
 	indio_dev->currentmode = INDIO_DIRECT_MODE;
 
 	if (!irq)
Signature · 1 line
2.36.1
maintainer
#1 lore raw
Quoted 4 lines · On Sat, 2 Jul 2022 10:50:05 +0200 Marcus Folkesson…

The core sets INDIO_BUFFER_TRIGGERED as part of
devm_iio_triggered_buffer_setup().

You seem to be on a fairly old tree.

Anyhow, the issue is still there, so I dealt with the fuzz.

Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it. Not I'll be rebasing on rc1 once available.

Thanks,

Jonathan

Quoted 17 lines
---
 drivers/iio/magnetometer/rm3100-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/magnetometer/rm3100-core.c +1 -1
index 26195733ea3e..060914c63969 100644
@@ -552,7 +552,7 @@ int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq)
 	indio_dev->info = &rm3100_info;
 	indio_dev->channels = rm3100_channels;
 	indio_dev->num_channels = ARRAY_SIZE(rm3100_channels);
-	indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
+	indio_dev->modes = INDIO_DIRECT_MODE;
 	indio_dev->currentmode = INDIO_DIRECT_MODE;
 
 	if (!irq)