dt-bindings: nvmem: u-boot,env: add basic NVMEM cells
Subsystems (2)
PATCH 1/1 dt-bindings: nvmem: u-boot,env: add basic NVMEM cells
From: Rafał Miłecki <[email protected]>
U-Boot doesn't have cells at hardcoded addresses. They are stored in internal format. It's still important to define relevant cells in DT so NVMEM consumers can reference them.
Update binding to allow including basic cells as NVMEM device subnodes.
--- .../devicetree/bindings/nvmem/u-boot,env.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Documentation/devicetree/bindings/nvmem/u-boot,env.yaml +13 -0
@@ -24,6 +24,8 @@ description: | Right now only flash partition case is covered but it may be extended to e.g. UBI volumes in the future. + Variables can be defined as NVMEM device subnodes. + maintainers: - Rafał Miłecki <[email protected]>
@@ -40,6 +42,14 @@ properties: reg: maxItems: 1 + bootcmd: + type: object + description: Command to use for automatic booting + + ethaddr: + type: object + description: Ethernet interface's MAC address + additionalProperties: false examples:
@@ -58,5 +68,8 @@ examples: env: partition@40000 { compatible = "u-boot,env"; reg = <0x40000 0x10000>; + + mac: ethaddr { + }; }; };
Signature · 1 line
2.34.1
Quoted 5 lines · Rafał Miłecki
U-Boot doesn't have cells at hardcoded addresses. They are stored in internal format. It's still important to define relevant cells in DT so NVMEM consumers can reference them.
Update binding to allow including basic cells as NVMEM device subnodes.
Ping :)
For a reference you can see Broadcom's NVRAM (identical feature):
084973e944bec ("dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=084973e944bec21804f8afb0515b25434438699a
c8442f0fb09ca ("ARM: dts: BCM5301X: Add Ethernet MAC address to Luxul XWR-3150")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c8442f0fb09ca3d842b9b23d1d0650f649fd10f8
Tom Rini
Reviewed-byQuoted 10 lines · Rafał Miłecki
Quoted 5 lines · Rafał Miłecki
U-Boot doesn't have cells at hardcoded addresses. They are stored in internal format. It's still important to define relevant cells in DT so NVMEM consumers can reference them.
Update binding to allow including basic cells as NVMEM device subnodes.
Ping :)
Quoted 7 lines
For a reference you can see Broadcom's NVRAM (identical feature):
084973e944bec("dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=084973e944bec21804f8afb0515b25434438699a
c8442f0fb09ca("ARM: dts: BCM5301X: Add Ethernet MAC address to Luxul XWR-3150")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c8442f0fb09ca3d842b9b23d1d0650f649fd10f8
Seems fine to me.
Signature · 1 line
Tom
Quoted 6 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
U-Boot doesn't have cells at hardcoded addresses. They are stored in internal format. It's still important to define relevant cells in DT so NVMEM consumers can reference them.
Quoted 7 lines
Update binding to allow including basic cells as NVMEM device subnodes.
Signed-off-by Rafał Miłecki <[email protected]>--- .../devicetree/bindings/nvmem/u-boot,env.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Sorry, I guess I was thinking this depended on or interacted with one of the other nvmem series.
Applied, thanks!
Rob