Skip to contentSkip to conversation

mm-damon-use-set_huge_pte_at-to-make-huge-pte-old.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Jul 3, 2022 Stable branch

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/damon: use set_huge_pte_at() to make huge pte old
has been removed from the -mm tree. Its filename was
mm-damon-use-set_huge_pte_at-to-make-huge-pte-old.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Baolin Wang <[email protected]>
Subject: mm/damon: use set_huge_pte_at() to make huge pte old
Date: Mon, 20 Jun 2022 10:34:42 +0800

The huge_ptep_set_access_flags() can not make the huge pte old according to the discussion [1], that means we will always mornitor the young state of the hugetlb though we stopped accessing the hugetlb, as a result DAMON will get inaccurate accessing statistics.

So changing to use set_huge_pte_at() to make the huge pte old to fix this issue.

[1] https://lore.kernel.org/all/[email protected]/

---

 mm/damon/vaddr.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/damon/vaddr.c renamed from mm/damon/vaddr.c~mm-damon-use-set_huge_pte_at-to-make-huge-pte-old +1 -2
@@ -336,8 +336,7 @@ static void damon_hugetlb_mkold(pte_t *p
 	if (pte_young(entry)) {
 		referenced = true;
 		entry = pte_mkold(entry);
-		huge_ptep_set_access_flags(vma, addr, pte, entry,
-					   vma->vm_flags & VM_WRITE);
+		set_huge_pte_at(mm, addr, pte, entry);
 	}
 
 #ifdef CONFIG_MMU_NOTIFIER

_

Patches currently in -mm which might be from [email protected] are

mm-hugetlb-remove-unnecessary-huge_ptep_set_access_flags-in-hugetlb_mcopy_atomic_pte.patch mm-rmap-simplify-the-hugetlb-handling-when-unmapping-or-migration.patch arm64-hugetlb-implement-arm64-specific-hugetlb_mask_last_page.patch arm64-hugetlb-implement-arm64-specific-hugetlb_mask_last_page-fix.patch