Skip to contentSkip to conversation

PCI: endpoint: reduce several globals to statics

PATCH Superseded Tom Rix 3 participants 3 messages Jun 30, 2022 – Jul 4, 2022

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH v2 1/1 PCI: endpoint: reduce several globals to statics

sparse reports
drivers/pci/endpoint/functions/pci-epf-vntb.c:956:10: warning: symbol 'pci_space' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning: symbol 'pci_read' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning: symbol 'pci_write' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:989:16: warning: symbol 'vpci_ops' was not declared. Should it be static?

These functions and variables are only used in pci-epf-vntb.c, so their storage class specifiers should be static.

Fixes ff32fac00d97 ("NTB: EPF: support NTB transfer between PCI RC and EP connection")

---
v2 : Change commit prefix

---
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pci/endpoint/functions/pci-epf-vntb.c +4 -4
index ebf7e243eefa..6f0775b1fec3 100644
@@ -953,7 +953,7 @@ static struct config_group *epf_ntb_add_cfs(struct pci_epf *epf,
 
 #define VPCI_BUS_NUM 0x10
 
-uint32_t pci_space[] = {
+static uint32_t pci_space[] = {
 	(VNTB_VID | (VNTB_PID << 16)),	//DeviceID, Vendor ID
 	0,		// status, Command
 	0xffffffff,	// Class code, subclass, prog if, revision id
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
 	0,		//Max Lat, Min Gnt, interrupt pin, interrupt line
 };
 
-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
 {
 	if (devfn == 0) {
 		memcpy(val, ((uint8_t *)pci_space) + where, size);
@@ -981,12 +981,12 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
 	return -1;
 }
 
-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
 {
 	return 0;
 }
 
-struct pci_ops vpci_ops = {
+static struct pci_ops vpci_ops = {
 	.read = pci_read,
 	.write = pci_write,
 };
Signature · 1 line
2.27.0
Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Tom Rix <[email protected]>
Sent: Thursday, June 30, 2022 4:05 PM
To: [email protected]; [email protected]; [email protected]; [email protected]; Frank Li <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Tom Rix <[email protected]>
Subject: [EXT] [PATCH v2] PCI: endpoint: reduce several globals to statics

Added ntb mail list [email protected]

Quoted 13 lines

Caution: EXT Email

sparse reports drivers/pci/endpoint/functions/pci-epf-vntb.c:956:10: warning: symbol 'pci_space' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning: symbol 'pci_read' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning: symbol 'pci_write' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:989:16: warning: symbol 'vpci_ops' was not declared. Should it be static?

Quoted 8 lines

These functions and variables are only used in pci-epf-vntb.c, so their storage class specifiers should be static.

Fixes ff32fac00d97 ("NTB: EPF: support NTB transfer between PCI RC and EP

connection")

---
v2 : Change commit prefix

Quoted 51 lines
---
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pci/endpoint/functions/pci-epf-vntb.c +1 -1
index ebf7e243eefa..6f0775b1fec3 100644
@@ -953,7 +953,7 @@ static struct config_group *epf_ntb_add_cfs(struct
 pci_epf *epf,
 
 #define VPCI_BUS_NUM 0x10
 
-uint32_t pci_space[] = {
+static uint32_t pci_space[] = {
        (VNTB_VID | (VNTB_PID << 16)),  //DeviceID, Vendor ID
        0,              // status, Command
        0xffffffff,     // Class code, subclass, prog if, revision id
drivers/pci/endpoint/functions/pci-epf-vntb.c +1 -1
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
        0,              //Max Lat, Min Gnt, interrupt pin, interrupt line
 };
 
-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32
 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int
 size, u32 *val)
 {
        if (devfn == 0) {
                memcpy(val, ((uint8_t *)pci_space) + where, size);
drivers/pci/endpoint/functions/pci-epf-vntb.c +0 -0
@@ -981,12 +981,12 @@ int pci_read(struct pci_bus *bus, unsigned int

devfn, int where, int size, u32 *

        return -1;

}

-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)

 {
        return 0;

}

drivers/pci/endpoint/functions/pci-epf-vntb.c +1 -2
-struct pci_ops vpci_ops = {
+static struct pci_ops vpci_ops = {
        .read = pci_read,
        .write = pci_write,
 };
--

2.27.0

Acked-by on v2 1/1
#2 lore raw
In reply to Tom Rix
Quoted 11 lines · Tom Rix

sparse reports
drivers/pci/endpoint/functions/pci-epf-vntb.c:956:10: warning: symbol 'pci_space' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning: symbol 'pci_read' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning: symbol 'pci_write' was not declared. Should it be static? drivers/pci/endpoint/functions/pci-epf-vntb.c:989:16: warning: symbol 'vpci_ops' was not declared. Should it be static?

These functions and variables are only used in pci-epf-vntb.c, so their storage class specifiers should be static.

Fixes ff32fac00d97 ("NTB: EPF: support NTB transfer between PCI RC and EP connection")

Commit subject should include "pci-epf-vntb" prefix. Otherwise it is not possible to guess which driver this patch touches (unless one reads commit description).

With that fixed,

Thanks,
Mani

Quoted 47 lines

---
v2 : Change commit prefix

---
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pci/endpoint/functions/pci-epf-vntb.c +4 -4
index ebf7e243eefa..6f0775b1fec3 100644
@@ -953,7 +953,7 @@ static struct config_group *epf_ntb_add_cfs(struct pci_epf *epf,
 
 #define VPCI_BUS_NUM 0x10
 
-uint32_t pci_space[] = {
+static uint32_t pci_space[] = {
 	(VNTB_VID | (VNTB_PID << 16)),	//DeviceID, Vendor ID
 	0,		// status, Command
 	0xffffffff,	// Class code, subclass, prog if, revision id
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
 	0,		//Max Lat, Min Gnt, interrupt pin, interrupt line
 };
 
-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
 {
 	if (devfn == 0) {
 		memcpy(val, ((uint8_t *)pci_space) + where, size);
@@ -981,12 +981,12 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
 	return -1;
 }
 
-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
 {
 	return 0;
 }
 
-struct pci_ops vpci_ops = {
+static struct pci_ops vpci_ops = {
 	.read = pci_read,
 	.write = pci_write,
 };
Signature · 1 line
2.27.0
Signature · 1 line
மணிவண்ணன் சதாசிவம்