Skip to contentSkip to conversation

arm64: dts: ipq8074: add reset to SDHCI

PATCH In review Robert Marko 2 participants 4 messages Jul 4, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: ipq8074: add reset to SDHCI

Add reset to SDHCI controller so it can be reset to avoid timeout issues after software reset due to bootloader set configuration.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +1 -0
index ddafc7de6c5f..d685ca1969a3 100644
@@ -482,6 +482,7 @@ sdhc_1: mmc@7824900 {
 				 <&gcc GCC_SDCC1_APPS_CLK>,
 				 <&xo>;
 			clock-names = "iface", "core", "xo";
+			resets = <&gcc GCC_SDCC1_BCR>;
 			max-frequency = <384000000>;
 			mmc-ddr-1_8v;
 			mmc-hs200-1_8v;
Signature · 1 line
2.36.1
#1 lore raw
Quoted 13 lines · Robert Marko

Add reset to SDHCI controller so it can be reset to avoid timeout issues after software reset due to bootloader set configuration.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +0 -0
index ddafc7de6c5f..d685ca1969a3 100644

arch/arm64/boot/dts/qcom/ipq8074.dtsi sdhc_1: mmc@7824900 { · line 485

Quoted 4 lines
arch/arm64/boot/dts/qcom/ipq8074.dtsi +1 -0
@@ -482,6 +482,7 @@ sdhc_1: mmc@7824900 {
 				 <&gcc GCC_SDCC1_APPS_CLK>,
 				 <&xo>;
 			clock-names = "iface", "core", "xo";
+			resets = <&gcc GCC_SDCC1_BCR>;

I looked at the bindings and they do not allow reset property, so does it depend on anything?

Best regards,
Krzysztof

#2 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Robert Marko

Add reset to SDHCI controller so it can be reset to avoid timeout issues after software reset due to bootloader set configuration.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines

arch/arm64/boot/dts/qcom/ipq8074.dtsi sdhc_1: mmc@7824900 { · line 485

Quoted 9 lines
arch/arm64/boot/dts/qcom/ipq8074.dtsi +1 -0
index ddafc7de6c5f..d685ca1969a3 100644
@@ -482,6 +482,7 @@ sdhc_1: mmc@7824900 {
                               <&gcc GCC_SDCC1_APPS_CLK>,
                               <&xo>;
                      clock-names = "iface", "core", "xo";
+                     resets = <&gcc GCC_SDCC1_BCR>;

I looked at the bindings and they do not allow reset property, so does it depend on anything?

Hi Krzysztof,
It seems like the driver changes [1] were merged at the same time as when bindings
were being converted and nobody ever follow up with documenting the property.

I can document the property and send a v2 if that's OK?

Regards,
Robert

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/mmc/host/sdhci-msm.c?h=next-20220704&id=3e5a8e8494a8122fe4eb3f167662f406cab753b9

Quoted 4 lines

Best regards,
Krzysztof

#3 lore raw
Quoted 25 lines · Robert Marko
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Robert Marko

Add reset to SDHCI controller so it can be reset to avoid timeout issues after software reset due to bootloader set configuration.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines

arch/arm64/boot/dts/qcom/ipq8074.dtsi sdhc_1: mmc@7824900 { · line 485

Quoted 9 lines
arch/arm64/boot/dts/qcom/ipq8074.dtsi +1 -0
index ddafc7de6c5f..d685ca1969a3 100644
@@ -482,6 +482,7 @@ sdhc_1: mmc@7824900 {
                               <&gcc GCC_SDCC1_APPS_CLK>,
                               <&xo>;
                      clock-names = "iface", "core", "xo";
+                     resets = <&gcc GCC_SDCC1_BCR>;

I looked at the bindings and they do not allow reset property, so does it depend on anything?

Quoted 6 lines

Hi Krzysztof,
It seems like the driver changes [1] were merged at the same time as when bindings
were being converted and nobody ever follow up with documenting the property.

I can document the property and send a v2 if that's OK?

Yes, please. Otherwise DTS change will fail checks so basically should not be accepted.

Best regards,
Krzysztof