Skip to contentSkip to conversation

s390x: split migration test into vector and gs test

PATCH In review Nico Boehr 2 participants 2 messages Jul 4, 2022 – Jul 6, 2022

Subsystems (2)
lore
Share & tools
lore

Nico Boehr

author
#0 lore raw

PATCH 1/1 s390x: split migration test into vector and gs test

Since we now have a few more migration tests, let's split migration.c into two files for vector and gs facilities. Since guarded-storage and vector facilities can be en-/disabled independant of each other, this simplifies the code a bit and makes it clear what the scope of the tests is.

---
 s390x/Makefile                         |   3 +-
 s390x/migration-gs.c                   | 122 +++++++++++++++++++++++++
 s390x/{migration.c => migration-vec.c} |  54 +----------
 s390x/unittests.cfg                    |  15 ++-
 4 files changed, 136 insertions(+), 58 deletions(-)
 create mode 100644 s390x/migration-gs.c
 rename s390x/{migration.c => migration-vec.c} (77%)
s390x/Makefile +2 -1
index efd5e0c13102..90df45285b0b 100644
@@ -30,10 +30,11 @@ tests += $(TEST_DIR)/spec_ex-sie.elf
 tests += $(TEST_DIR)/firq.elf
 tests += $(TEST_DIR)/epsw.elf
 tests += $(TEST_DIR)/adtl-status.elf
-tests += $(TEST_DIR)/migration.elf
 tests += $(TEST_DIR)/pv-attest.elf
 tests += $(TEST_DIR)/migration-cmm.elf
 tests += $(TEST_DIR)/migration-skey.elf
+tests += $(TEST_DIR)/migration-gs.elf
+tests += $(TEST_DIR)/migration-vec.elf
 
 pv-tests += $(TEST_DIR)/pv-diags.elf
 
s390x/migration-gs.c new file +122 -0

122 lines not on this page · raw message

s390x/migration-vec.c renamed from s390x/migration.c +2 -52

96 lines not on this page · raw message

s390x/unittests.cfg +10 -5
index 8e52f560bb1e..04d9f0761a1f 100644
@@ -172,11 +172,6 @@ smp = 2
 accel = tcg
 extra_params = -cpu qemu,gs=off,vx=off
 
-[migration]
-file = migration.elf
-groups = migration
-smp = 2
-
 [migration-cmm]
 file = migration-cmm.elf
 groups = migration
@@ -184,3 +179,13 @@ groups = migration
 [migration-skey]
 file = migration-skey.elf
 groups = migration
+
+[migration-gs]
+file = migration-gs.elf
+groups = migration
+smp = 2
+
+[migration-vec]
+file = migration-vec.elf
+groups = migration
+smp = 2
Signature · 1 line
2.36.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Nico Boehr

Since we now have a few more migration tests, let's split migration.c into two files for vector and gs facilities. Since guarded-storage and vector facilities can be en-/disabled independant of each other, this simplifies the code a bit and makes it clear what the scope of the tests is.

Quoted 8 lines
---
  s390x/Makefile                         |   3 +-
  s390x/migration-gs.c                   | 122 +++++++++++++++++++++++++
  s390x/{migration.c => migration-vec.c} |  54 +----------
  s390x/unittests.cfg                    |  15 ++-
  4 files changed, 136 insertions(+), 58 deletions(-)

create mode 100644 s390x/migration-gs.c rename s390x/{migration.c => migration-vec.c} (77%)

Makes sense.

PS: Please have a look at the end of the README.md file to see how to set a better default subjectprefix for k-u-t patches. Thanks!