ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static
PATCH 1/1 ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static
sparse reportssound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static?
cs8409_cs42l42_pincfgs_no_dmic is only used by cs8409_fixups table as an initializer for the hda_fixup element v.pins. Both are defined in the patch_cs8408-table.c file but only cs8409_fixups is used externally in patch_cs8409.c. So cs8409_cs42l42_pincfgs_no_dmic should have a static storage class specifier.
The other v.pins initializers in cs8409_fixups table, though declared extern in patch_cs8409.h are also only used in patch_cs8409-tables.c. So change all the v.pins initializers to static.
--- sound/pci/hda/patch_cs8409-tables.c | 6 +++--- sound/pci/hda/patch_cs8409.h | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-)
sound/pci/hda/patch_cs8409-tables.c +3 -3
@@ -68,7 +68,7 @@ const struct hda_verb cs8409_cs42l42_init_verbs[] = { {}/* terminator */ }; -const struct hda_pintbl cs8409_cs42l42_pincfgs[] = { +static const struct hda_pintbl cs8409_cs42l42_pincfgs[] = { {CS8409_PIN_ASP1_TRANSMITTER_A ,0x042120f0 },/* ASP-1-TX */ {CS8409_PIN_ASP1_RECEIVER_A ,0x04a12050 },/* ASP-1-RX */ {CS8409_PIN_ASP2_TRANSMITTER_A ,0x901000f0 },/* ASP-2-TX */
@@ -76,7 +76,7 @@ const struct hda_pintbl cs8409_cs42l42_pincfgs[] = { {}/* terminator */ }; -const struct hda_pintbl cs8409_cs42l42_pincfgs_no_dmic[] = { +static const struct hda_pintbl cs8409_cs42l42_pincfgs_no_dmic[] = { {CS8409_PIN_ASP1_TRANSMITTER_A ,0x042120f0 },/* ASP-1-TX */ {CS8409_PIN_ASP1_RECEIVER_A ,0x04a12050 },/* ASP-1-RX */ {CS8409_PIN_ASP2_TRANSMITTER_A ,0x901000f0 },/* ASP-2-TX */
@@ -279,7 +279,7 @@ const struct hda_verb dolphin_init_verbs[] = { {}/* terminator */ }; -const struct hda_pintbl dolphin_pincfgs[] = { +static const struct hda_pintbl dolphin_pincfgs[] = { {0x24 ,0x022210f0 },/* ASP-1-TX-A */ {0x25 ,0x010240f0 },/* ASP-1-TX-B */ {0x34 ,0x02a21050 },/* ASP-1-RX */
sound/pci/hda/patch_cs8409.h +0 -2
@@ -358,13 +358,11 @@ extern const struct snd_pci_quirk cs8409_fixup_tbl[];extern const struct hda_model_fixup cs8409_models[];extern const struct hda_fixup cs8409_fixups[];extern const struct hda_verb cs8409_cs42l42_init_verbs[]; -extern const struct hda_pintbl cs8409_cs42l42_pincfgs[];extern const struct cs8409_cir_param cs8409_cs42l42_hw_cfg[];extern const struct cs8409_cir_param cs8409_cs42l42_bullseye_atn[];extern struct sub_codec cs8409_cs42l42_codec;extern const struct hda_verb dolphin_init_verbs[]; -extern const struct hda_pintbl dolphin_pincfgs[];extern const struct cs8409_cir_param dolphin_hw_cfg[];extern struct sub_codec dolphin_cs42l42_0;extern struct sub_codec dolphin_cs42l42_1;
Signature · 1 line
2.27.0
Takashi Iwai
AppliedQuoted 10 lines · Tom Rix
sparse reports
sound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static?
cs8409_cs42l42_pincfgs_no_dmicis only used bycs8409_fixupstable as an initializer for thehda_fixupelement v.pins. Both are defined in thepatch_cs8408-table.cfile but onlycs8409_fixupsis used externally inpatch_cs8409.c. Socs8409_cs42l42_pincfgs_no_dmicshould have a static storage class specifier.
Quoted 6 lines
The other v.pins initializers in
cs8409_fixupstable, though declared extern inpatch_cs8409.hare also only used inpatch_cs8409-tables.c. So change all the v.pins initializers to static.Fixes 9e7647b5070f ("ALSA: hda/cs8409: Move arrays of configuration to a new file")Signed-off-by Tom Rix <[email protected]>
Thanks, applied now.
Takashi