Skip to contentSkip to conversation

vDPA/ifcvf: remove duplicated assignment to pointer cfg

PATCH In review Colin Ian King 2 participants 2 messages Jul 4, 2022 – Jul 5, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vDPA/ifcvf: remove duplicated assignment to pointer cfg

The assignment to pointer cfg is duplicated, the second assignment is redundant and can be removed.

---
 drivers/vdpa/ifcvf/ifcvf_base.c | 1 -
 1 file changed, 1 deletion(-)
drivers/vdpa/ifcvf/ifcvf_base.c +0 -1
index 48c4dadb0c7c..47b94091733c 100644
@@ -29,7 +29,6 @@ u16 ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector)
 {
 	struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg;
 
-	cfg = hw->common_cfg;
 	vp_iowrite16(vector,  &cfg->msix_config);
 
 	return vp_ioread16(&cfg->msix_config);
Signature · 1 line
2.35.3
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Colin Ian King

The assignment to pointer cfg is duplicated, the second assignment is redundant and can be removed.

Quoted 19 lines
---
 drivers/vdpa/ifcvf/ifcvf_base.c | 1 -
 1 file changed, 1 deletion(-)
drivers/vdpa/ifcvf/ifcvf_base.c +0 -2
index 48c4dadb0c7c..47b94091733c 100644
@@ -29,7 +29,6 @@ u16 ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector)
 {
        struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg;
 
-       cfg = hw->common_cfg;
        vp_iowrite16(vector,  &cfg->msix_config);
 
        return vp_ioread16(&cfg->msix_config);
--

2.35.3