Skip to contentSkip to conversation

powercap: arm_scmi: Fix an ignored error return from num_domains_get()

PATCH New Yang Li 1 participant 1 message Jul 5, 2022

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 powercap: arm_scmi: Fix an ignored error return from num_domains_get()

On line 428 pr->num_zones = powercap_ops->num_domains_get(), the return of num_domains_get() is int, it can be a negative error code, however this is being assigned to an unsigned int variable, so make the num_zones to int to solve this problem without affecting other functions.

Eliminate the following coccicheck warning:
./drivers/powercap/arm_scmi_powercap.c:429:5-18: WARNING: Unsigned expression compared with zero: pr -> num_zones < 0

---
 drivers/powercap/arm_scmi_powercap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/powercap/arm_scmi_powercap.c +1 -1
index 36f6dc211fbb..11018e63bb8b 100644
@@ -29,7 +29,7 @@ struct scmi_powercap_zone {
 };
 
 struct scmi_powercap_root {
-	unsigned int num_zones;
+	int num_zones;
 	struct scmi_powercap_zone *spzones;
 	struct list_head *registered_zones;
 };
Signature · 1 line
2.20.1.7.g153144c