power: supply: Fix typo in power_supply_check_supplies
PATCH 1/1 power: supply: Fix typo in power_supply_check_supplies
It seems to be a typo, there is no actual BUG, but it's better to fix it to avoid any possible BUG after we change the type of supplied_from.
Signed-off-by Schspa Shi <[email protected]>
--- drivers/power/supply/power_supply_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/supply/power_supply_core.c +2 -2
@@ -263,13 +263,13 @@ static int power_supply_check_supplies(struct power_supply *psy)return 0 ;/* All supplies found, allocate char ** array for filling */ - psy->supplied_from =devm_kzalloc (&psy->dev,sizeof (psy->supplied_from), + psy->supplied_from =devm_kzalloc (&psy->dev,sizeof (*psy->supplied_from),GFP_KERNEL );if (!psy->supplied_from)return -ENOMEM ; *psy->supplied_from =devm_kcalloc (&psy->dev, - cnt -1 ,sizeof (char *), + cnt -1 ,sizeof (**psy->supplied_from),GFP_KERNEL );if (!*psy->supplied_from)return -ENOMEM ;
Signature · 1 line
2.29.0
Hi,
Quoted 6 lines · Schspa Shi
It seems to be a typo, there is no actual BUG, but it's better to fix it to avoid any possible BUG after we change the type of
supplied_from.Signed-off-by Schspa Shi <[email protected]>---
Thanks, queued.
-- Sebastian
Quoted 26 lines
drivers/power/supply/power_supply_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/power/supply/power_supply_core.c +2
-2@@ -263,13 +263,13 @@ static int power_supply_check_supplies(struct power_supply *psy)return 0 ;/* All supplies found, allocate char ** array for filling */ - psy->supplied_from =devm_kzalloc (&psy->dev,sizeof (psy->supplied_from), + psy->supplied_from =devm_kzalloc (&psy->dev,sizeof (*psy->supplied_from),GFP_KERNEL );if (!psy->supplied_from)return -ENOMEM ; *psy->supplied_from =devm_kcalloc (&psy->dev, - cnt -1 ,sizeof (char *), + cnt -1 ,sizeof (**psy->supplied_from),GFP_KERNEL );if (!*psy->supplied_from)return -ENOMEM ;Signature · 1 line
2.29.0