gpio: vf610: fix compilation error
PATCH 1/1 gpio: vf610: fix compilation error
From: Leon Romanovsky <[email protected]>
Fix compilation error by explicitly adding the missing include.
drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
120 | return pinctrl_gpio_direction_input(chip->base + gpio);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| vf610_gpio_direction_input--- drivers/gpio/gpio-vf610.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpio/gpio-vf610.c +1 -0
@@ -19,6 +19,7 @@#include <linux/of.h> #include <linux/of_device.h> #include <linux/of_irq.h> +#include <linux/pinctrl/consumer.h> #define VF610_GPIO_PER_PORT 32
Signature · 1 line
2.21.0
Quoted 10 lines · Tariq Toukan
From: Leon Romanovsky <[email protected]>
Fix compilation error by explicitly adding the missing include.
drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]120 | return pinctrl_gpio_direction_input(chip->base + gpio); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | vf610_gpio_direction_input
Quoted 22 lines
Fixes 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")Signed-off-by Leon Romanovsky <[email protected]>Signed-off-by Tariq Toukan <[email protected]>--- drivers/gpio/gpio-vf610.c | 1 + 1 file changed, 1 insertion(+)drivers/gpio/gpio-vf610.c +1
-1@@ -19,6 +19,7 @@#include <linux/of.h> #include <linux/of_device.h> #include <linux/of_irq.h> +#include <linux/pinctrl/consumer.h> #define VF610_GPIO_PER_PORT 32 --2.21.0
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines
Subject: [PATCH gpio] gpio: vf610: fix compilation error
From: Leon Romanovsky <[email protected]>
Fix compilation error by explicitly adding the missing include.
drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
Quoted 8 lines
120 | return pinctrl_gpio_direction_input(chip->base + gpio); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | vf610_gpio_direction_inputFixes 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for
GPIO_VF610")Signed-off-by Leon Romanovsky <[email protected]>Signed-off-by Tariq Toukan <[email protected]>
Quoted 18 lines
--- drivers/gpio/gpio-vf610.c | 1 + 1 file changed, 1 insertion(+)drivers/gpio/gpio-vf610.c index renamed from drivers/gpio/gpio-vf610.c +0
-0
23cddb265a0d..9db42f6a2043100644drivers/gpio/gpio-vf610.c +1
-1@@ -19,6 +19,7 @@#include <linux/of.h> #include <linux/of_device.h> #include <linux/of_irq.h> +#include <linux/pinctrl/consumer.h> #define VF610_GPIO_PER_PORT 32 --2.21.0
Bartosz Golaszewski
AppliedQuoted 31 lines · Tariq Toukan
From: Leon Romanovsky <[email protected]>
Fix compilation error by explicitly adding the missing include.
drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]120 | return pinctrl_gpio_direction_input(chip->base + gpio); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | vf610_gpio_direction_inputFixes 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")Signed-off-by Leon Romanovsky <[email protected]>Signed-off-by Tariq Toukan <[email protected]>--- drivers/gpio/gpio-vf610.c | 1 + 1 file changed, 1 insertion(+)drivers/gpio/gpio-vf610.c +1
-1@@ -19,6 +19,7 @@#include <linux/of.h> #include <linux/of_device.h> #include <linux/of_irq.h> +#include <linux/pinctrl/consumer.h> #define VF610_GPIO_PER_PORT 32 --
Quoted 2 lines
2.21.0
Applied, thanks!
Bart