ima: fix violation measurement list record
Subsystems (4)
Mimi Zohar
maintainerPATCH v2 1/1 ima: fix violation measurement list record
Although the violation digest in the IMA measurement list is always zeroes, the size of the digest should be based on the hash algorithm. Until recently the hash algorithm was hard coded to sha1. Fix the violation digest size included in the IMA measurement list.
This is just a cosmetic change which should not affect attestation.
Reported-by Stefan Berger <[email protected]>
Fixes 09091c44cb73 ("ima: use IMA default hash algorithm for integrity violations")
Signed-off-by Mimi Zohar <[email protected]>
--- security/integrity/ima/ima_template_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
security/integrity/ima/ima_template_lib.c +2 -2
@@ -324,9 +324,9 @@ static int ima_eventdigest_init_common(const u8 *digest, u32 digestsize,/* * If digest is NULL, the event being recorded is a violation. * Make room for the digest by increasing the offset of -* IMA_DIGEST_SIZE. +* hash algorithm digest size. */ - offset +=IMA_DIGEST_SIZE ; + offset += hash_digest_size[hash_algo];return ima_write_template_field_data (buffer, offset + digestsize, fmt, field_data);
Signature · 1 line
2.27.0
Quoted 10 lines · Mimi Zohar
Although the violation digest in the IMA measurement list is always zeroes, the size of the digest should be based on the hash algorithm. Until recently the hash algorithm was hard coded to sha1. Fix the violation digest size included in the IMA measurement list.
This is just a cosmetic change which should not affect attestation.
Reported-by Stefan Berger <[email protected]>Fixes 09091c44cb73 ("ima: use IMA default hash algorithm for integrity violations")Signed-off-by Mimi Zohar <[email protected]>
Tested-by Stefan Berger <[email protected]>
Quoted 20 lines
--- security/integrity/ima/ima_template_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)security/integrity/ima/ima_template_lib.c +2
-2@@ -324,9 +324,9 @@ static int ima_eventdigest_init_common(const u8 *digest, u32 digestsize,/* * If digest is NULL, the event being recorded is a violation. * Make room for the digest by increasing the offset of -* IMA_DIGEST_SIZE. +* hash algorithm digest size. */ - offset +=IMA_DIGEST_SIZE ; + offset += hash_digest_size[hash_algo];return ima_write_template_field_data (buffer, offset + digestsize, fmt, field_data);