Input: goodix - switch use of acpi_gpio_get_*_resource() APIs
Subsystems (3)
PATCH 1/1 Input: goodix - switch use of acpi_gpio_get_*_resource() APIs
No need to open code functionality that is provided by the acpi_gpio_get_irq_resource() and acpi_gpio_get_io_resource().
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/input/touchscreen/goodix.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)
drivers/input/touchscreen/goodix.c +8 -14
@@ -822,22 +822,16 @@ static int goodix_resource(struct acpi_resource *ares, void *data)struct device *dev = &ts->client->dev;struct acpi_resource_gpio *gpio; -switch (ares->type) { -case ACPI_RESOURCE_TYPE_GPIO : - gpio = &ares->data.gpio; -if (gpio->connection_type ==ACPI_RESOURCE_GPIO_TYPE_INT ) { -if (ts->gpio_int_idx ==-1 ) { - ts->gpio_int_idx = ts->gpio_count; - }else { -dev_err (dev,"More then one GpioInt resource, ignoring ACPI GPIO resources\n" ); - ts->gpio_int_idx =-2 ; - } +if (acpi_gpio_get_irq_resource (ares, &gpio)) { +if (ts->gpio_int_idx ==-1 ) { + ts->gpio_int_idx = ts->gpio_count; + }else { +dev_err (dev,"More then one GpioInt resource, ignoring ACPI GPIO resources\n" ); + ts->gpio_int_idx =-2 ; } ts->gpio_count++; -break ; -default : -break ; - } + }else if (acpi_gpio_get_io_resource (ares, &gpio)) + ts->gpio_count++;return 0 ; }
Signature · 1 line
2.35.1
Hi,
Quoted 4 lines · Andy Shevchenko
No need to open code functionality that is provided by the
acpi_gpio_get_irq_resource()andacpi_gpio_get_io_resource().Signed-off-by Andy Shevchenko <[email protected]>
Thanks, patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Regards,
Hans
Quoted 39 lines
--- drivers/input/touchscreen/goodix.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)drivers/input/touchscreen/goodix.c +8
-14@@ -822,22 +822,16 @@ static int goodix_resource(struct acpi_resource *ares, void *data)struct device *dev = &ts->client->dev;struct acpi_resource_gpio *gpio; -switch (ares->type) { -case ACPI_RESOURCE_TYPE_GPIO : - gpio = &ares->data.gpio; -if (gpio->connection_type ==ACPI_RESOURCE_GPIO_TYPE_INT ) { -if (ts->gpio_int_idx ==-1 ) { - ts->gpio_int_idx = ts->gpio_count; - }else { -dev_err (dev,"More then one GpioInt resource, ignoring ACPI GPIO resources\n" ); - ts->gpio_int_idx =-2 ; - } +if (acpi_gpio_get_irq_resource (ares, &gpio)) { +if (ts->gpio_int_idx ==-1 ) { + ts->gpio_int_idx = ts->gpio_count; + }else { +dev_err (dev,"More then one GpioInt resource, ignoring ACPI GPIO resources\n" ); + ts->gpio_int_idx =-2 ; } ts->gpio_count++; -break ; -default : -break ; - } + }else if (acpi_gpio_get_io_resource (ares, &gpio)) + ts->gpio_count++;return 0 ; }
Quoted 4 lines · Andy Shevchenko
No need to open code functionality that is provided by the
acpi_gpio_get_irq_resource()andacpi_gpio_get_io_resource().Signed-off-by Andy Shevchenko <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry