Skip to contentSkip to conversation

PCI: Add save and restore capability for TPH config space

PATCH New Paul Luse 1 participant 1 message Jul 5, 2022 PCI

lore
Share & tools
lore

Paul Luse

author
#0 lore raw

PATCH 1/1 PCI: Add save and restore capability for TPH config space

From: paul luse <[email protected]>

The PCI subsystem does not currently save and restore the configuration space for the TPH (Transaction Layer Packet Processing Hints) capability, leading to the possibility of configuration loss in some scenarios. For more information please refer to the PCI Express Base Specification Revision 6.0 section 6.17

This was discovered working on the SPDK Project (Storage Performance Development Kit, see https://spdk.io/) where we typically unbind devices from their native kernel driver and bind to VFIO for use with our own user space drivers. The process of binding to VFIO results in the loss of TPH settings.

---
 drivers/pci/pci.c             |   2 +
 drivers/pci/pci.h             |  10 ++++
 drivers/pci/pcie/Kconfig      |   7 +++
 drivers/pci/pcie/Makefile     |   1 +
 drivers/pci/pcie/tph.c        | 105 ++++++++++++++++++++++++++++++++++
 drivers/pci/probe.c           |   1 +
 include/uapi/linux/pci_regs.h |   2 +
 7 files changed, 128 insertions(+)
 create mode 100644 drivers/pci/pcie/tph.c
drivers/pci/pci.c +2 -0
index cfaf40a540a8..158712bf3069 100644
@@ -1670,6 +1670,7 @@ int pci_save_state(struct pci_dev *dev)
 	pci_save_dpc_state(dev);
 	pci_save_aer_state(dev);
 	pci_save_ptm_state(dev);
+	pci_save_tph_state(dev);
 	return pci_save_vc_state(dev);
 }
 EXPORT_SYMBOL(pci_save_state);
@@ -1782,6 +1783,7 @@ void pci_restore_state(struct pci_dev *dev)
 	pci_restore_rebar_state(dev);
 	pci_restore_dpc_state(dev);
 	pci_restore_ptm_state(dev);
+	pci_restore_tph_state(dev);
 
 	pci_aer_clear_status(dev);
 	pci_restore_aer_state(dev);
drivers/pci/pci.h +10 -0
index e10cdec6c56e..0c9151e150a3 100644
@@ -514,6 +514,16 @@ static inline void pci_restore_ptm_state(struct pci_dev *dev) { }
 static inline void pci_disable_ptm(struct pci_dev *dev) { }
 #endif
 
+#ifdef CONFIG_PCIE_TPH
+void pci_save_tph_state(struct pci_dev *dev);
+void pci_restore_tph_state(struct pci_dev *dev);
+void pci_tph_init(struct pci_dev *dev);
+#else
+static inline void pci_save_tph_state(struct pci_dev *dev) { }
+static inline void pci_restore_tph_state(struct pci_dev *dev) { }
+static inline void pci_tph_init(struct pci_dev *dev) { }
+#endif
+
 unsigned long pci_cardbus_resource_alignment(struct resource *);
 
 static inline resource_size_t pci_resource_alignment(struct pci_dev *dev,
drivers/pci/pcie/Kconfig +7 -0
index 788ac8df3f9d..1c7b45186bc9 100644
@@ -142,3 +142,10 @@ config PCIE_EDR
 	  the PCI Firmware Specification r3.2.  Enable this if you want to
 	  support hybrid DPC model which uses both firmware and OS to
 	  implement DPC.
+config PCIE_TPH
+	bool "PCI TPH (Transaction Layer Packet Processing Hints) capability support"
+	help
+	  This enables PCI Express TPH (Transaction Layer Packet Processing Hints) by
+	  making sure they are saved and restored across resets. Enable this if your
+	  hardware uses the PCI Express TPH capabilities. For more information please
+	  refer to the PCI Express Base Specification Revision 6.0 section 6.17.
drivers/pci/pcie/Makefile +1 -0
index 5783a2f79e6a..c91986da9337 100644
@@ -13,3 +13,4 @@ obj-$(CONFIG_PCIE_PME)		+= pme.o
 obj-$(CONFIG_PCIE_DPC)		+= dpc.o
 obj-$(CONFIG_PCIE_PTM)		+= ptm.o
 obj-$(CONFIG_PCIE_EDR)		+= edr.o
+obj-$(CONFIG_PCIE_TPH)		+= tph.o
drivers/pci/pcie/tph.c new file +105 -0

105 lines not on this page · raw message

drivers/pci/probe.c +1 -0
index 17a969942d37..1f5da3dbf128 100644
@@ -2464,6 +2464,7 @@ static void pci_init_capabilities(struct pci_dev *dev)
 	pci_aer_init(dev);		/* Advanced Error Reporting */
 	pci_dpc_init(dev);		/* Downstream Port Containment */
 	pci_rcec_init(dev);		/* Root Complex Event Collector */
+	pci_tph_init(dev);              /* Transaction Layer Packet Processing Hints */
 
 	pcie_report_downtraining(dev);
 	pci_init_reset_methods(dev);
include/uapi/linux/pci_regs.h +2 -0
index 108f8523fa04..3478b4702b0a 100644
@@ -1021,6 +1021,8 @@
 #define PCI_TPH_CAP_ST_MASK	0x07FF0000	/* ST table mask */
 #define PCI_TPH_CAP_ST_SHIFT	16	/* ST table shift */
 #define PCI_TPH_BASE_SIZEOF	0xc	/* size with no ST table */
+#define PCI_TPH_CTL		8	/* control offset */
+#define PCI_TPH_ST_TBL		0xc	/* ST table offset */
 
 /* Downstream Port Containment */
 #define PCI_EXP_DPC_CAP			0x04	/* DPC Capability */
Signature · 1 line
2.34.3