Skip to contentSkip to conversation

livepatch: create-diff-object: Check that the section has a secsym

PATCH Superseded Sarah Newman 3 participants 8 messages Jul 6, 2022 – Jul 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 livepatch: create-diff-object: Check that the section has a secsym

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

This is a livepatch backport of kpatch upstream commit [1]:
create-diff-object: Check that the section has a secsym ba3defa

[1] https://github.com/dynup/kpatch/commit/ba3defa06073dcc69917dbbbb9df570ca4e56612

---
 create-diff-object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
create-diff-object.c +1 -1
index a516670..780e6c8 100644
@@ -1484,7 +1484,7 @@ static void kpatch_include_debug_sections(struct kpatch_elf *kelf)
 	list_for_each_entry(sec, &kelf->sections, list) {
 		if (is_debug_section(sec)) {
 			sec->include = 1;
-			if (!is_rela_section(sec))
+			if (!is_rela_section(sec) && sec->secsym)
 				sec->secsym->include = 1;
 		}
 	}
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Sarah Newman

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

This is a livepatch backport of kpatch upstream commit [1]:
create-diff-object: Check that the section has a secsym ba3defa

However I think the 7-digit hash above wants either extending to at least 10 digits (better 12), or dropping altogether for having the full hash ...

Quoted 1 line

[1] https://github.com/dynup/kpatch/commit/ba3defa06073dcc69917dbbbb9df570ca4e56612

... here anyway. But I guess the rules set forth in xen.git:docs/process/sending-patches.pandoc could be applied here, and hence an Origin: tag would best be used.

The other thing is: You didn't Cc any of the maintainer(s).

Jan

#2 lore raw

PATCH v2 1/1 livepatch: create-diff-object: Check that the section has a secsym

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

Origin: https://github.com/dynup/kpatch.git ba3defa06073

---
Changes in v2:
- commit message changed to use Origin

---
 create-diff-object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
create-diff-object.c +1 -1
index a516670..780e6c8 100644
@@ -1484,7 +1484,7 @@ static void kpatch_include_debug_sections(struct kpatch_elf *kelf)
 	list_for_each_entry(sec, &kelf->sections, list) {
 		if (is_debug_section(sec)) {
 			sec->include = 1;
-			if (!is_rela_section(sec))
+			if (!is_rela_section(sec) && sec->secsym)
 				sec->secsym->include = 1;
 		}
 	}
Signature · 1 line
2.17.1
#3 lore raw
Quoted 9 lines · Sarah Newman

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

Origin: https://github.com/dynup/kpatch.git ba3defa06073

---
Changes in v2:
- commit message changed to use Origin

With this I don't see why you didn't keep Ross'es R-b. Please help committers by keeping tags up-to-date.

Jan

#4 lore raw

PATCH v3 1/1 livepatch: create-diff-object: Check that the section has a secsym

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

Origin: https://github.com/dynup/kpatch.git ba3defa06073

---
Changes in v3:
- add reviewed-by given to v1 of this patch
- restored tag from original commit per sending-patches.pandoc Changes in v2:
- commit message changed to use Origin

---
 create-diff-object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
create-diff-object.c +1 -1
index a516670..780e6c8 100644
@@ -1484,7 +1484,7 @@ static void kpatch_include_debug_sections(struct kpatch_elf *kelf)
 	list_for_each_entry(sec, &kelf->sections, list) {
 		if (is_debug_section(sec)) {
 			sec->include = 1;
-			if (!is_rela_section(sec))
+			if (!is_rela_section(sec) && sec->secsym)
 				sec->secsym->include = 1;
 		}
 	}
Signature · 1 line
2.17.1
#5 lore raw
Quoted 5 lines · Sarah Newman

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

Hmm - this wasn't here before. Does this then suggest the patch also wants to be marked From: Bill?

Quoted 3 lines

Origin: https://github.com/dynup/kpatch.git ba3defa06073

Sigh. I had given R-b on v1 as well. Actually I had meant to commit this yesterday (with all adjustments made), but as it turns out committers can't commit to that tree. So it'll be up to Ross or Konrad to actually take care of this.

Jan

#6 lore raw
Quoted 9 lines · Jan Beulich
Quoted 5 lines · Sarah Newman

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

Hmm - this wasn't here before. Does this then suggest the patch also wants to be marked From: Bill?

I don't know what the etiquette is here since this was a commit originally committed to kpatch, I just added that back because the xen patch submission guidelines said to preserve original tags.

Quoted 5 lines
Quoted 4 lines

Origin: https://github.com/dynup/kpatch.git ba3defa06073

Quoted 7 lines

Sigh. I had given R-b on v1 as well. Actually I had meant to commit this yesterday (with all adjustments made), but as it turns out committers can't commit to that tree. So it'll be up to Ross or Konrad to actually take care of this.

Jan

My apologies, I simply missed that.

I am doing this in my spare time. This is the first time I've gone through this process in a couple of years and have only done it a few times total.

Thanks, Sarah

Reviewed-by on v1 1/1
#7 lore raw
In reply to Sarah Newman
Quoted 6 lines

From: Xen-devel <[email protected]> on behalf of Sarah Newman <[email protected]>
Sent: Wednesday, July 6, 2022 3:18 AM
To: [email protected] <[email protected]>
Cc: Sarah Newman <[email protected]>
Subject: [PATCH] livepatch: create-diff-object: Check that the section has a secsym

Quoted 9 lines

A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it.

This is a livepatch backport of kpatch upstream commit [1]:
create-diff-object: Check that the section has a secsym ba3defa