Skip to contentSkip to conversation

mt76: address4 null frame using fixed rate to trigger WDS

PATCH In review Lian Chen 3 participants 3 messages Jul 6, 2022 – Jul 26, 2022

Subsystems (2)
lore
Share & tools
lore

Lian Chen

author
#0 lore raw

PATCH 1/1 mt76: address4 null frame using fixed rate to trigger WDS

From: "lian.chen" <[email protected]>

WDS function need address4 package to trigger the AP create wlan0.sta. while the address4 null frame is sent at a high rate.
the AP can not receive it.
so, using fixed rate to trigger WDS flow.

---
 drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +2 -1
index 3ab0dcd..d83ed59 100644
@@ -393,7 +393,8 @@ mt76_connac2_mac_write_txwi_80211(struct mt76_dev *dev, __le32 *txwi,
 	}
 
 	if (!ieee80211_is_data(fc) || multicast ||
-	    info->flags & IEEE80211_TX_CTL_USE_MINRATE)
+	    info->flags & IEEE80211_TX_CTL_USE_MINRATE ||
+	    (ieee80211_is_nullfunc(fc) && ieee80211_has_a4(fc)))
 		val |= MT_TXD2_FIX_RATE;
 
 	txwi[2] |= cpu_to_le32(val);
Signature · 1 line
2.18.0
maintainer
#1 lore raw
Quoted 8 lines · Lian Chen

From: "lian.chen" <[email protected]>

WDS function need address4 package to trigger the AP create wlan0.sta. while the address4 null frame is sent at a high rate.
the AP can not receive it.
so, using fixed rate to trigger WDS flow.

I think it might make more sense to set IEEE80211_TX_CTL_USE_MINRATE in the mac80211 function ieee80211_send_4addr_nullfunc().

- Felix

#2 lore raw
In reply to Lian Chen
Quoted 1 line · Lian Chen

From: "lian.chen" <[email protected]>

Please don't use dot in your name and capitalise it as well. So this should be:

From: "Lian Chen" <[email protected]>

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches