xfs: removed useless condition in function xfs_attr_node_get
PATCH 1/1 xfs: removed useless condition in function xfs_attr_node_get
At line 1561, variable "state" is being compared
with NULL every loop iteration.
-------------------------------------------------------------------
1561 for (i = 0; state != NULL && i < state->path.active; i++) {
1562 xfs_trans_brelse(args->trans, state->path.blk[i].bp);
1563 state->path.blk[i].bp = NULL;
1564 }
-------------------------------------------------------------------
However, it cannot be NULL.
----------------------------------------
1546 state = xfs_da_state_alloc(args);
----------------------------------------
xfs_da_state_alloc calls kmem_cache_zalloc. kmem_cache_zalloc is called with __GFP_NOFAIL flag and, therefore, it cannot return NULL.
--------------------------------------------------------------------------
struct xfs_da_state *
xfs_da_state_alloc(
struct xfs_da_args *args)
{
struct xfs_da_state *state;
state = kmem_cache_zalloc(xfs_da_state_cache, GFP_NOFS | __GFP_NOFAIL);
state->args = args;
state->mp = args->dp->i_mount;
return state;
}--------------------------------------------------------------------------
Found by Linux Verification Center (linuxtesting.org) with SVACE.
--- fs/xfs/libxfs/xfs_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/libxfs/xfs_attr.c +1 -1
@@ -1558,7 +1558,7 @@ xfs_attr_node_get(* If not in a transaction, we have to release all the buffers. */ out_release: -for (i =0 ; state !=NULL && i < state->path.active; i++) { +for (i =0 ; i < state->path.active; i++) {xfs_trans_brelse (args->trans, state->path.blk[i].bp); state->path.blk[i].bp =NULL ; }
Signature · 1 line
2.25.1
Quoted 31 lines · Andrey Strachuk
At line 1561, variable "state" is being compared
with NULL every loop iteration.-------------------------------------------------------------------
1561 for (i = 0; state != NULL && i <state->path.active; i++) {
1562xfs_trans_brelse(args->trans, state->path.blk[i].bp);
1563 state->path.blk[i].bp = NULL;
1564 }
-------------------------------------------------------------------However, it cannot be NULL.
----------------------------------------
1546 state =xfs_da_state_alloc(args);
----------------------------------------
xfs_da_state_alloccallskmem_cache_zalloc.kmem_cache_zallocis called with__GFP_NOFAILflag and, therefore, it cannot return NULL.--------------------------------------------------------------------------
struct xfs_da_state * xfs_da_state_alloc( struct xfs_da_args *args) { struct xfs_da_state *state; state = kmem_cache_zalloc(xfs_da_state_cache, GFP_NOFS | __GFP_NOFAIL); state->args = args; state->mp = args->dp->i_mount; return state; }
Quoted 7 lines
--------------------------------------------------------------------------
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by Andrey Strachuk <[email protected]>Fixes 4d0cdd2bb8f0 ("xfs: clean up xfs_attr_node_hasname")
Nit: usually the tags go at the end with no empty lines between them.
The change looks correct to me, so
--D
Quoted 20 lines
--- fs/xfs/libxfs/xfs_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/libxfs/xfs_attr.c +1
-1@@ -1558,7 +1558,7 @@ xfs_attr_node_get(* If not in a transaction, we have to release all the buffers. */ out_release: -for (i =0 ; state !=NULL && i < state->path.active; i++) { +for (i =0 ; i < state->path.active; i++) {xfs_trans_brelse (args->trans, state->path.blk[i].bp); state->path.blk[i].bp =NULL ; }Signature · 1 line
2.25.1