net: stmmac: dwc-qos: Disable split header for Tegra194
Subsystems (5)
Jon Hunter
maintainerPATCH 1/1 net: stmmac: dwc-qos: Disable split header for Tegra194
There is a long-standing issue with the Synopsys DWC Ethernet driver for Tegra194 where random system crashes have been observed [0]. The problem occurs when the split header feature is enabled in the stmmac driver. In the bad case, a larger than expected buffer length is received and causes the calculation of the total buffer length to overflow. This results in a very large buffer length that causes the kernel to crash. Why this larger buffer length is received is not clear, however, the feedback from the NVIDIA design team is that the split header feature is not supported for Tegra194. Therefore, disable split header support for Tegra194 to prevent these random crashes from occurring.
[0] https://lore.kernel.org/linux-tegra/[email protected]/
--- drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c +1 -0
@@ -361,6 +361,7 @@ static int tegra_eqos_probe(struct platform_device *pdev, data->fix_mac_speed = tegra_eqos_fix_speed; data->init = tegra_eqos_init; data->bsp_priv = eqos; + data->sph_disable =1 ; err =tegra_eqos_init (pdev, eqos);if (err <0 )
Signature · 1 line
2.25.1
Jakub Kicinski
maintainerQuoted 12 lines · On Wed, 6 Jul 2022 09:39:13 +0100 Jon Hunter wrote:
There is a long-standing issue with the Synopsys DWC Ethernet driver for Tegra194 where random system crashes have been observed [0]. The problem occurs when the split header feature is enabled in the stmmac driver. In the bad case, a larger than expected buffer length is received and causes the calculation of the total buffer length to overflow. This results in a very large buffer length that causes the kernel to crash. Why this larger buffer length is received is not clear, however, the feedback from the NVIDIA design team is that the split header feature is not supported for Tegra194. Therefore, disable split header support for Tegra194 to prevent these random crashes from occurring.
Quoted 3 lines
[0] https://lore.kernel.org/linux-tegra/[email protected]/
Signed-off-by Jon Hunter <[email protected]>
correct?
Jon Hunter
maintainerQuoted 13 lines · Jakub Kicinski
Quoted 12 lines · On Wed, 6 Jul 2022 09:39:13 +0100 Jon Hunter wrote:
There is a long-standing issue with the Synopsys DWC Ethernet driver for Tegra194 where random system crashes have been observed [0]. The problem occurs when the split header feature is enabled in the stmmac driver. In the bad case, a larger than expected buffer length is received and causes the calculation of the total buffer length to overflow. This results in a very large buffer length that causes the kernel to crash. Why this larger buffer length is received is not clear, however, the feedback from the NVIDIA design team is that the split header feature is not supported for Tegra194. Therefore, disable split header support for Tegra194 to prevent these random crashes from occurring.
Quoted 7 lines
Quoted 3 lines
[0] https://lore.kernel.org/linux-tegra/[email protected]/
Signed-off-by Jon Hunter <[email protected]>Fixes 67afd6d1cfdf ("net: stmmac: Add Split Header support and enable it in XGMAC cores")correct?
Yes that is correct. I forgot to add. Let me know if you want me to send a V2.
Thanks
Jon
Signature · 1 line
nvpublic
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 12 lines · On Wed, 6 Jul 2022 09:39:13 +0100 you wrote:
There is a long-standing issue with the Synopsys DWC Ethernet driver for Tegra194 where random system crashes have been observed [0]. The problem occurs when the split header feature is enabled in the stmmac driver. In the bad case, a larger than expected buffer length is received and causes the calculation of the total buffer length to overflow. This results in a very large buffer length that causes the kernel to crash. Why this larger buffer length is received is not clear, however, the feedback from the NVIDIA design team is that the split header feature is not supported for Tegra194. Therefore, disable split header support for Tegra194 to prevent these random crashes from occurring.
Quoted 1 line
[...]
Here is the summary with links:
- net: stmmac: dwc-qos: Disable split header for Tegra194
https://git.kernel.org/netdev/net/c/029c1c2059e9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html