Skip to contentSkip to conversation

drm/amd/display: correct idle_power_optimizations disablement return value

PATCH New Evan Quan 1 participant 1 message Jul 7, 2022

Subsystems (3)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH v2 1/1 drm/amd/display: correct idle_power_optimizations disablement return value

[Why]
The return value indicates whether the operation(disable/enable) succeeded or not. The existing logic reports wrong result even if the disablement was performed successfully. That will make succeeding reenablement abandoned as dc->idle_optimizations_allowed is always true.

[How]
Correct the return value to reflect the real result of disablement.

Fixes 235c67634230 ("drm/amd/display: add DCN32/321 specific files for Display Core")
Change-Id If87d4cf76f6cfb36d607f051ff32f9c7870b4d6d

--
v1->v2:
- correct the hash tag and drop the CC to stable (Alex)

---
 drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c +1 -1
index d53cbfef3558..1acd74fa4e55 100644
@@ -373,7 +373,7 @@ bool dcn32_apply_idle_power_optimizations(struct dc *dc, bool enable)
 	dc_dmub_srv_cmd_execute(dc->ctx->dmub_srv);
 	dc_dmub_srv_wait_idle(dc->ctx->dmub_srv);
 
-	return false;
+	return true;
 }
 
 /* Send DMCUB message with SubVP pipe info
Signature · 1 line
2.29.0