Skip to contentSkip to conversation

rule: crash when uncollapsing command with unexisting table or set

PATCH New Pablo Neira Ayuso 1 participant 1 message Jul 7, 2022 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 rule: crash when uncollapsing command with unexisting table or set

If ruleset update refers to an unexisting table or set, then cmd->elem.set is NULL.

Fixes 498a5f0c219d ("rule: collapse set element commands")
---
 src/rule.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
src/rule.c +3 -1
index 79d4b77756e4..9c9eaec0c77b 100644
@@ -1453,7 +1453,9 @@ void nft_cmd_uncollapse(struct list_head *cmds)
 		}
 
 		list_for_each_entry_safe(collapse_cmd, collapse_cmd_next, &cmd->collapse_list, list) {
-			collapse_cmd->elem.set = set_get(cmd->elem.set);
+			if (cmd->elem.set)
+				collapse_cmd->elem.set = set_get(cmd->elem.set);
+
 			list_add(&collapse_cmd->list, &cmd->list);
 		}
 	}
Signature · 1 line
2.30.2