Skip to contentSkip to conversation

NTB: EPF: Mark pci_read and pci_write as static

PATCH In review Souptick Joarder 3 participants 3 messages Jul 8, 2022 – Aug 12, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NTB: EPF: Mark pci_read and pci_write as static

From: "Souptick Joarder (HPE)" <[email protected]>

kernel test robot throws below warning ->

drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
no previous prototype for 'pci_read' [-Wmissing-prototypes] drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
no previous prototype for 'pci_write' [-Wmissing-prototypes]

mark them as static.

---
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/endpoint/functions/pci-epf-vntb.c +2 -2
index ebf7e243eefa..111568089d45 100644
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
 	0,		//Max Lat, Min Gnt, interrupt pin, interrupt line
 };
 
-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
 {
 	if (devfn == 0) {
 		memcpy(val, ((uint8_t *)pci_space) + where, size);
@@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
 	return -1;
 }
 
-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
 {
 	return 0;
 }
Signature · 1 line
2.25.1
#1 lore raw
Quoted 9 lines · Souptick Joarder

From: "Souptick Joarder (HPE)" <[email protected]>

kernel test robot throws below warning ->

drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
no previous prototype for 'pci_read' [-Wmissing-prototypes] drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
no previous prototype for 'pci_write' [-Wmissing-prototypes]

Quoted 4 lines

mark them as static.

IIUC this series is going via Jon. Let me know if I need to do anything.

Quoted 29 lines
---
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/endpoint/functions/pci-epf-vntb.c +2 -2
index ebf7e243eefa..111568089d45 100644
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
 	0,		//Max Lat, Min Gnt, interrupt pin, interrupt line
 };
 
-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
 {
 	if (devfn == 0) {
 		memcpy(val, ((uint8_t *)pci_space) + where, size);
@@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
 	return -1;
 }
 
-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
 {
 	return 0;
 }
Signature · 1 line
2.25.1
maintainer
#2 lore raw
Quoted 10 lines · Bjorn Helgaas
Quoted 9 lines · Souptick Joarder

From: "Souptick Joarder (HPE)" <[email protected]>

kernel test robot throws below warning ->

drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
no previous prototype for 'pci_read' [-Wmissing-prototypes] drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
no previous prototype for 'pci_write' [-Wmissing-prototypes]

Quoted 7 lines
Quoted 4 lines

mark them as static.

IIUC this series is going via Jon. Let me know if I need to do anything.

Sorry for the extremely long delay in response. This series is in my ntb branch and will be in my pull request for v5.20 which should be going out later today.

Thanks,
Jon

Quoted 30 lines
Quoted 30 lines
---
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/endpoint/functions/pci-epf-vntb.c +2 -2
index ebf7e243eefa..111568089d45 100644
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
 	0,		//Max Lat, Min Gnt, interrupt pin, interrupt line
 };
 
-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
 {
 	if (devfn == 0) {
 		memcpy(val, ((uint8_t *)pci_space) + where, size);
@@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
 	return -1;
 }
 
-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
 {
 	return 0;
 }
Signature · 1 line
2.25.1