netfilter: nf_tables: release key if get element fails
Subsystems (2)
Pablo Neira Ayuso
maintainerPATCH 1/1 netfilter: nf_tables: release key if get element fails
Call nft_data_release() to release the element keys otherwise this might leak chain reference counter.
Fixes ba0e4d9917b4 ("netfilter: nf_tables: get set elements via netlink")
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- net/netfilter/nf_tables_api.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
net/netfilter/nf_tables_api.c +8 -3
@@ -5306,17 +5306,17 @@ static int nft_get_set_elem(struct nft_ctx *ctx, struct nft_set *set, err =nft_setelem_parse_key (ctx, set, &elem.key_end.val, nla[NFTA_SET_ELEM_KEY_END ]);if (err <0 ) -return err; + goto err_parse_key; } err =nft_setelem_get (ctx, set, &elem, flags);if (err <0 ) -return err; + goto err_parse_key_end; err = -ENOMEM ; skb =nlmsg_new (NLMSG_GOODSIZE ,GFP_ATOMIC );if (skb ==NULL ) -return err; + goto err_parse_key_end; err =nf_tables_fill_setelem_info (skb, ctx, ctx->seq, ctx->portid,NFT_MSG_NEWSETELEM ,0 , set, &elem);
@@ -5327,6 +5327,11 @@ static int nft_get_set_elem(struct nft_ctx *ctx, struct nft_set *set, err_fill_setelem:kfree_skb (skb); +err_parse_key: +nft_data_release (&elem.key.val,NFT_DATA_VALUE ); +err_parse_key_end: +nft_data_release (&elem.key_end.val,NFT_DATA_VALUE ); +return err; }
Signature · 1 line
2.30.2