thermal OF rework
Subsystems (3)
v4 cover thermal OF rework
The thermal framework initialization with the device tree appears to be complicated and hard to make it to evolve.
It contains duplication of almost the same thermal generic structures and has an assymetric initialization making hard any kind of serious changes for more complex features. One of them is the multiple sensors support per thermal zone.
In order to set the scene for the aforementioned feature with generic code, we need to cleanup and rework the device tree initialization.
However this rework is not obvious because of the multiple components entering in the composition of a thermal zone and being initialized at different moments. For instance, a cooling device can be initialized before a sensor, so the thermal zones must exist before the cooling device as well as the sensor. This asynchronous initialization forces the thermal zone to be created with fake ops because they are mandotory and build a list of cooling devices which is used to lookup afterwards when the cooling device driver is registering itself.
As there could be a large number of changes, this first series provide some steps forward for a simpler device tree initialization.
More series for cleanup and code duplication removal will follow.
Changelog:
- V4:
- Added of_node_put(trips)
- Changed naming 'ntrips' -> 'num_trips'
- Updated documentation for added and renamed fields in the thermal zone structure
- Fixed bad parameter type 'thermal_zone' -> 'thermal_zone_device'
- Clarified there is more cleanups coming in the changelog
- Put 'trips' and 'num_trips' fields all together
- Made git-bisect safe the series
- V3:
- Removed patch 1 and 2 from the V2 which consist in renaming the thermal_zone_device_ops to thermal_sensor_ops and separating the structure. I'll do a separate proposal for that after the incoming cleanups
- V2:
- Drop patch 1/15 which contains too many changes for a simple structure renaming. This could be addressed in a separate series as it is not necessary for the OF rework
- Fixed of_node_put with gchild not initialized as reported by kbuild and Dan Carpenter
- V1:
- Initial post
Daniel Lezcano (12):
thermal/core: Remove duplicate information when an error occurs thermal/of: Replace device node match with device node search thermal/of: Remove the device node pointer for thermal_trip thermal/of: Move thermal_trip structure to thermal.h thermal/core: Remove unneeded EXPORT_SYMBOLS thermal/core: Move thermal_set_delay_jiffies to static thermal/core: Rename trips to ntrips
thermal/core: Add thermal_trip in thermal_zone thermal/core: Register with the trip points thermal/of: Store the trips in the thermal zone thermal/of: Use thermal trips stored in the thermal zone thermal/of: Initialize trip points separately
drivers/thermal/gov_fair_share.c | 6 +- drivers/thermal/gov_power_allocator.c | 4 +- drivers/thermal/tegra/tegra30-tsensor.c | 2 +- drivers/thermal/thermal_core.c | 53 +++++-- drivers/thermal/thermal_core.h | 25 ++- drivers/thermal/thermal_helpers.c | 13 +- drivers/thermal/thermal_netlink.c | 2 +- drivers/thermal/thermal_of.c | 200 +++++++++++++----------- drivers/thermal/thermal_sysfs.c | 22 +-- include/linux/thermal.h | 24 ++- 10 files changed, 199 insertions(+), 152 deletions(-)
Signature · 1 line
2.25.1
PATCH v4 1/12 thermal/core: Remove duplicate information when an error occurs
The pr_err already tells it is an error, it is pointless to add the 'Error:' string in the messages. Remove them.
--- drivers/thermal/thermal_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/thermal/thermal_core.c +4 -4
@@ -1198,23 +1198,23 @@ thermal_zone_device_register(const char *type, int trips, int mask,struct thermal_governor *governor;if (!type ||strlen (type) ==0 ) { -pr_err ("Error: No thermal zone type defined\n" ); +pr_err ("No thermal zone type defined\n" );return ERR_PTR (-EINVAL ); }if (type &&strlen (type) >=THERMAL_NAME_LENGTH ) { -pr_err ("Error: Thermal zone name (%s) too long, should be under %d chars\n" , +pr_err ("Thermal zone name (%s) too long, should be under %d chars\n" , type,THERMAL_NAME_LENGTH );return ERR_PTR (-EINVAL ); }if (trips >THERMAL_MAX_TRIPS || trips <0 || mask >> trips) { -pr_err ("Error: Incorrect number of thermal trips\n" ); +pr_err ("Incorrect number of thermal trips\n" );return ERR_PTR (-EINVAL ); }if (!ops) { -pr_err ("Error: Thermal zone device ops not defined\n" ); +pr_err ("Thermal zone device ops not defined\n" );return ERR_PTR (-EINVAL ); }
Signature · 1 line
2.25.1
PATCH v4 2/12 thermal/of: Replace device node match with device node search
In reply to Daniel LezcanoThe thermal_of code builds a trip array associated with the node pointer in order to compare the trip point phandle with the list.
The thermal trip is a thermal zone property and should be moved there. If some sensors have hardcoded trip points, they should use the exported structure instead of redefining again and again their own structure and data to describe exactly the same things.
In order to move this to the thermal.h header and allow more cleanup, we need to remove the node pointer from the structure.
Instead of building storing the device node, we search directly in the device tree the corresponding node. That results in a simplification of the code and allows to move the structure to thermal.h
--- drivers/thermal/thermal_of.c | 64 +++++++++++++++++++++++++----------- 1 file changed, 44 insertions(+), 20 deletions(-)
drivers/thermal/thermal_of.c +44 -20
@@ -671,6 +671,35 @@ EXPORT_SYMBOL_GPL(devm_thermal_zone_of_sensor_unregister);/*** functions parsing device tree nodes ***/ +static int of_find_trip_id (struct device_node *np,struct device_node *trip) +{ +struct device_node *trips; +struct device_node *t; +int i =0 ; + + trips =of_get_child_by_name (np,"trips" ); +if (!trips) { +pr_err ("Failed to find 'trips' node\n" ); +return -EINVAL ; + } + +/* +* Find the trip id point associated with the cooling device map +*/ +for_each_child_of_node (trips, t) { + +if (t == trip) + goto out; + i++; + } + + i = -ENXIO ; +out: +of_node_put (trips); + +return i; +} +/** * thermal_of_populate_bind_params - parse and fill cooling map data * @np: DT node containing a cooling-map node
@@ -686,14 +715,13 @@ EXPORT_SYMBOL_GPL(devm_thermal_zone_of_sensor_unregister);* Return: 0 on success, proper error code otherwise */ static int thermal_of_populate_bind_params (struct device_node *np, -struct __thermal_bind_params *__tbp, -struct thermal_trip *trips, -int ntrips) +struct __thermal_bind_params *__tbp) {struct of_phandle_args cooling_spec;struct __thermal_cooling_bind_param *__tcbp;struct device_node *trip;int ret, i, count; +int trip_id;u32 prop;/* Default weight. Usage is optional */
@@ -708,18 +736,14 @@ static int thermal_of_populate_bind_params(struct device_node *np,return -ENODEV ; } -/* match using device_node */ -for (i =0 ; i < ntrips; i++) -if (trip == trips[i].np) { - __tbp->trip_id = i; -break ; - } - -if (i == ntrips) { - ret = -ENODEV ; + trip_id =of_find_trip_id (np, trip); +if (trip_id <0 ) { + ret = trip_id; goto end; } + __tbp->trip_id = trip_id; + count =of_count_phandle_with_args (np,"cooling-device" ,"#cooling-cells" );if (count <=0 ) {
@@ -868,6 +892,7 @@ static struct __thermal_zone __init *thermal_of_build_thermal_zone(struct device_node *np) {struct device_node *child =NULL , *gchild; +struct device_node *trips;struct __thermal_zone *tz;int ret, i;u32 prop, coef[2 ];
@@ -910,13 +935,13 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) }/* trips */ - child =of_get_child_by_name (np,"trips" ); + trips =of_get_child_by_name (np,"trips" );/* No trips provided */ -if (!child) +if (!trips) goto finish; - tz->ntrips =of_get_child_count (child); + tz->ntrips =of_get_child_count (trips);if (tz->ntrips ==0 )/* must have at least one child */ goto finish;
@@ -927,14 +952,12 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) } i =0 ; -for_each_child_of_node (child, gchild) { +for_each_child_of_node (trips, gchild) { ret =thermal_of_populate_trip (gchild, &tz->trips[i++]);if (ret) goto free_trips; } -of_node_put (child); -/* cooling-maps */ child =of_get_child_by_name (np,"cooling-maps" );
@@ -954,13 +977,13 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) i =0 ;for_each_child_of_node (child, gchild) { - ret =thermal_of_populate_bind_params (gchild, &tz->tbps[i++], - tz->trips, tz->ntrips); + ret =thermal_of_populate_bind_params (gchild, &tz->tbps[i++]);if (ret) goto free_tbps; } finish: +of_node_put (trips);of_node_put (child);return tz;
@@ -981,6 +1004,7 @@ __init *thermal_of_build_thermal_zone(struct device_node *np)for (i =0 ; i < tz->ntrips; i++)of_node_put (tz->trips[i].np);kfree (tz->trips); +of_node_put (trips);of_node_put (gchild); free_tz:kfree (tz);
Signature · 1 line
2.25.1
PATCH v4 3/12 thermal/of: Remove the device node pointer for thermal_trip
In reply to Daniel LezcanoThe device node pointer is no longer needed in the thermal trip structure, remove it.
--- drivers/thermal/thermal_core.h | 2 -- drivers/thermal/thermal_of.c | 8 -------- 2 files changed, 10 deletions(-)
drivers/thermal/thermal_core.h +0 -2
@@ -70,13 +70,11 @@ void __thermal_cdev_update(struct thermal_cooling_device *cdev);/** * struct thermal_trip - representation of a point in temperature domain -* @np: pointer to struct device_node that this trip point was created from * @temperature: temperature value in miliCelsius * @hysteresis: relative hysteresis in miliCelsius * @type: trip point type */ struct thermal_trip { -struct device_node *np;int temperature;int hysteresis;enum thermal_trip_type type;
drivers/thermal/thermal_of.c +0 -8
@@ -867,10 +867,6 @@ static int thermal_of_populate_trip(struct device_node *np,return ret; } -/* Required for cooling map matching */ - trip->np = np; -of_node_get (np); -return 0 ; }
@@ -1001,8 +997,6 @@ __init *thermal_of_build_thermal_zone(struct device_node *np)kfree (tz->tbps); free_trips: -for (i =0 ; i < tz->ntrips; i++) -of_node_put (tz->trips[i].np);kfree (tz->trips);of_node_put (trips);of_node_put (gchild);
@@ -1028,8 +1022,6 @@ static __init void of_thermal_free_zone(struct __thermal_zone *tz) }kfree (tz->tbps); -for (i =0 ; i < tz->ntrips; i++) -of_node_put (tz->trips[i].np);kfree (tz->trips);kfree (tz); }
Signature · 1 line
2.25.1
PATCH v4 4/12 thermal/of: Move thermal_trip structure to thermal.h
In reply to Daniel LezcanoThe structure thermal_trip is now generic and will be usable by the different sensor drivers in place of their own structure.
Move its definition to thermal.h to make it accessible.
--- drivers/thermal/thermal_core.h | 12 ------------ include/linux/thermal.h | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/thermal/thermal_core.h +0 -12
@@ -68,18 +68,6 @@ static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev)void thermal_cdev_update (struct thermal_cooling_device *);void __thermal_cdev_update (struct thermal_cooling_device *cdev); -/** -* struct thermal_trip - representation of a point in temperature domain -* @temperature: temperature value in miliCelsius -* @hysteresis: relative hysteresis in miliCelsius -* @type: trip point type -*/ -struct thermal_trip { -int temperature; -int hysteresis; -enum thermal_trip_type type; -}; -int get_tz_trend (struct thermal_zone_device *tz,int trip); struct thermal_instance *
include/linux/thermal.h +12 -0
@@ -80,6 +80,18 @@ struct thermal_zone_device_ops {void (*critical)(struct thermal_zone_device *); }; +/** +* struct thermal_trip - representation of a point in temperature domain +* @temperature: temperature value in miliCelsius +* @hysteresis: relative hysteresis in miliCelsius +* @type: trip point type +*/ +struct thermal_trip { +int temperature; +int hysteresis; +enum thermal_trip_type type; +}; +struct thermal_cooling_device_ops {int (*get_max_state) (struct thermal_cooling_device *,unsigned long *);int (*get_cur_state) (struct thermal_cooling_device *,unsigned long *);
Signature · 1 line
2.25.1
PATCH v4 5/12 thermal/core: Remove unneeded EXPORT_SYMBOLS
In reply to Daniel LezcanoDifferent functions are exporting the symbols but are actually only used by the thermal framework internals. Remove these EXPORT_SYMBOLS.
--- drivers/thermal/thermal_helpers.c | 2 -- 1 file changed, 2 deletions(-)
drivers/thermal/thermal_helpers.c +0 -2
@@ -39,7 +39,6 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip)return trend; } -EXPORT_SYMBOL (get_tz_trend);struct thermal_instance * get_thermal_instance(struct thermal_zone_device *tz,
@@ -228,7 +227,6 @@ void thermal_cdev_update(struct thermal_cooling_device *cdev) }mutex_unlock (&cdev->lock); } -EXPORT_SYMBOL (thermal_cdev_update);/** * thermal_zone_get_slope - return the slope attribute of the thermal zone
Signature · 1 line
2.25.1
PATCH v4 6/12 thermal/core: Move thermal_set_delay_jiffies to static
In reply to Daniel LezcanoThe function 'thermal_set_delay_jiffies' is only used in thermal_core.c but it is defined and implemented in a separate file. Move the function to thermal_core.c and make it static.
--- drivers/thermal/thermal_core.c | 7 +++++++ drivers/thermal/thermal_core.h | 1 - drivers/thermal/thermal_helpers.c | 7 ------- 3 files changed, 7 insertions(+), 8 deletions(-)
drivers/thermal/thermal_core.c +7 -0
@@ -1159,6 +1159,13 @@ static void bind_tz(struct thermal_zone_device *tz)mutex_unlock (&thermal_list_lock); } +static void thermal_set_delay_jiffies (unsigned long *delay_jiffies,int delay_ms) +{ + *delay_jiffies =msecs_to_jiffies (delay_ms); +if (delay_ms >1000 ) + *delay_jiffies =round_jiffies (*delay_jiffies); +} +/** * thermal_zone_device_register() - register a new thermal zone device * @type: the thermal zone device type
drivers/thermal/thermal_core.h +0 -1
@@ -112,7 +112,6 @@ int thermal_build_list_of_policies(char *buf);/* Helpers */ void thermal_zone_set_trips (struct thermal_zone_device *tz); -void thermal_set_delay_jiffies (unsigned long *delay_jiffies,int delay_ms);/* sysfs I/F */ int thermal_zone_create_device_groups (struct thermal_zone_device *,int );
drivers/thermal/thermal_helpers.c +0 -7
@@ -174,13 +174,6 @@ void thermal_zone_set_trips(struct thermal_zone_device *tz)mutex_unlock (&tz->lock); } -void thermal_set_delay_jiffies (unsigned long *delay_jiffies,int delay_ms) -{ - *delay_jiffies =msecs_to_jiffies (delay_ms); -if (delay_ms >1000 ) - *delay_jiffies =round_jiffies (*delay_jiffies); -} -static void thermal_cdev_set_cur_state (struct thermal_cooling_device *cdev,int target) {
Signature · 1 line
2.25.1
PATCH v4 7/12 thermal/core: Rename 'trips' to 'num_trips'
In reply to Daniel LezcanoIn order to use thermal trips defined in the thermal structure, rename the 'trips' field to 'ntrips' to have the 'trips' field containing the thermal trip points.
--- drivers/thermal/gov_fair_share.c | 6 +++--- drivers/thermal/gov_power_allocator.c | 4 ++-- drivers/thermal/tegra/tegra30-tsensor.c | 2 +- drivers/thermal/thermal_core.c | 20 ++++++++++---------- drivers/thermal/thermal_helpers.c | 4 ++-- drivers/thermal/thermal_netlink.c | 2 +- drivers/thermal/thermal_sysfs.c | 22 +++++++++++----------- include/linux/thermal.h | 4 ++-- 8 files changed, 32 insertions(+), 32 deletions(-)
drivers/thermal/gov_fair_share.c +3 -3
@@ -25,10 +25,10 @@ static int get_trip_level(struct thermal_zone_device *tz)int trip_temp;enum thermal_trip_type trip_type; -if (tz->trips ==0 || !tz->ops->get_trip_temp) +if (tz->num_trips ==0 || !tz->ops->get_trip_temp)return 0 ; -for (count =0 ; count < tz->trips; count++) { +for (count =0 ; count < tz->num_trips; count++) { tz->ops->get_trip_temp (tz, count, &trip_temp);if (tz->temperature < trip_temp)break ;
@@ -53,7 +53,7 @@ static long get_target_state(struct thermal_zone_device *tz, cdev->ops->get_max_state (cdev, &max_state); -return (long )(percentage * level * max_state) / (100 * tz->trips); +return (long )(percentage * level * max_state) / (100 * tz->num_trips); }/**
drivers/thermal/gov_power_allocator.c +2 -2
@@ -527,7 +527,7 @@ static void get_governor_trips(struct thermal_zone_device *tz, last_active =INVALID_TRIP ; last_passive =INVALID_TRIP ; -for (i =0 ; i < tz->trips; i++) { +for (i =0 ; i < tz->num_trips; i++) {enum thermal_trip_type type;int ret;
@@ -668,7 +668,7 @@ static int power_allocator_bind(struct thermal_zone_device *tz)get_governor_trips (tz, params); -if (tz->trips >0 ) { +if (tz->num_trips >0 ) { ret = tz->ops->get_trip_temp (tz, params->trip_max_desired_temperature, &control_temp);
drivers/thermal/tegra/tegra30-tsensor.c +1 -1
@@ -316,7 +316,7 @@ static void tegra_tsensor_get_hw_channel_trips(struct thermal_zone_device *tzd, *hot_trip =85000 ; *crit_trip =90000 ; -for (i =0 ; i < tzd->trips; i++) { +for (i =0 ; i < tzd->num_trips; i++) {enum thermal_trip_type type;int trip_temp;
drivers/thermal/thermal_core.c +10 -10
@@ -505,7 +505,7 @@ void thermal_zone_device_update(struct thermal_zone_device *tz, tz->notify_event = event; -for (count =0 ; count < tz->trips; count++) +for (count =0 ; count < tz->num_trips; count++)handle_thermal_trip (tz, count); }EXPORT_SYMBOL_GPL (thermal_zone_device_update);
@@ -630,7 +630,7 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,unsigned long max_state;int result, ret; -if (trip >= tz->trips || trip <0 ) +if (trip >= tz->num_trips || trip <0 )return -EINVAL ;list_for_each_entry (pos1, &thermal_tz_list, node) {
@@ -811,7 +811,7 @@ static void __bind(struct thermal_zone_device *tz, int mask, {int i, ret; -for (i =0 ; i < tz->trips; i++) { +for (i =0 ; i < tz->num_trips; i++) {if (mask & (1 << i)) {unsigned long upper, lower;
@@ -1057,7 +1057,7 @@ static void __unbind(struct thermal_zone_device *tz, int mask, {int i; -for (i =0 ; i < tz->trips; i++) +for (i =0 ; i < tz->num_trips; i++)if (mask & (1 << i))thermal_zone_unbind_cooling_device (tz, i, cdev); }
@@ -1169,7 +1169,7 @@ static void thermal_set_delay_jiffies(unsigned long *delay_jiffies, int delay_ms/** * thermal_zone_device_register() - register a new thermal zone device * @type: the thermal zone device type -* @trips: the number of trip points the thermal zone support +* @num_trips: the number of trip points the thermal zone support * @mask: a bit string indicating the writeablility of trip points * @devdata: private device data * @ops: standard thermal zone device callbacks
@@ -1191,7 +1191,7 @@ static void thermal_set_delay_jiffies(unsigned long *delay_jiffies, int delay_ms* IS_ERR*() helpers. */ struct thermal_zone_device * -thermal_zone_device_register (const char *type,int trips,int mask, +thermal_zone_device_register (const char *type,int num_trips,int mask,void *devdata,struct thermal_zone_device_ops *ops,struct thermal_zone_params *tzp,int passive_delay,int polling_delay)
@@ -1215,7 +1215,7 @@ thermal_zone_device_register(const char *type, int trips, int mask,return ERR_PTR (-EINVAL ); } -if (trips >THERMAL_MAX_TRIPS || trips <0 || mask >> trips) { +if (num_trips >THERMAL_MAX_TRIPS || num_trips <0 || mask >> num_trips) {pr_err ("Incorrect number of thermal trips\n" );return ERR_PTR (-EINVAL ); }
@@ -1225,7 +1225,7 @@ thermal_zone_device_register(const char *type, int trips, int mask,return ERR_PTR (-EINVAL ); } -if (trips >0 && (!ops->get_trip_type || !ops->get_trip_temp)) +if (num_trips >0 && (!ops->get_trip_type || !ops->get_trip_temp))return ERR_PTR (-EINVAL ); tz =kzalloc (sizeof (*tz),GFP_KERNEL );
@@ -1255,7 +1255,7 @@ thermal_zone_device_register(const char *type, int trips, int mask, tz->tzp = tzp; tz->device.class = &thermal_class; tz->devdata = devdata; - tz->trips = trips; + tz->num_trips = num_trips;thermal_set_delay_jiffies (&tz->passive_delay_jiffies, passive_delay);thermal_set_delay_jiffies (&tz->polling_delay_jiffies, polling_delay);
@@ -1273,7 +1273,7 @@ thermal_zone_device_register(const char *type, int trips, int mask,if (result) goto release_device; -for (count =0 ; count < trips; count++) { +for (count =0 ; count < num_trips; count++) {if (tz->ops->get_trip_type (tz, count, &trip_type) || tz->ops->get_trip_temp (tz, count, &trip_temp) || !trip_temp)
drivers/thermal/thermal_helpers.c +2 -2
@@ -89,7 +89,7 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp) ret = tz->ops->get_temp (tz, temp);if (IS_ENABLED (CONFIG_THERMAL_EMULATION ) && tz->emul_temperature) { -for (count =0 ; count < tz->trips; count++) { +for (count =0 ; count < tz->num_trips; count++) { ret = tz->ops->get_trip_type (tz, count, &type);if (!ret && type ==THERMAL_TRIP_CRITICAL ) { ret = tz->ops->get_trip_temp(tz, count,
@@ -137,7 +137,7 @@ void thermal_zone_set_trips(struct thermal_zone_device *tz)if (!tz->ops->set_trips || !tz->ops->get_trip_hyst) goto exit; -for (i =0 ; i < tz->trips; i++) { +for (i =0 ; i < tz->num_trips; i++) {int trip_low; tz->ops->get_trip_temp (tz, i, &trip_temp);
drivers/thermal/thermal_netlink.c +1 -1
@@ -469,7 +469,7 @@ static int thermal_genl_cmd_tz_get_trip(struct param *p)mutex_lock (&tz->lock); -for (i =0 ; i < tz->trips; i++) { +for (i =0 ; i < tz->num_trips; i++) {enum thermal_trip_type type;int temp, hyst =0 ;
drivers/thermal/thermal_sysfs.c +11 -11
@@ -416,15 +416,15 @@ static int create_trip_attrs(struct thermal_zone_device *tz, int mask)int indx;/* This function works only for zones with at least one trip */ -if (tz->trips <=0 ) +if (tz->num_trips <=0 )return -EINVAL ; - tz->trip_type_attrs =kcalloc (tz->trips,sizeof (*tz->trip_type_attrs), + tz->trip_type_attrs =kcalloc (tz->num_trips,sizeof (*tz->trip_type_attrs),GFP_KERNEL );if (!tz->trip_type_attrs)return -ENOMEM ; - tz->trip_temp_attrs =kcalloc (tz->trips,sizeof (*tz->trip_temp_attrs), + tz->trip_temp_attrs =kcalloc (tz->num_trips,sizeof (*tz->trip_temp_attrs),GFP_KERNEL );if (!tz->trip_temp_attrs) {kfree (tz->trip_type_attrs);
@@ -432,7 +432,7 @@ static int create_trip_attrs(struct thermal_zone_device *tz, int mask) }if (tz->ops->get_trip_hyst) { - tz->trip_hyst_attrs =kcalloc (tz->trips, + tz->trip_hyst_attrs =kcalloc (tz->num_trips,sizeof (*tz->trip_hyst_attrs),GFP_KERNEL );if (!tz->trip_hyst_attrs) {
@@ -442,7 +442,7 @@ static int create_trip_attrs(struct thermal_zone_device *tz, int mask) } } - attrs =kcalloc (tz->trips *3 +1 ,sizeof (*attrs),GFP_KERNEL ); + attrs =kcalloc (tz->num_trips *3 +1 ,sizeof (*attrs),GFP_KERNEL );if (!attrs) {kfree (tz->trip_type_attrs);kfree (tz->trip_temp_attrs);
@@ -451,7 +451,7 @@ static int create_trip_attrs(struct thermal_zone_device *tz, int mask)return -ENOMEM ; } -for (indx =0 ; indx < tz->trips; indx++) { +for (indx =0 ; indx < tz->num_trips; indx++) {/* create trip type attribute */ snprintf (tz->trip_type_attrs[indx].name,THERMAL_NAME_LENGTH ,"trip_point_%d_type" , indx);
@@ -478,7 +478,7 @@ static int create_trip_attrs(struct thermal_zone_device *tz, int mask) tz->trip_temp_attrs[indx].attr.store = trip_point_temp_store; } - attrs[indx + tz->trips] = &tz->trip_temp_attrs[indx].attr.attr; + attrs[indx + tz->num_trips] = &tz->trip_temp_attrs[indx].attr.attr;/* create Optional trip hyst attribute */ if (!tz->ops->get_trip_hyst)
@@ -496,10 +496,10 @@ static int create_trip_attrs(struct thermal_zone_device *tz, int mask) tz->trip_hyst_attrs[indx].attr.store = trip_point_hyst_store; } - attrs[indx + tz->trips *2 ] = + attrs[indx + tz->num_trips *2 ] = &tz->trip_hyst_attrs[indx].attr.attr; } - attrs[tz->trips *3 ] =NULL ; + attrs[tz->num_trips *3 ] =NULL ; tz->trips_attribute_group.attrs = attrs;
@@ -540,7 +540,7 @@ int thermal_zone_create_device_groups(struct thermal_zone_device *tz,for (i =0 ; i < size -2 ; i++) groups[i] = thermal_zone_attribute_groups[i]; -if (tz->trips) { +if (tz->num_trips) { result =create_trip_attrs (tz, mask);if (result) {kfree (groups);
@@ -561,7 +561,7 @@ void thermal_zone_destroy_device_groups(struct thermal_zone_device *tz)if (!tz)return ; -if (tz->trips) +if (tz->num_trips)destroy_trip_attrs (tz);kfree (tz->device.groups);
include/linux/thermal.h +2 -2
@@ -125,7 +125,7 @@ struct thermal_cooling_device {* @trip_hyst_attrs: attributes for trip points for sysfs: trip hysteresis * @mode: current mode of this thermal zone * @devdata: private pointer for device private data -* @trips: number of trip points the thermal zone supports +* @num_trips: number of trip points the thermal zone supports * @trips_disabled; bitmap for disabled trips * @passive_delay_jiffies: number of jiffies to wait between polls when * performing passive cooling.
@@ -165,7 +165,7 @@ struct thermal_zone_device {struct thermal_attr *trip_hyst_attrs;enum thermal_device_mode mode;void *devdata; -int trips; +int num_trips;unsigned long trips_disabled;/* bitmap for disabled trips */ unsigned long passive_delay_jiffies;unsigned long polling_delay_jiffies;
Signature · 1 line
2.25.1
PATCH v4 8/12 thermal/core: Add thermal_trip in thermal_zone
In reply to Daniel LezcanoThe thermal trip points are properties of a thermal zone and the different sub systems should be able to save them in the thermal zone structure instead of having their own definition.
Give the opportunity to the drivers to create a thermal zone with thermal trips which will be accessible directly from the thermal core framework.
--- drivers/thermal/thermal_core.h | 10 ++++++++++ include/linux/thermal.h | 2 ++ 2 files changed, 12 insertions(+)
drivers/thermal/thermal_core.h +10 -0
@@ -113,6 +113,16 @@ int thermal_build_list_of_policies(char *buf);/* Helpers */ void thermal_zone_set_trips (struct thermal_zone_device *tz); +static inline struct thermal_trip *thermal_zone_get_trips (struct thermal_zone_device *tz) +{ +return tz->trips; +} + +static inline int thermal_zone_get_num_trips (struct thermal_zone_device *tz) +{ +return tz->num_trips; +} +/* sysfs I/F */ int thermal_zone_create_device_groups (struct thermal_zone_device *,int );void thermal_zone_destroy_device_groups (struct thermal_zone_device *);
include/linux/thermal.h +2 -0
@@ -125,6 +125,7 @@ struct thermal_cooling_device {* @trip_hyst_attrs: attributes for trip points for sysfs: trip hysteresis * @mode: current mode of this thermal zone * @devdata: private pointer for device private data +* @trips: an array of struct thermal_trip * @num_trips: number of trip points the thermal zone supports * @trips_disabled; bitmap for disabled trips * @passive_delay_jiffies: number of jiffies to wait between polls when
@@ -165,6 +166,7 @@ struct thermal_zone_device {struct thermal_attr *trip_hyst_attrs;enum thermal_device_mode mode;void *devdata; +struct thermal_trip *trips;int num_trips;unsigned long trips_disabled;/* bitmap for disabled trips */ unsigned long passive_delay_jiffies;
Signature · 1 line
2.25.1
PATCH v4 9/12 thermal/core: Register with the trip points
In reply to Daniel LezcanoAs we added the thermal trip points structure in the thermal zone, let's extend the thermal zone register function to have the thermal trip structures as a parameter and store it in the 'trips' field of the thermal zone structure.
--- drivers/thermal/thermal_core.c | 22 +++++++++++++++++----- include/linux/thermal.h | 6 ++++++ 2 files changed, 23 insertions(+), 5 deletions(-)
drivers/thermal/thermal_core.c +17 -5
@@ -1167,8 +1167,9 @@ static void thermal_set_delay_jiffies(unsigned long *delay_jiffies, int delay_ms }/** -* thermal_zone_device_register() - register a new thermal zone device +* thermal_zone_device_register_with_trips() - register a new thermal zone device * @type: the thermal zone device type +* @trips: a pointer to an array of thermal trips * @num_trips: the number of trip points the thermal zone support * @mask: a bit string indicating the writeablility of trip points * @devdata: private device data
@@ -1191,10 +1192,10 @@ static void thermal_set_delay_jiffies(unsigned long *delay_jiffies, int delay_ms* IS_ERR*() helpers. */ struct thermal_zone_device * -thermal_zone_device_register (const char *type,int num_trips,int mask, -void *devdata,struct thermal_zone_device_ops *ops, -struct thermal_zone_params *tzp,int passive_delay, -int polling_delay) +thermal_zone_device_register_with_trips (const char *type,struct thermal_trip *trips,int num_trips,int mask, +void *devdata,struct thermal_zone_device_ops *ops, +struct thermal_zone_params *tzp,int passive_delay, +int polling_delay) {struct thermal_zone_device *tz;enum thermal_trip_type trip_type;
@@ -1255,6 +1256,7 @@ thermal_zone_device_register(const char *type, int num_trips, int mask, tz->tzp = tzp; tz->device.class = &thermal_class; tz->devdata = devdata; + tz->trips = trips; tz->num_trips = num_trips;thermal_set_delay_jiffies (&tz->passive_delay_jiffies, passive_delay);
@@ -1331,6 +1333,16 @@ thermal_zone_device_register(const char *type, int num_trips, int mask,kfree (tz);return ERR_PTR (result); } + +struct thermal_zone_device *thermal_zone_device_register (const char *type,int ntrips,int mask, +void *devdata,struct thermal_zone_device_ops *ops, +struct thermal_zone_params *tzp,int passive_delay, +int polling_delay) +{ +return thermal_zone_device_register_with_trips (type,NULL , ntrips, mask, + devdata, ops, tzp, + passive_delay, polling_delay); +}EXPORT_SYMBOL_GPL (thermal_zone_device_register);/**
include/linux/thermal.h +6 -0
@@ -380,8 +380,14 @@ void devm_thermal_zone_of_sensor_unregister(struct device *dev,struct thermal_zone_device *thermal_zone_device_register (const char *,int ,int ,void *,struct thermal_zone_device_ops *,struct thermal_zone_params *,int ,int ); +void thermal_zone_device_unregister (struct thermal_zone_device *); +struct thermal_zone_device * +thermal_zone_device_register_with_trips (const char *,struct thermal_trip *,int ,int , +void *,struct thermal_zone_device_ops *, +struct thermal_zone_params *,int ,int ); + int thermal_zone_bind_cooling_device(struct thermal_zone_device *, int, struct thermal_cooling_device *, unsigned long, unsigned long,
Signature · 1 line
2.25.1
PATCH v4 10/12 thermal/of: Store the trips in the thermal zone
In reply to Daniel LezcanoAs the thermal zone contains the trip point, we can store them directly when registering the thermal zone. That will allow another step forward to remove the duplicate thermal zone structure we find in the thermal_of code.
--- drivers/thermal/thermal_of.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/thermal/thermal_of.c +3 -5
@@ -1119,11 +1119,9 @@ int __init of_parse_thermal_zones(void) tzp->slope = tz->slope; tzp->offset = tz->offset; - zone =thermal_zone_device_register (child->name, tz->ntrips, - mask, tz, - ops, tzp, - tz->passive_delay, - tz->polling_delay); + zone =thermal_zone_device_register_with_trips (child->name, tz->trips, tz->ntrips, + mask, tz, ops, tzp, tz->passive_delay, + tz->polling_delay);if (IS_ERR (zone)) {pr_err ("Failed to build %pOFn zone %ld\n" , child,PTR_ERR (zone));
Signature · 1 line
2.25.1
PATCH v4 11/12 thermal/of: Use thermal trips stored in the thermal zone
In reply to Daniel LezcanoNow that we have the thermal trip stored in the thermal zone in a generic way, we can rely on them and remove one indirection we found in the thermal_of code and do one more step forward the removal of the duplicated structures.
--- drivers/thermal/thermal_of.c | 53 +++++++++++------------------------- 1 file changed, 16 insertions(+), 37 deletions(-)
drivers/thermal/thermal_of.c +16 -37
@@ -118,12 +118,7 @@ static int of_thermal_set_trips(struct thermal_zone_device *tz,*/ int of_thermal_get_ntrips (struct thermal_zone_device *tz) { -struct __thermal_zone *data = tz->devdata; - -if (!data ||IS_ERR (data)) -return -ENODEV ; - -return data->ntrips; +return tz->ntrips; }EXPORT_SYMBOL_GPL (of_thermal_get_ntrips);
@@ -139,9 +134,7 @@ EXPORT_SYMBOL_GPL(of_thermal_get_ntrips);*/ bool of_thermal_is_trip_valid (struct thermal_zone_device *tz,int trip) { -struct __thermal_zone *data = tz->devdata; - -if (!data || trip >= data->ntrips || trip <0 ) +if (trip >= tz->ntrips || trip <0 )return false;return true;
@@ -161,12 +154,7 @@ EXPORT_SYMBOL_GPL(of_thermal_is_trip_valid);const struct thermal_trip *of_thermal_get_trip_points (struct thermal_zone_device *tz) { -struct __thermal_zone *data = tz->devdata; - -if (!data) -return NULL ; - -return data->trips; +return tz->trips; }EXPORT_SYMBOL_GPL (of_thermal_get_trip_points);
@@ -281,12 +269,10 @@ static int of_thermal_unbind(struct thermal_zone_device *thermal,static int of_thermal_get_trip_type (struct thermal_zone_device *tz,int trip,enum thermal_trip_type *type) { -struct __thermal_zone *data = tz->devdata; - -if (trip >= data->ntrips || trip <0 ) +if (trip >= tz->ntrips || trip <0 )return -EDOM ; - *type = data->trips[trip].type; + *type = tz->trips[trip].type;return 0 ; }
@@ -294,12 +280,10 @@ static int of_thermal_get_trip_type(struct thermal_zone_device *tz, int trip,static int of_thermal_get_trip_temp (struct thermal_zone_device *tz,int trip,int *temp) { -struct __thermal_zone *data = tz->devdata; - -if (trip >= data->ntrips || trip <0 ) +if (trip >= tz->ntrips || trip <0 )return -EDOM ; - *temp = data->trips[trip].temperature; + *temp = tz->trips[trip].temperature;return 0 ; }
@@ -309,7 +293,7 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip, {struct __thermal_zone *data = tz->devdata; -if (trip >= data->ntrips || trip <0 ) +if (trip >= tz->ntrips || trip <0 )return -EDOM ;if (data->ops && data->ops->set_trip_temp) {
@@ -321,7 +305,7 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip, }/* thermal framework should take care of data->mask & (1 << trip) */ - data->trips[trip].temperature = temp; + tz->trips[trip].temperature = temp;return 0 ; }
@@ -329,12 +313,10 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip,static int of_thermal_get_trip_hyst (struct thermal_zone_device *tz,int trip,int *hyst) { -struct __thermal_zone *data = tz->devdata; - -if (trip >= data->ntrips || trip <0 ) +if (trip >= tz->ntrips || trip <0 )return -EDOM ; - *hyst = data->trips[trip].hysteresis; + *hyst = tz->trips[trip].hysteresis;return 0 ; }
@@ -342,13 +324,11 @@ static int of_thermal_get_trip_hyst(struct thermal_zone_device *tz, int trip,static int of_thermal_set_trip_hyst (struct thermal_zone_device *tz,int trip,int hyst) { -struct __thermal_zone *data = tz->devdata; - -if (trip >= data->ntrips || trip <0 ) +if (trip >= tz->ntrips || trip <0 )return -EDOM ;/* thermal framework should take care of data->mask & (1 << trip) */ - data->trips[trip].hysteresis = hyst; + tz->trips[trip].hysteresis = hyst;return 0 ; }
@@ -356,12 +336,11 @@ static int of_thermal_set_trip_hyst(struct thermal_zone_device *tz, int trip,static int of_thermal_get_crit_temp (struct thermal_zone_device *tz,int *temp) { -struct __thermal_zone *data = tz->devdata;int i; -for (i =0 ; i < data->ntrips; i++) -if (data->trips[i].type ==THERMAL_TRIP_CRITICAL ) { - *temp = data->trips[i].temperature; +for (i =0 ; i < tz->ntrips; i++) +if (tz->trips[i].type ==THERMAL_TRIP_CRITICAL ) { + *temp = tz->trips[i].temperature;return 0 ; }
Signature · 1 line
2.25.1
PATCH v4 12/12 thermal/of: Initialize trip points separately
In reply to Daniel LezcanoSelf contain the trip initialization from the device tree in a single function for the sake of making the code flow more clear.
--- drivers/thermal/thermal_of.c | 101 ++++++++++++++++++++++------------- 1 file changed, 65 insertions(+), 36 deletions(-)
drivers/thermal/thermal_of.c +65 -36
@@ -118,7 +118,7 @@ static int of_thermal_set_trips(struct thermal_zone_device *tz,*/ int of_thermal_get_ntrips (struct thermal_zone_device *tz) { -return tz->ntrips; +return tz->num_trips; }EXPORT_SYMBOL_GPL (of_thermal_get_ntrips);
@@ -134,7 +134,7 @@ EXPORT_SYMBOL_GPL(of_thermal_get_ntrips);*/ bool of_thermal_is_trip_valid (struct thermal_zone_device *tz,int trip) { -if (trip >= tz->ntrips || trip <0 ) +if (trip >= tz->num_trips || trip <0 )return false;return true;
@@ -269,7 +269,7 @@ static int of_thermal_unbind(struct thermal_zone_device *thermal,static int of_thermal_get_trip_type (struct thermal_zone_device *tz,int trip,enum thermal_trip_type *type) { -if (trip >= tz->ntrips || trip <0 ) +if (trip >= tz->num_trips || trip <0 )return -EDOM ; *type = tz->trips[trip].type;
@@ -280,7 +280,7 @@ static int of_thermal_get_trip_type(struct thermal_zone_device *tz, int trip,static int of_thermal_get_trip_temp (struct thermal_zone_device *tz,int trip,int *temp) { -if (trip >= tz->ntrips || trip <0 ) +if (trip >= tz->num_trips || trip <0 )return -EDOM ; *temp = tz->trips[trip].temperature;
@@ -293,7 +293,7 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip, {struct __thermal_zone *data = tz->devdata; -if (trip >= tz->ntrips || trip <0 ) +if (trip >= tz->num_trips || trip <0 )return -EDOM ;if (data->ops && data->ops->set_trip_temp) {
@@ -313,7 +313,7 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip,static int of_thermal_get_trip_hyst (struct thermal_zone_device *tz,int trip,int *hyst) { -if (trip >= tz->ntrips || trip <0 ) +if (trip >= tz->num_trips || trip <0 )return -EDOM ; *hyst = tz->trips[trip].hysteresis;
@@ -324,7 +324,7 @@ static int of_thermal_get_trip_hyst(struct thermal_zone_device *tz, int trip,static int of_thermal_set_trip_hyst (struct thermal_zone_device *tz,int trip,int hyst) { -if (trip >= tz->ntrips || trip <0 ) +if (trip >= tz->num_trips || trip <0 )return -EDOM ;/* thermal framework should take care of data->mask & (1 << trip) */
@@ -338,7 +338,7 @@ static int of_thermal_get_crit_temp(struct thermal_zone_device *tz, {int i; -for (i =0 ; i < tz->ntrips; i++) +for (i =0 ; i < tz->num_trips; i++)if (tz->trips[i].type ==THERMAL_TRIP_CRITICAL ) { *temp = tz->trips[i].temperature;return 0 ;
@@ -693,7 +693,8 @@ static int of_find_trip_id(struct device_node *np, struct device_node *trip)* * Return: 0 on success, proper error code otherwise */ -static int thermal_of_populate_bind_params (struct device_node *np, +static int thermal_of_populate_bind_params (struct device_node *tz_np, +struct device_node *np,struct __thermal_bind_params *__tbp) {struct of_phandle_args cooling_spec;
@@ -715,7 +716,7 @@ static int thermal_of_populate_bind_params(struct device_node *np,return -ENODEV ; } - trip_id =of_find_trip_id (np, trip); + trip_id =of_find_trip_id (tz_np, trip);if (trip_id <0 ) { ret = trip_id; goto end;
@@ -849,6 +850,53 @@ static int thermal_of_populate_trip(struct device_node *np,return 0 ; } +static struct thermal_trip *thermal_of_trips_init (struct device_node *np,int *ntrips) +{ +struct thermal_trip *tt; +struct device_node *trips, *trip; +int ret, count; + + trips =of_get_child_by_name (np,"trips" ); +if (!trips) { +pr_err ("Failed to find 'trips' node\n" ); +return ERR_PTR (-EINVAL ); + } + + count =of_get_child_count (trips); +if (!count) { +pr_err ("No trip point defined\n" ); + ret = -EINVAL ; + goto out_of_node_put; + } + + tt =kzalloc (sizeof (*tt) * count,GFP_KERNEL ); +if (!tt) { + ret = -ENOMEM ; + goto out_of_node_put; + } + + *ntrips = count; + + count =0 ; +for_each_child_of_node (trips, trip) { + ret =thermal_of_populate_trip (trip, &tt[count++]); +if (ret) + goto out_kfree; + } + +of_node_put (trips); + +return tt; + +out_kfree: +kfree (tt); + *ntrips =0 ; +out_of_node_put: +of_node_put (trips); + +return ERR_PTR (ret); +} +/** * thermal_of_build_thermal_zone - parse and fill one thermal zone data * @np: DT node containing a thermal zone node
@@ -867,7 +915,6 @@ static struct __thermal_zone __init *thermal_of_build_thermal_zone(struct device_node *np) {struct device_node *child =NULL , *gchild; -struct device_node *trips;struct __thermal_zone *tz;int ret, i;u32 prop, coef[2 ];
@@ -909,28 +956,10 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) tz->offset =0 ; } -/* trips */ - trips =of_get_child_by_name (np,"trips" ); - -/* No trips provided */ -if (!trips) + tz->trips =thermal_of_trips_init (np, &tz->ntrips); +if (IS_ERR (tz->trips)) { + ret =PTR_ERR (tz->trips); goto finish; - - tz->ntrips =of_get_child_count (trips); -if (tz->ntrips ==0 )/* must have at least one child */ - goto finish; - - tz->trips =kcalloc (tz->ntrips,sizeof (*tz->trips),GFP_KERNEL ); -if (!tz->trips) { - ret = -ENOMEM ; - goto free_tz; - } - - i =0 ; -for_each_child_of_node (trips, gchild) { - ret =thermal_of_populate_trip (gchild, &tz->trips[i++]); -if (ret) - goto free_trips; }/* cooling-maps */
@@ -952,13 +981,14 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) i =0 ;for_each_child_of_node (child, gchild) { - ret =thermal_of_populate_bind_params (gchild, &tz->tbps[i++]); -if (ret) + ret =thermal_of_populate_bind_params (np, gchild, &tz->tbps[i++]); +if (ret) { +of_node_put (gchild); goto free_tbps; + } } finish: -of_node_put (trips);of_node_put (child);return tz;
@@ -977,7 +1007,6 @@ __init *thermal_of_build_thermal_zone(struct device_node *np)kfree (tz->tbps); free_trips:kfree (tz->trips); -of_node_put (trips);of_node_put (gchild); free_tz:kfree (tz);
Signature · 1 line
2.25.1
kernel test robot
build botRe: [PATCH v4 12/12] thermal/of: Initialize trip points separately
I love your patch! Perhaps something to improve:
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on tegra/for-next linus/master v5.19-rc5 next-20220708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-OF-rework/20220710-063550 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20220710/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 77a38f6839980bfac61babb40d83772c51427011)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/ae09a5baa03d816f54f1e0654fd0ad08eab5d427
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Daniel-Lezcano/thermal-OF-rework/20220710-063550
git checkout ae09a5baa03d816f54f1e0654fd0ad08eab5d427
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/thermal/
If you fix the issue, kindly add following tag where applicable
All warnings (new ones prefixed by >>):
>> drivers/thermal/thermal_of.c:977:6: warning: variable 'gchild' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!tz->tbps) {
^~~~~~~~~
drivers/thermal/thermal_of.c:1010:14: note: uninitialized use occurs here
of_node_put(gchild);
^~~~~~
drivers/thermal/thermal_of.c:977:2: note: remove the 'if' if its condition is always false
if (!tz->tbps) {
^~~~~~~~~~~~~~~~
drivers/thermal/thermal_of.c:917:43: note: initialize the variable 'gchild' to silence this warning
struct device_node *child = NULL, *gchild;
^
= NULL1 warning generated.
vim +977 drivers/thermal/thermal_of.c
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 899
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 900 /**
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 901 * thermal_of_build_thermal_zone - parse and fill one thermal zone data
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 902 * @np: DT node containing a thermal zone node
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 903 *
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 904 * This function parses a thermal zone type of node represented by
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 905 * @np parameter and fills the read data into a __thermal_zone data structure
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 906 * and return this pointer.
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 907 *
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 908 * TODO: Missing properties to parse: thermal-sensor-names
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 909 *
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 910 * Return: On success returns a valid struct __thermal_zone,
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 911 * otherwise, it returns a corresponding ERR_PTR(). Caller must
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 912 * check the return value with help of IS_ERR() helper.
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 913 */
c0ff8aaae36955 drivers/thermal/of-thermal.c Julia Lawall 2016-04-19 914 static struct __thermal_zone
c0ff8aaae36955 drivers/thermal/of-thermal.c Julia Lawall 2016-04-19 915 __init *thermal_of_build_thermal_zone(struct device_node *np)
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 916 {
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 917 struct device_node *child = NULL, *gchild;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 918 struct __thermal_zone *tz;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 919 int ret, i;
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 920 u32 prop, coef[2];
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 921
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 922 if (!np) {
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 923 pr_err("no thermal zone np\n");
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 924 return ERR_PTR(-EINVAL);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 925 }
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 926
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 927 tz = kzalloc(sizeof(*tz), GFP_KERNEL);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 928 if (!tz)
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 929 return ERR_PTR(-ENOMEM);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 930
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 931 ret = of_property_read_u32(np, "polling-delay-passive", &prop);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 932 if (ret < 0) {
3079f340caa72a drivers/thermal/of-thermal.c Amit Kucheria 2019-01-21 933 pr_err("%pOFn: missing polling-delay-passive property\n", np);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 934 goto free_tz;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 935 }
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 936 tz->passive_delay = prop;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 937
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 938 ret = of_property_read_u32(np, "polling-delay", &prop);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 939 if (ret < 0) {
3079f340caa72a drivers/thermal/of-thermal.c Amit Kucheria 2019-01-21 940 pr_err("%pOFn: missing polling-delay property\n", np);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 941 goto free_tz;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 942 }
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 943 tz->polling_delay = prop;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 944
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 945 /*
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 946 * REVIST: for now, the thermal framework supports only
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 947 * one sensor per thermal zone. Thus, we are considering
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 948 * only the first two values as slope and offset.
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 949 */
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 950 ret = of_property_read_u32_array(np, "coefficients", coef, 2);
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 951 if (ret == 0) {
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 952 tz->slope = coef[0];
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 953 tz->offset = coef[1];
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 954 } else {
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 955 tz->slope = 1;
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 956 tz->offset = 0;
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 957 }
a46dbae8abe5cd drivers/thermal/of-thermal.c Eduardo Valentin 2015-05-11 958
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 959 tz->trips = thermal_of_trips_init(np, &tz->ntrips);
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 960 if (IS_ERR(tz->trips)) {
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 961 ret = PTR_ERR(tz->trips);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 962 goto finish;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 963 }
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 964
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 965 /* cooling-maps */
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 966 child = of_get_child_by_name(np, "cooling-maps");
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 967
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 968 /* cooling-maps not provided */
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 969 if (!child)
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 970 goto finish;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 971
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 972 tz->num_tbps = of_get_child_count(child);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 973 if (tz->num_tbps == 0)
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 974 goto finish;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 975
6396bb221514d2 drivers/thermal/of-thermal.c Kees Cook 2018-06-12 976 tz->tbps = kcalloc(tz->num_tbps, sizeof(*tz->tbps), GFP_KERNEL);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 @977 if (!tz->tbps) {
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 978 ret = -ENOMEM;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 979 goto free_trips;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 980 }
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 981
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 982 i = 0;
ca9521b770c988 drivers/thermal/of-thermal.c Stephen Boyd 2014-06-18 983 for_each_child_of_node(child, gchild) {
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 984 ret = thermal_of_populate_bind_params(np, gchild, &tz->tbps[i++]);
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 985 if (ret) {
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 986 of_node_put(gchild);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 987 goto free_tbps;
ca9521b770c988 drivers/thermal/of-thermal.c Stephen Boyd 2014-06-18 988 }
ae09a5baa03d81 drivers/thermal/thermal_of.c Daniel Lezcano 2022-07-10 989 }
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 990
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 991 finish:
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 992 of_node_put(child);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 993
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 994 return tz;
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 995
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 996 free_tbps:
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 997 for (i = i - 1; i >= 0; i--) {
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 998 struct __thermal_bind_params *tbp = tz->tbps + i;
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 999 int j;
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 1000
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 1001 for (j = 0; j < tbp->count; j++)
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 1002 of_node_put(tbp->tcbp[j].cooling_device);
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 1003
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 1004 kfree(tbp->tcbp);
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 1005 }
a92bab8919e3fb drivers/thermal/of-thermal.c Viresh Kumar 2018-08-08 1006
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1007 kfree(tz->tbps);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1008 free_trips:
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1009 kfree(tz->trips);
c2aad93c7edd5e drivers/thermal/of-thermal.c Vladimir Zapolskiy 2014-09-29 1010 of_node_put(gchild);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1011 free_tz:
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1012 kfree(tz);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1013 of_node_put(child);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1014
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1015 return ERR_PTR(ret);
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1016 }
4e5e4705bf69ea drivers/thermal/of-thermal.c Eduardo Valentin 2013-07-03 1017 Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp