Skip to contentSkip to conversation

platform/x86/intel/ifs: Mark as BROKEN

PATCH In review Hans de Goede 2 participants 3 messages Jul 10, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86/intel/ifs: Mark as BROKEN

A recent suggested change to the IFS code has shown that the userspace API needs a bit more work, see:
https://lore.kernel.org/platform-driver-x86/[email protected]/

Mark it as BROKEN before 5.19 ships, to give ourselves one more kernel-devel cycle to get the userspace API right.

---
 drivers/platform/x86/intel/ifs/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/platform/x86/intel/ifs/Kconfig +3 -0
index 7ce896434b8f..c341a27cc1a3 100644
@@ -1,6 +1,9 @@
 config INTEL_IFS
 	tristate "Intel In Field Scan"
 	depends on X86 && CPU_SUP_INTEL && 64BIT && SMP
+	# Discussion on the list has shown that the sysfs API needs a bit
+	# more work, mark this as broken for now
+	depends on BROKEN
 	select INTEL_IFS_DEVICE
 	help
 	  Enable support for the In Field Scan capability in select
Signature · 1 line
2.36.0
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Hans de Goede

A recent suggested change to the IFS code has shown that the userspace API needs a bit more work, see:
https://lore.kernel.org/platform-driver-x86/[email protected]/

Mark it as BROKEN before 5.19 ships, to give ourselves one more kernel-devel cycle to get the userspace API right.

Quoted 3 lines
---
 drivers/platform/x86/intel/ifs/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
#2 lore raw
In reply to Hans de Goede

Hi,

Quoted 7 lines · Hans de Goede

A recent suggested change to the IFS code has shown that the userspace API needs a bit more work, see:
https://lore.kernel.org/platform-driver-x86/[email protected]/

Mark it as BROKEN before 5.19 ships, to give ourselves one more kernel-devel cycle to get the userspace API right.

Quoted 6 lines

I've added this to my review-hans (soon to be for-next) branch now.

Regards,

Hans

Quoted 18 lines
---
 drivers/platform/x86/intel/ifs/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/platform/x86/intel/ifs/Kconfig +3 -0
index 7ce896434b8f..c341a27cc1a3 100644
@@ -1,6 +1,9 @@
 config INTEL_IFS
 	tristate "Intel In Field Scan"
 	depends on X86 && CPU_SUP_INTEL && 64BIT && SMP
+	# Discussion on the list has shown that the sysfs API needs a bit
+	# more work, mark this as broken for now
+	depends on BROKEN
 	select INTEL_IFS_DEVICE
 	help
 	  Enable support for the In Field Scan capability in select