Skip to contentSkip to conversation

platform/x86: intel_atomisp2_led: Also turn off the always-on camera LED on the Asus T100TAF

PATCH In review Hans de Goede 2 participants 4 messages Jul 10, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: intel_atomisp2_led: Also turn off the always-on camera LED on the Asus T100TAF

Like the Asus T100TA the Asus T100TAF has a camera LED which is always on by default and both also use the same GPIO for the LED.

Relax the DMI match for the Asus T100TA so that it also matches the T100TAF.

---
 drivers/platform/x86/intel/atomisp2/led.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/platform/x86/intel/atomisp2/led.c +2 -1
index 5935dfca166f..10077a61d8c5 100644
@@ -50,7 +50,8 @@ static const struct dmi_system_id atomisp2_led_systems[] __initconst = {
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TA"),
+			/* Non exact match to also match T100TAF */
+			DMI_MATCH(DMI_PRODUCT_NAME, "T100TA"),
 		},
 		.driver_data = &asus_t100ta_lookup,
 	},
Signature · 1 line
2.36.0
#1 lore raw

Hi,

Quoted 7 lines · Hans de Goede

Like the Asus T100TA the Asus T100TAF has a camera LED which is always on by default and both also use the same GPIO for the LED.

Relax the DMI match for the Asus T100TA so that it also matches the T100TAF.

I've added this to my review-hans (soon to be for-next) branch now.

Regards,

Hans

Quoted 18 lines
---
 drivers/platform/x86/intel/atomisp2/led.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/platform/x86/intel/atomisp2/led.c +2 -1
index 5935dfca166f..10077a61d8c5 100644
@@ -50,7 +50,8 @@ static const struct dmi_system_id atomisp2_led_systems[] __initconst = {
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TA"),
+			/* Non exact match to also match T100TAF */
+			DMI_MATCH(DMI_PRODUCT_NAME, "T100TA"),
 		},
 		.driver_data = &asus_t100ta_lookup,
 	},
#2 lore raw
In reply to Hans de Goede
Quoted 5 lines · Hans de Goede

Like the Asus T100TA the Asus T100TAF has a camera LED which is always on by default and both also use the same GPIO for the LED.

Relax the DMI match for the Asus T100TA so that it also matches the T100TAF.

Shouldn't atomisp driver take care about this (presumable in the future)?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

Hi,

Quoted 8 lines · Andy Shevchenko
Quoted 5 lines · Hans de Goede

Like the Asus T100TA the Asus T100TAF has a camera LED which is always on by default and both also use the same GPIO for the LED.

Relax the DMI match for the Asus T100TA so that it also matches the T100TAF.

Shouldn't atomisp driver take care about this (presumable in the future)?

Eventually yes, for now we have a small driver to at least turn of the LED on devices where it is on at boot (or to be more precise gets turned on when running the ACPI INIT method of the asus-wmi WMI device).

Regards,

Hans