Skip to contentSkip to conversation

python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

PATCH In review Thomas Huth 2 participants 4 messages Jul 11, 2022 – Jul 18, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

'returns-whitelist' has been renamed to 'command-returns-exceptions' in commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").

---
 python/qemu/qmp/legacy.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
python/qemu/qmp/legacy.py +1 -1
index 03b5574618..1951754455 100644
@@ -50,7 +50,7 @@
 
 # QMPMessage can be outgoing commands or incoming events/returns.
 # QMPReturnValue is usually a dict/json object, but due to QAPI's
-# 'returns-whitelist', it can actually be anything.
+# 'command-returns-exceptions', it can actually be anything.
 #
 # {'return': {}} is a QMPMessage,
 # {} is the QMPReturnValue.
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines · Thomas Huth

'returns-whitelist' has been renamed to 'command-returns-exceptions' in commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").

---
 python/qemu/qmp/legacy.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
python/qemu/qmp/legacy.py +1 -2
index 03b5574618..1951754455 100644
@@ -50,7 +50,7 @@
 
 # QMPMessage can be outgoing commands or incoming events/returns.
 # QMPReturnValue is usually a dict/json object, but due to QAPI's
-# 'returns-whitelist', it can actually be anything.
+# 'command-returns-exceptions', it can actually be anything.
 #
 # {'return': {}} is a QMPMessage,
 # {} is the QMPReturnValue.
--
Quoted 2 lines

2.31.1

May I cajole you to send a MR to
https://gitlab.com/qemu-project/python-qemu-qmp ?

(Sorry for the duplicated effort while the library isn't 100% split out of the tree yet.)

In this case, for qemu.git:

#2 lore raw
Quoted 31 lines · John Snow
Quoted 23 lines · Thomas Huth

'returns-whitelist' has been renamed to 'command-returns-exceptions' in commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").

---
 python/qemu/qmp/legacy.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
python/qemu/qmp/legacy.py +1 -2
index 03b5574618..1951754455 100644
@@ -50,7 +50,7 @@
 
 # QMPMessage can be outgoing commands or incoming events/returns.
 # QMPReturnValue is usually a dict/json object, but due to QAPI's
-# 'returns-whitelist', it can actually be anything.
+# 'command-returns-exceptions', it can actually be anything.
 #
 # {'return': {}} is a QMPMessage,
 # {} is the QMPReturnValue.
--
Quoted 2 lines

2.31.1

May I cajole you to send a MR to
https://gitlab.com/qemu-project/python-qemu-qmp ?

Quoted 6 lines

(Sorry for the duplicated effort while the library isn't 100% split out of the tree yet.)

In this case, for qemu.git:

Queued.

--js

#3 lore raw
In reply to John Snow
Quoted 16 lines · John Snow
Quoted 15 lines · Thomas Huth

'returns-whitelist' has been renamed to 'command-returns-exceptions' in commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").

---
  python/qemu/qmp/legacy.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
python/qemu/qmp/legacy.py +0 -0
index 03b5574618..1951754455 100644
@@ -50,7 +50,7 @@
 
Quoted 13 lines
Quoted 10 lines
python/qemu/qmp/legacy.py +1 -2
  # QMPMessage can be outgoing commands or incoming events/returns.
  # QMPReturnValue is usually a dict/json object, but due to QAPI's
-# 'returns-whitelist', it can actually be anything.
+# 'command-returns-exceptions', it can actually be anything.
  #
  # {'return': {}} is a QMPMessage,
  # {} is the QMPReturnValue.
--

2.31.1

May I cajole you to send a MR to
https://gitlab.com/qemu-project/python-qemu-qmp ?

Sure, done now:

https://gitlab.com/qemu-project/python-qemu-qmp/-/merge_requests/9

Thomas