mfd: ab8500: clean up definitions in header after debugfs removal
PATCH v2 1/1 mfd: ab8500: clean up definitions in header after debugfs removal
Commit 3d4d1266597c ("mfd: ab8500: Drop debugfs module") removes the config AB8500_DEBUG in drivers/mfd/Kconfig, but missed a reference to this config in include/linux/mfd/abx500/ab8500.h.
The functions ab8500_dump_all_banks() and ab8500_debug_register_interrupt() in the ab8500 header, previously with definitions conditioned on AB8500_DEBUG, are now completely needless to define and handle at all.
The function ab8500_debug_register_interrupt() is not used at all and can just be removed.
The function ab8500_dump_all_banks() is just registered in the abx500_ops struct in the dump_all_banks field, but this is then not further referenced anywhere else at all. So, safely drop the dump_all_banks field from abx500_ops and delete the ab8500_dump_all_banks() definition.
---
Lee, please pick this minor clean-up patch.
v1:
https://lore.kernel.org/all/[email protected]/
v1 -> v2:
- leave "," in as requested in https://lore.kernel.org/all/[email protected]/
- add Reviewed-by tag from Linus W. from
https://lore.kernel.org/all/CACRpkdbjy2Cpzs7j6=iWw+wnJxBHkaxgcO2SOx6DeTLeF4ogPw@mail.gmail.com/
drivers/mfd/ab8500-core.c | 1 - include/linux/mfd/abx500.h | 1 - include/linux/mfd/abx500/ab8500.h | 9 --------- 3 files changed, 11 deletions(-)
drivers/mfd/ab8500-core.c +0 -1
@@ -329,7 +329,6 @@ static struct abx500_ops ab8500_ops = { .mask_and_set_register = ab8500_mask_and_set_register, .event_registers_startup_state_get = NULL, .startup_irq_enabled = NULL, - .dump_all_banks = ab8500_dump_all_banks, };static void ab8500_irq_lock (struct irq_data *data)
include/linux/mfd/abx500.h +0 -1
@@ -63,7 +63,6 @@ struct abx500_ops {int (*mask_and_set_register) (struct device *,u8 ,u8 ,u8 ,u8 );int (*event_registers_startup_state_get) (struct device *,u8 *);int (*startup_irq_enabled) (struct device *,unsigned int ); -void (*dump_all_banks) (struct device *); };int abx500_register_ops (struct device *core_dev,struct abx500_ops *ops);
include/linux/mfd/abx500/ab8500.h +0 -9
@@ -503,13 +503,4 @@ static inline int is_ab9540_2p0_or_earlier(struct ab8500 *ab)void ab8500_override_turn_on_stat (u8 mask,u8 set); -#ifdef CONFIG_AB8500_DEBUG -extern int prcmu_abb_read (u8 slave,u8 reg,u8 *value,u8 size); -void ab8500_dump_all_banks (struct device *dev); -void ab8500_debug_register_interrupt (int line); -#else -static inline void ab8500_dump_all_banks (struct device *dev) {} -static inline void ab8500_debug_register_interrupt (int line) {} -#endif -#endif /* MFD_AB8500_H */
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel